X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/9090c60b28de593b8bb2ce606a9ab35b62b57608..0eb72b526bf8bbb011551ecf019f604e17a534f1:/services/api/app/models/arvados_model.rb diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb index 23bb71a74b..ea69735502 100644 --- a/services/api/app/models/arvados_model.rb +++ b/services/api/app/models/arvados_model.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'has_uuid' require 'record_filters' require 'serializers' @@ -46,6 +50,12 @@ class ArvadosModel < ActiveRecord::Base end end + class LockFailedError < StandardError + def http_status + 422 + end + end + class InvalidStateTransitionError < StandardError def http_status 422 @@ -79,8 +89,17 @@ class ArvadosModel < ActiveRecord::Base # The following permit! is necessary even with # "ActionController::Parameters.permit_all_parameters = true", # because permit_all does not permit nested attributes. - if has_nonstring_keys?(raw_params) - raise ArgumentError.new("Parameters cannot have non-string keys") + if raw_params + serialized_attributes.each do |colname, coder| + param = raw_params[colname.to_sym] + if param.nil? + # ok + elsif !param.is_a?(coder.object_class) + raise ArgumentError.new("#{colname} parameter must be #{coder.object_class}, not #{param.class}") + elsif has_nonstring_keys?(param) + raise ArgumentError.new("#{colname} parameter cannot have non-string hash keys") + end + end end ActionController::Parameters.new(raw_params).permit! end @@ -89,6 +108,12 @@ class ArvadosModel < ActiveRecord::Base super(self.class.permit_attribute_params(raw_params), *args) end + # Reload "old attributes" for logging, too. + def reload(*args) + super + log_start_state + end + def self.create raw_params={}, *args super(permit_attribute_params(raw_params), *args) end @@ -175,6 +200,14 @@ class ArvadosModel < ActiveRecord::Base ["id", "uuid"] end + def self.limit_index_columns_read + # This method returns a list of column names. + # If an index request reads that column from the database, + # APIs that return lists will only fetch objects until reaching + # max_index_database_read bytes of data from those columns. + [] + end + # If current user can manage the object, return an array of uuids of # users and groups that have permission to write the object. The # first two elements are always [self.owner_uuid, current user's @@ -221,7 +254,8 @@ class ArvadosModel < ActiveRecord::Base # Check if any of the users are admin. If so, we're done. if users_list.select { |u| u.is_admin }.any? - return self + # Return existing relation with no new filters. + return where({}) end # Collect the UUIDs of the authorized users. @@ -406,36 +440,31 @@ class ArvadosModel < ActiveRecord::Base raise PermissionDeniedError end - # Verify "write" permission on old owner - # default fail unless one of: - # owner_uuid did not change - # previous owner_uuid is nil - # current user is the old owner - # current user is this object - # current user can_write old owner - unless !owner_uuid_changed? or - owner_uuid_was.nil? or - current_user.uuid == self.owner_uuid_was or - current_user.uuid == self.uuid or - current_user.can? write: self.owner_uuid_was - logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{uuid} but does not have permission to write old owner_uuid #{owner_uuid_was}" - errors.add :owner_uuid, "cannot be changed without write permission on old owner" - raise PermissionDeniedError - end - - # Verify "write" permission on new owner - # default fail unless one of: - # current_user is this object - # current user can_write new owner, or this object if owner unchanged - if new_record? or owner_uuid_changed? or is_a?(ApiClientAuthorization) - write_target = owner_uuid + if new_record? || owner_uuid_changed? + # Permission on owner_uuid_was is needed to move an existing + # object away from its previous owner (which implies permission + # to modify this object itself, so we don't need to check that + # separately). Permission on the new owner_uuid is also needed. + [['old', owner_uuid_was], + ['new', owner_uuid] + ].each do |which, check_uuid| + if check_uuid.nil? + # old_owner_uuid is nil? New record, no need to check. + elsif !current_user.can?(write: check_uuid) + logger.warn "User #{current_user.uuid} tried to set ownership of #{self.class.to_s} #{self.uuid} but does not have permission to write #{which} owner_uuid #{check_uuid}" + errors.add :owner_uuid, "cannot be set or changed without write permission on #{which} owner" + raise PermissionDeniedError + end + end else - write_target = uuid - end - unless current_user == self or current_user.can? write: write_target - logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{uuid} but does not have permission to write new owner_uuid #{owner_uuid}" - errors.add :owner_uuid, "cannot be changed without write permission on new owner" - raise PermissionDeniedError + # If the object already existed and we're not changing + # owner_uuid, we only need write permission on the object + # itself. + if !current_user.can?(write: self.uuid) + logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{self.uuid} without write permission" + errors.add :uuid, "is not writable" + raise PermissionDeniedError + end end true @@ -541,8 +570,15 @@ class ArvadosModel < ActiveRecord::Base end def self.where_serialized(colname, value) - sorted = deep_sort_hash(value) - where("#{colname.to_s} IN (?)", [sorted.to_yaml, SafeJSON.dump(sorted)]) + if value.empty? + # rails4 stores as null, rails3 stored as serialized [] or {} + sql = "#{colname.to_s} is null or #{colname.to_s} IN (?)" + sorted = value + else + sql = "#{colname.to_s} IN (?)" + sorted = deep_sort_hash(value) + end + where(sql, [sorted.to_yaml, SafeJSON.dump(sorted)]) end Serializer = {