X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8fc29fafb91cf64ce4ededbdd85ef9507c51f216..6bf9e1a4b5640f3cdd057810f0c9b8a945bb88bd:/lib/service/cmd.go diff --git a/lib/service/cmd.go b/lib/service/cmd.go index 94021163e4..a81cf50529 100644 --- a/lib/service/cmd.go +++ b/lib/service/cmd.go @@ -2,7 +2,7 @@ // // SPDX-License-Identifier: Apache-2.0 -// package service provides a cmd.Handler that brings up a system service. +// Package service provides a cmd.Handler that brings up a system service. package service import ( @@ -10,28 +10,29 @@ import ( "flag" "fmt" "io" - "io/ioutil" "net" "net/http" "net/url" "os" "strings" - "git.curoverse.com/arvados.git/lib/cmd" - "git.curoverse.com/arvados.git/lib/config" - "git.curoverse.com/arvados.git/sdk/go/arvados" - "git.curoverse.com/arvados.git/sdk/go/ctxlog" - "git.curoverse.com/arvados.git/sdk/go/httpserver" + "git.arvados.org/arvados.git/lib/cmd" + "git.arvados.org/arvados.git/lib/config" + "git.arvados.org/arvados.git/sdk/go/arvados" + "git.arvados.org/arvados.git/sdk/go/ctxlog" + "git.arvados.org/arvados.git/sdk/go/httpserver" "github.com/coreos/go-systemd/daemon" + "github.com/prometheus/client_golang/prometheus" "github.com/sirupsen/logrus" ) type Handler interface { http.Handler CheckHealth() error + Done() <-chan struct{} } -type NewHandlerFunc func(_ context.Context, _ *arvados.Cluster, token string) Handler +type NewHandlerFunc func(_ context.Context, _ *arvados.Cluster, token string, registry *prometheus.Registry) Handler type command struct { newHandler NewHandlerFunc @@ -59,23 +60,35 @@ func (c *command) RunCommand(prog string, args []string, stdin io.Reader, stdout var err error defer func() { if err != nil { - log.WithError(err).Info("exiting") + log.WithError(err).Error("exiting") } }() + flags := flag.NewFlagSet("", flag.ContinueOnError) flags.SetOutput(stderr) - configFile := flags.String("config", arvados.DefaultConfigFile, "Site configuration `file`") + + loader := config.NewLoader(stdin, log) + loader.SetupFlags(flags) + versionFlag := flags.Bool("version", false, "Write version information to stdout and exit 0") err = flags.Parse(args) if err == flag.ErrHelp { err = nil return 0 } else if err != nil { return 2 + } else if *versionFlag { + return cmd.Version.RunCommand(prog, args, stdin, stdout, stderr) + } + + if strings.HasSuffix(prog, "controller") { + // Some config-loader checks try to make API calls via + // controller. Those can't be expected to work if this + // process _is_ the controller: we haven't started an + // http server yet. + loader.SkipAPICalls = true } - // Logged warnings are discarded for now: the config template - // is incomplete, which causes extra warnings about keys that - // are really OK. - cfg, err := config.LoadFile(*configFile, ctxlog.New(ioutil.Discard, "json", "error")) + + cfg, err := loader.Load() if err != nil { return 1 } @@ -83,58 +96,68 @@ func (c *command) RunCommand(prog string, args []string, stdin io.Reader, stdout if err != nil { return 1 } - log = ctxlog.New(stderr, cluster.SystemLogs.Format, cluster.SystemLogs.LogLevel).WithFields(logrus.Fields{ + + // Now that we've read the config, replace the bootstrap + // logger with a new one according to the logging config. + log = ctxlog.New(stderr, cluster.SystemLogs.Format, cluster.SystemLogs.LogLevel) + logger := log.WithFields(logrus.Fields{ "PID": os.Getpid(), }) - ctx := ctxlog.Context(c.ctx, log) + ctx := ctxlog.Context(c.ctx, logger) - listen, err := getListenAddr(cluster.Services, c.svcName) + listenURL, err := getListenAddr(cluster.Services, c.svcName, log) if err != nil { return 1 } + ctx = context.WithValue(ctx, contextKeyURL{}, listenURL) - if cluster.SystemRootToken == "" { - log.Warn("SystemRootToken missing from cluster config, falling back to ARVADOS_API_TOKEN environment variable") - cluster.SystemRootToken = os.Getenv("ARVADOS_API_TOKEN") - } - if cluster.Services.Controller.ExternalURL.Host == "" { - log.Warn("Services.Controller.ExternalURL missing from cluster config, falling back to ARVADOS_API_HOST(_INSECURE) environment variables") - u, err := url.Parse("https://" + os.Getenv("ARVADOS_API_HOST")) - if err != nil { - err = fmt.Errorf("ARVADOS_API_HOST: %s", err) - return 1 - } - cluster.Services.Controller.ExternalURL = arvados.URL(*u) - if i := os.Getenv("ARVADOS_API_HOST_INSECURE"); i != "" && i != "0" { - cluster.TLS.Insecure = true - } - } - - handler := c.newHandler(ctx, cluster, cluster.SystemRootToken) + reg := prometheus.NewRegistry() + handler := c.newHandler(ctx, cluster, cluster.SystemRootToken, reg) if err = handler.CheckHealth(); err != nil { return 1 } + + instrumented := httpserver.Instrument(reg, log, + httpserver.HandlerWithContext(ctx, + httpserver.AddRequestIDs( + httpserver.LogRequests( + httpserver.NewRequestLimiter(cluster.API.MaxConcurrentRequests, handler, reg))))) srv := &httpserver.Server{ Server: http.Server{ - Handler: httpserver.AddRequestIDs(httpserver.LogRequests(log, handler)), + Handler: instrumented.ServeAPI(cluster.ManagementToken, instrumented), }, - Addr: listen, + Addr: listenURL.Host, + } + if listenURL.Scheme == "https" { + tlsconfig, err := tlsConfigWithCertUpdater(cluster, logger) + if err != nil { + logger.WithError(err).Errorf("cannot start %s service on %s", c.svcName, listenURL.String()) + return 1 + } + srv.TLSConfig = tlsconfig } err = srv.Start() if err != nil { return 1 } - log.WithFields(logrus.Fields{ + logger.WithFields(logrus.Fields{ + "URL": listenURL, "Listen": srv.Addr, "Service": c.svcName, }).Info("listening") if _, err := daemon.SdNotify(false, "READY=1"); err != nil { - log.WithError(err).Errorf("error notifying init daemon") + logger.WithError(err).Errorf("error notifying init daemon") } go func() { + // Shut down server if caller cancels context <-ctx.Done() srv.Close() }() + go func() { + // Shut down server if handler dies + <-handler.Done() + srv.Close() + }() err = srv.Wait() if err != nil { return 1 @@ -144,20 +167,47 @@ func (c *command) RunCommand(prog string, args []string, stdin io.Reader, stdout const rfc3339NanoFixed = "2006-01-02T15:04:05.000000000Z07:00" -func getListenAddr(svcs arvados.Services, prog arvados.ServiceName) (string, error) { +func getListenAddr(svcs arvados.Services, prog arvados.ServiceName, log logrus.FieldLogger) (arvados.URL, error) { svc, ok := svcs.Map()[prog] if !ok { - return "", fmt.Errorf("unknown service name %q", prog) + return arvados.URL{}, fmt.Errorf("unknown service name %q", prog) } - for url := range svc.InternalURLs { - if strings.HasPrefix(url.Host, "localhost:") { - return url.Host, nil + + if want := os.Getenv("ARVADOS_SERVICE_INTERNAL_URL"); want == "" { + } else if url, err := url.Parse(want); err != nil { + return arvados.URL{}, fmt.Errorf("$ARVADOS_SERVICE_INTERNAL_URL (%q): %s", want, err) + } else { + if url.Path == "" { + url.Path = "/" } + return arvados.URL(*url), nil + } + + errors := []string{} + for url := range svc.InternalURLs { listener, err := net.Listen("tcp", url.Host) if err == nil { listener.Close() - return url.Host, nil + return url, nil + } else if strings.Contains(err.Error(), "cannot assign requested address") { + // If 'Host' specifies a different server than + // the current one, it'll resolve the hostname + // to IP address, and then fail because it + // can't bind an IP address it doesn't own. + continue + } else { + errors = append(errors, fmt.Sprintf("tried %v, got %v", url, err)) } } - return "", fmt.Errorf("configuration does not enable the %s service on this host", prog) + if len(errors) > 0 { + return arvados.URL{}, fmt.Errorf("could not enable the %q service on this host: %s", prog, strings.Join(errors, "; ")) + } + return arvados.URL{}, fmt.Errorf("configuration does not enable the %q service on this host", prog) +} + +type contextKeyURL struct{} + +func URLFromContext(ctx context.Context) (arvados.URL, bool) { + u, ok := ctx.Value(contextKeyURL{}).(arvados.URL) + return u, ok }