X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8f76037ba8a37c488612285ffe70d26d0d038124..0446c0a3a433936985d6f46b0eab9b253ed98e80:/lib/controller/handler.go diff --git a/lib/controller/handler.go b/lib/controller/handler.go index f0354d94d9..935a1b6cb6 100644 --- a/lib/controller/handler.go +++ b/lib/controller/handler.go @@ -5,66 +5,181 @@ package controller import ( - "io" + "context" + "database/sql" + "errors" + "fmt" "net/http" "net/url" + "strings" "sync" + "time" - "git.curoverse.com/arvados.git/sdk/go/arvados" - "git.curoverse.com/arvados.git/sdk/go/health" + "git.arvados.org/arvados.git/lib/controller/federation" + "git.arvados.org/arvados.git/lib/controller/railsproxy" + "git.arvados.org/arvados.git/lib/controller/router" + "git.arvados.org/arvados.git/sdk/go/arvados" + "git.arvados.org/arvados.git/sdk/go/health" + "git.arvados.org/arvados.git/sdk/go/httpserver" + _ "github.com/lib/pq" ) type Handler struct { Cluster *arvados.Cluster - setupOnce sync.Once - handlerStack http.Handler - proxyClient *arvados.Client + setupOnce sync.Once + handlerStack http.Handler + proxy *proxy + secureClient *http.Client + insecureClient *http.Client + pgdb *sql.DB + pgdbMtx sync.Mutex } func (h *Handler) ServeHTTP(w http.ResponseWriter, req *http.Request) { h.setupOnce.Do(h.setup) + if req.Method != "GET" && req.Method != "HEAD" { + // http.ServeMux returns 301 with a cleaned path if + // the incoming request has a double slash. Some + // clients (including the Go standard library) change + // the request method to GET when following a 301 + // redirect if the original method was not HEAD + // (RFC7231 6.4.2 specifically allows this in the case + // of POST). Thus "POST //foo" gets misdirected to + // "GET /foo". To avoid this, eliminate double slashes + // before passing the request to ServeMux. + for strings.Contains(req.URL.Path, "//") { + req.URL.Path = strings.Replace(req.URL.Path, "//", "/", -1) + } + } + if h.Cluster.API.RequestTimeout > 0 { + ctx, cancel := context.WithDeadline(req.Context(), time.Now().Add(time.Duration(h.Cluster.API.RequestTimeout))) + req = req.WithContext(ctx) + defer cancel() + } + h.handlerStack.ServeHTTP(w, req) } +func (h *Handler) CheckHealth() error { + h.setupOnce.Do(h.setup) + _, _, err := railsproxy.FindRailsAPI(h.Cluster) + return err +} + +func neverRedirect(*http.Request, []*http.Request) error { return http.ErrUseLastResponse } + func (h *Handler) setup() { mux := http.NewServeMux() mux.Handle("/_health/", &health.Handler{ Token: h.Cluster.ManagementToken, Prefix: "/_health/", + Routes: health.Routes{"ping": func() error { _, err := h.db(&http.Request{}); return err }}, }) - mux.Handle("/", http.HandlerFunc(h.proxyRailsAPI)) + + rtr := router.New(federation.New(h.Cluster)) + mux.Handle("/arvados/v1/config", rtr) + + if !h.Cluster.ForceLegacyAPI14 { + mux.Handle("/arvados/v1/collections", rtr) + mux.Handle("/arvados/v1/collections/", rtr) + mux.Handle("/arvados/v1/users", rtr) + mux.Handle("/arvados/v1/users/", rtr) + mux.Handle("/login", rtr) + } + + hs := http.NotFoundHandler() + hs = prepend(hs, h.proxyRailsAPI) + hs = h.setupProxyRemoteCluster(hs) + mux.Handle("/", hs) h.handlerStack = mux + + sc := *arvados.DefaultSecureClient + sc.CheckRedirect = neverRedirect + h.secureClient = &sc + + ic := *arvados.InsecureHTTPClient + ic.CheckRedirect = neverRedirect + h.insecureClient = &ic + + h.proxy = &proxy{ + Name: "arvados-controller", + } } -func (h *Handler) proxyRailsAPI(w http.ResponseWriter, incomingReq *http.Request) { - url, err := findRailsAPI(h.Cluster) - if err != nil { - http.Error(w, err.Error(), http.StatusInternalServerError) - return +var errDBConnection = errors.New("database connection error") + +func (h *Handler) db(req *http.Request) (*sql.DB, error) { + h.pgdbMtx.Lock() + defer h.pgdbMtx.Unlock() + if h.pgdb != nil { + return h.pgdb, nil } - req := *incomingReq - req.URL.Host = url.Host - resp, err := arvados.InsecureHTTPClient.Do(&req) + + db, err := sql.Open("postgres", h.Cluster.PostgreSQL.Connection.String()) if err != nil { - http.Error(w, err.Error(), http.StatusInternalServerError) - return + httpserver.Logger(req).WithError(err).Error("postgresql connect failed") + return nil, errDBConnection } - for k, v := range resp.Header { - for _, v := range v { - w.Header().Add(k, v) - } + if p := h.Cluster.PostgreSQL.ConnectionPool; p > 0 { + db.SetMaxOpenConns(p) + } + if err := db.Ping(); err != nil { + httpserver.Logger(req).WithError(err).Error("postgresql connect succeeded but ping failed") + return nil, errDBConnection } - w.WriteHeader(resp.StatusCode) - io.Copy(w, resp.Body) + h.pgdb = db + return db, nil } -// For now, findRailsAPI always uses the rails API running on this -// node. -func findRailsAPI(cluster *arvados.Cluster) (*url.URL, error) { - node, err := cluster.GetThisSystemNode() +type middlewareFunc func(http.ResponseWriter, *http.Request, http.Handler) + +func prepend(next http.Handler, middleware middlewareFunc) http.Handler { + return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { + middleware(w, req, next) + }) +} + +func (h *Handler) localClusterRequest(req *http.Request) (*http.Response, error) { + urlOut, insecure, err := railsproxy.FindRailsAPI(h.Cluster) if err != nil { return nil, err } - return url.Parse("http://" + node.RailsAPI.Listen) + urlOut = &url.URL{ + Scheme: urlOut.Scheme, + Host: urlOut.Host, + Path: req.URL.Path, + RawPath: req.URL.RawPath, + RawQuery: req.URL.RawQuery, + } + client := h.secureClient + if insecure { + client = h.insecureClient + } + return h.proxy.Do(req, urlOut, client) +} + +func (h *Handler) proxyRailsAPI(w http.ResponseWriter, req *http.Request, next http.Handler) { + resp, err := h.localClusterRequest(req) + n, err := h.proxy.ForwardResponse(w, resp, err) + if err != nil { + httpserver.Logger(req).WithError(err).WithField("bytesCopied", n).Error("error copying response body") + } +} + +// Use a localhost entry from Services.RailsAPI.InternalURLs if one is +// present, otherwise choose an arbitrary entry. +func findRailsAPI(cluster *arvados.Cluster) (*url.URL, bool, error) { + var best *url.URL + for target := range cluster.Services.RailsAPI.InternalURLs { + target := url.URL(target) + best = &target + if strings.HasPrefix(target.Host, "localhost:") || strings.HasPrefix(target.Host, "127.0.0.1:") || strings.HasPrefix(target.Host, "[::1]:") { + break + } + } + if best == nil { + return nil, false, fmt.Errorf("Services.RailsAPI.InternalURLs is empty") + } + return best, cluster.TLS.Insecure, nil }