X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8d73164d5ca50e7af1b3752b4251eaf9f11a9fc8..0b4945244d55214b331adabce38e33800b55b3e1:/tools/crunchstat-summary/crunchstat_summary/summarizer.py diff --git a/tools/crunchstat-summary/crunchstat_summary/summarizer.py b/tools/crunchstat-summary/crunchstat_summary/summarizer.py index b2f6f1bb70..463c552c4f 100644 --- a/tools/crunchstat-summary/crunchstat_summary/summarizer.py +++ b/tools/crunchstat-summary/crunchstat_summary/summarizer.py @@ -2,8 +2,6 @@ # # SPDX-License-Identifier: AGPL-3.0 -from __future__ import print_function - import arvados import collections import crunchstat_summary.dygraphs @@ -24,7 +22,7 @@ from crunchstat_summary import logger # number of GiB. (Actual nodes tend to be sold in sizes like 8 GiB # that have amounts like 7.5 GiB according to the kernel.) AVAILABLE_RAM_RATIO = 0.95 - +MB=2**20 # Workaround datetime.datetime.strptime() thread-safety bug by calling # it once before starting threads. https://bugs.python.org/issue7980 @@ -107,7 +105,7 @@ class Summarizer(object): self.label, uuid) continue logger.debug('%s: follow %s', self.label, uuid) - child_summarizer = ProcessSummarizer(uuid) + child_summarizer = NewSummarizer(uuid) child_summarizer.stats_max = self.stats_max child_summarizer.task_stats = self.task_stats child_summarizer.tasks = self.tasks @@ -131,13 +129,14 @@ class Summarizer(object): try: self.label = m.group('job_uuid') except IndexError: - self.label = 'container' - if m.group('category').endswith(':'): + self.label = 'label #1' + category = m.group('category') + if category.endswith(':'): # "stderr crunchstat: notice: ..." continue - elif m.group('category') in ('error', 'caught'): + elif category in ('error', 'caught'): continue - elif m.group('category') in ('read', 'open', 'cgroup', 'CID', 'Running'): + elif category in ('read', 'open', 'cgroup', 'CID', 'Running'): # "stderr crunchstat: read /proc/1234/net/dev: ..." # (old logs are less careful with unprefixed error messages) continue @@ -169,9 +168,9 @@ class Summarizer(object): if task.finishtime is None or timestamp > task.finishtime: task.finishtime = timestamp - if self.starttime is None or timestamp < task.starttime: + if self.starttime is None or timestamp < self.starttime: self.starttime = timestamp - if self.finishtime is None or timestamp < task.finishtime: + if self.finishtime is None or timestamp > self.finishtime: self.finishtime = timestamp if (not self.detected_crunch1) and task.starttime is not None and task.finishtime is not None: @@ -209,24 +208,25 @@ class Summarizer(object): stats['user+sys'] = stats.get('user', 0) + stats.get('sys', 0) if 'tx' in stats or 'rx' in stats: stats['tx+rx'] = stats.get('tx', 0) + stats.get('rx', 0) - for stat, val in stats.iteritems(): - if group == 'interval': - if stat == 'seconds': - this_interval_s = val - continue - elif not (this_interval_s > 0): + if group == 'interval': + if 'seconds' in stats: + this_interval_s = stats.get('seconds',0) + del stats['seconds'] + if this_interval_s <= 0: logger.error( "BUG? interval stat given with duration {!r}". format(this_interval_s)) - continue - else: + else: + logger.error('BUG? interval stat missing duration') + for stat, val in stats.items(): + if group == 'interval' and this_interval_s: stat = stat + '__rate' val = val / this_interval_s - if stat in ['user+sys__rate', 'tx+rx__rate']: + if stat in ['user+sys__rate', 'user__rate', 'sys__rate', 'tx+rx__rate', 'rx__rate', 'tx__rate']: task.series[category, stat].append( (timestamp - self.starttime, val)) else: - if stat in ['rss']: + if stat in ['rss','used','total']: task.series[category, stat].append( (timestamp - self.starttime, val)) self.task_stats[task_id][category][stat] = val @@ -236,9 +236,9 @@ class Summarizer(object): self.job_tot = collections.defaultdict( functools.partial(collections.defaultdict, int)) - for task_id, task_stat in self.task_stats.iteritems(): - for category, stat_last in task_stat.iteritems(): - for stat, val in stat_last.iteritems(): + for task_id, task_stat in self.task_stats.items(): + for category, stat_last in task_stat.items(): + for stat, val in stat_last.items(): if stat in ['cpus', 'cache', 'swap', 'rss']: # meaningless stats like 16 cpu cores x 5 tasks = 80 continue @@ -273,8 +273,8 @@ class Summarizer(object): def _text_report_gen(self): yield "\t".join(['category', 'metric', 'task_max', 'task_max_rate', 'job_total']) - for category, stat_max in sorted(self.stats_max.iteritems()): - for stat, val in sorted(stat_max.iteritems()): + for category, stat_max in sorted(self.stats_max.items()): + for stat, val in sorted(stat_max.items()): if stat.endswith('__rate'): continue max_rate = self._format(stat_max.get(stat+'__rate', '-')) @@ -292,7 +292,7 @@ class Summarizer(object): self.stats_max['cpu']['user+sys__rate'], lambda x: x * 100), ('Overall CPU usage: {}%', - self.job_tot['cpu']['user+sys'] / + float(self.job_tot['cpu']['user+sys']) / self.job_tot['time']['elapsed'] if self.job_tot['time']['elapsed'] > 0 else 0, lambda x: x * 100), @@ -316,7 +316,13 @@ class Summarizer(object): (float(self.job_tot['blkio:0:0']['read']) / float(self.job_tot['net:keep0']['rx'])) if self.job_tot['net:keep0']['rx'] > 0 else 0, - lambda x: x * 100.0)): + lambda x: x * 100.0), + ('Temp disk utilization {}%', + (float(self.job_tot['statfs']['used']) / + float(self.job_tot['statfs']['total'])) + if self.job_tot['statfs']['total'] > 0 else 0, + lambda x: x * 100.0), + ): format_string, val, transform = args if val == float('-Inf'): continue @@ -325,31 +331,40 @@ class Summarizer(object): yield "# "+format_string.format(self._format(val)) def _recommend_gen(self): + # TODO recommend fixing job granularity if elapsed time is too short return itertools.chain( self._recommend_cpu(), self._recommend_ram(), - self._recommend_keep_cache()) + self._recommend_keep_cache(), + self._recommend_temp_disk(), + ) def _recommend_cpu(self): """Recommend asking for 4 cores if max CPU usage was 333%""" constraint_key = self._map_runtime_constraint('vcpus') cpu_max_rate = self.stats_max['cpu']['user+sys__rate'] - if cpu_max_rate == float('-Inf'): + if cpu_max_rate == float('-Inf') or cpu_max_rate == 0.0: logger.warning('%s: no CPU usage data', self.label) return + # TODO Don't necessarily want to recommend on isolated max peak + # take average CPU usage into account as well or % time at max used_cores = max(1, int(math.ceil(cpu_max_rate))) asked_cores = self.existing_constraints.get(constraint_key) - if asked_cores is None or used_cores < asked_cores: + if asked_cores is None: + asked_cores = 1 + # TODO: This should be more nuanced in cases where max >> avg + if used_cores < asked_cores: yield ( '#!! {} max CPU usage was {}% -- ' - 'try runtime_constraints "{}":{}' + 'try reducing runtime_constraints to "{}":{}' ).format( self.label, - int(math.ceil(cpu_max_rate*100)), + math.ceil(cpu_max_rate*100), constraint_key, int(used_cores)) + # FIXME: This needs to be updated to account for current a-d-c algorithms def _recommend_ram(self): """Recommend an economical RAM constraint for this job. @@ -389,20 +404,20 @@ class Summarizer(object): if used_bytes == float('-Inf'): logger.warning('%s: no memory usage data', self.label) return - used_mib = math.ceil(float(used_bytes) / 1048576) + used_mib = math.ceil(float(used_bytes) / MB) asked_mib = self.existing_constraints.get(constraint_key) nearlygibs = lambda mebibytes: mebibytes/AVAILABLE_RAM_RATIO/1024 - if asked_mib is None or ( - math.ceil(nearlygibs(used_mib)) < nearlygibs(asked_mib)): + if used_mib > 0 and (asked_mib is None or ( + math.ceil(nearlygibs(used_mib)) < nearlygibs(asked_mib))): yield ( '#!! {} max RSS was {} MiB -- ' - 'try runtime_constraints "{}":{}' + 'try reducing runtime_constraints to "{}":{}' ).format( self.label, int(used_mib), constraint_key, - int(math.ceil(nearlygibs(used_mib))*AVAILABLE_RAM_RATIO*1024*(2**20)/self._runtime_constraint_mem_unit())) + int(math.ceil(nearlygibs(used_mib))*AVAILABLE_RAM_RATIO*1024*(MB)/self._runtime_constraint_mem_unit())) def _recommend_keep_cache(self): """Recommend increasing keep cache if utilization < 80%""" @@ -411,17 +426,33 @@ class Summarizer(object): return utilization = (float(self.job_tot['blkio:0:0']['read']) / float(self.job_tot['net:keep0']['rx'])) - asked_mib = self.existing_constraints.get(constraint_key, 256) + # FIXME: the default on this get won't work correctly + asked_cache = self.existing_constraints.get(constraint_key, 256) * self._runtime_constraint_mem_unit() if utilization < 0.8: yield ( '#!! {} Keep cache utilization was {:.2f}% -- ' - 'try runtime_constraints "{}":{} (or more)' + 'try doubling runtime_constraints to "{}":{} (or more)' ).format( self.label, utilization * 100.0, constraint_key, - asked_mib*2*(2**20)/self._runtime_constraint_mem_unit()) + math.ceil(asked_cache * 2 / self._runtime_constraint_mem_unit())) + + + def _recommend_temp_disk(self): + """Recommend decreasing temp disk if utilization < 50%""" + total = float(self.job_tot['statfs']['total']) + utilization = (float(self.job_tot['statfs']['used']) / total) if total > 0 else 0.0 + + if utilization < 50.8 and total > 0: + yield ( + '#!! {} max temp disk utilization was {:.0f}% of {:.0f} MiB -- ' + 'consider reducing "tmpdirMin" and/or "outdirMin"' + ).format( + self.label, + utilization * 100.0, + total / MB) def _format(self, val): @@ -439,7 +470,7 @@ class Summarizer(object): elif self.detected_crunch1: return JobSummarizer.runtime_constraint_mem_unit else: - return ContainerSummarizer.runtime_constraint_mem_unit + return ContainerRequestSummarizer.runtime_constraint_mem_unit def _map_runtime_constraint(self, key): if hasattr(self, 'map_runtime_constraint'): @@ -470,12 +501,15 @@ def NewSummarizer(process_or_uuid, **kwargs): if '-dz642-' in uuid: if process is None: - process = arv.containers().get(uuid=uuid).execute() - klass = ContainerTreeSummarizer + # Get the associated CR. Doesn't matter which since they all have the same logs + crs = arv.container_requests().list(filters=[['container_uuid','=',uuid]],limit=1).execute()['items'] + if len(crs) > 0: + process = crs[0] + klass = ContainerRequestTreeSummarizer elif '-xvhdp-' in uuid: if process is None: process = arv.container_requests().get(uuid=uuid).execute() - klass = ContainerTreeSummarizer + klass = ContainerRequestTreeSummarizer elif '-8i9sb-' in uuid: if process is None: process = arv.jobs().get(uuid=uuid).execute() @@ -492,28 +526,32 @@ def NewSummarizer(process_or_uuid, **kwargs): class ProcessSummarizer(Summarizer): - """Process is a job, pipeline, container, or container request.""" + """Process is a job, pipeline, or container request.""" def __init__(self, process, label=None, **kwargs): rdr = None self.process = process if label is None: label = self.process.get('name', self.process['uuid']) - if self.process.get('log'): + # Pre-Arvados v1.4 everything is in 'log' + # For 1.4+ containers have no logs and container_requests have them in 'log_uuid', not 'log' + log_collection = self.process.get('log', self.process.get('log_uuid')) + if log_collection and self.process.get('state') != 'Uncommitted': # arvados.util.CR_UNCOMMITTED: try: - rdr = crunchstat_summary.reader.CollectionReader(self.process['log']) + rdr = crunchstat_summary.reader.CollectionReader(log_collection) except arvados.errors.NotFoundError as e: logger.warning("Trying event logs after failing to read " "log collection %s: %s", self.process['log'], e) if rdr is None: - rdr = crunchstat_summary.reader.LiveLogReader(self.process['uuid']) + uuid = self.process.get('container_uuid', self.process.get('uuid')) + rdr = crunchstat_summary.reader.LiveLogReader(uuid) label = label + ' (partial)' super(ProcessSummarizer, self).__init__(rdr, label=label, **kwargs) self.existing_constraints = self.process.get('runtime_constraints', {}) class JobSummarizer(ProcessSummarizer): - runtime_constraint_mem_unit = 1048576 + runtime_constraint_mem_unit = MB map_runtime_constraint = { 'keep_cache_ram': 'keep_cache_mb_per_task', 'ram': 'min_ram_mb_per_node', @@ -521,7 +559,7 @@ class JobSummarizer(ProcessSummarizer): } -class ContainerSummarizer(ProcessSummarizer): +class ContainerRequestSummarizer(ProcessSummarizer): runtime_constraint_mem_unit = 1 @@ -539,7 +577,7 @@ class MultiSummarizer(object): def run(self): threads = [] - for child in self.children.itervalues(): + for child in self.children.values(): self.throttle.acquire() t = threading.Thread(target=self.run_and_release, args=(child.run, )) t.daemon = True @@ -551,7 +589,7 @@ class MultiSummarizer(object): def text_report(self): txt = '' d = self._descendants() - for child in d.itervalues(): + for child in d.values(): if len(d) > 1: txt += '### Summary for {} ({})\n'.format( child.label, child.process['uuid']) @@ -566,7 +604,7 @@ class MultiSummarizer(object): MultiSummarizers) are omitted. """ d = collections.OrderedDict() - for key, child in self.children.iteritems(): + for key, child in self.children.items(): if isinstance(child, Summarizer): d[key] = child if isinstance(child, MultiSummarizer): @@ -574,7 +612,7 @@ class MultiSummarizer(object): return d def html_report(self): - return WEBCHART_CLASS(self.label, self._descendants().itervalues()).html() + return WEBCHART_CLASS(self.label, iter(self._descendants().values())).html() class JobTreeSummarizer(MultiSummarizer): @@ -588,7 +626,7 @@ class JobTreeSummarizer(MultiSummarizer): preloaded = {} for j in arv.jobs().index( limit=len(job['components']), - filters=[['uuid','in',job['components'].values()]]).execute()['items']: + filters=[['uuid','in',list(job['components'].values())]]).execute()['items']: preloaded[j['uuid']] = j for cname in sorted(job['components'].keys()): child_uuid = job['components'][cname] @@ -605,7 +643,7 @@ class JobTreeSummarizer(MultiSummarizer): class PipelineSummarizer(MultiSummarizer): def __init__(self, instance, **kwargs): children = collections.OrderedDict() - for cname, component in instance['components'].iteritems(): + for cname, component in instance['components'].items(): if 'job' not in component: logger.warning( "%s: skipping component with no job assigned", cname) @@ -622,7 +660,7 @@ class PipelineSummarizer(MultiSummarizer): **kwargs) -class ContainerTreeSummarizer(MultiSummarizer): +class ContainerRequestTreeSummarizer(MultiSummarizer): def __init__(self, root, skip_child_jobs=False, **kwargs): arv = arvados.api('v1', model=OrderedJsonModel()) @@ -635,10 +673,8 @@ class ContainerTreeSummarizer(MultiSummarizer): current = todo.popleft() label = current['name'] sort_key = current['created_at'] - if current['uuid'].find('-xvhdp-') > 0: - current = arv.containers().get(uuid=current['container_uuid']).execute() - summer = ContainerSummarizer(current, label=label, **kwargs) + summer = ContainerRequestSummarizer(current, label=label, **kwargs) summer.sort_key = sort_key children[current['uuid']] = summer @@ -647,7 +683,7 @@ class ContainerTreeSummarizer(MultiSummarizer): child_crs = arv.container_requests().index( order=['uuid asc'], filters=page_filters+[ - ['requesting_container_uuid', '=', current['uuid']]], + ['requesting_container_uuid', '=', current['container_uuid']]], ).execute() if not child_crs['items']: break @@ -663,9 +699,9 @@ class ContainerTreeSummarizer(MultiSummarizer): cr['name'] = cr.get('name') or cr['uuid'] todo.append(cr) sorted_children = collections.OrderedDict() - for uuid in sorted(children.keys(), key=lambda uuid: children[uuid].sort_key): + for uuid in sorted(list(children.keys()), key=lambda uuid: children[uuid].sort_key): sorted_children[uuid] = children[uuid] - super(ContainerTreeSummarizer, self).__init__( + super(ContainerRequestTreeSummarizer, self).__init__( children=sorted_children, label=root['name'], **kwargs)