X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8c66c387ddeb1fe5cc19f31fc0e4f24ed778b1f8..bdc87ddb113a2e05dd859a7f68f5fe1135bbc650:/services/api/test/functional/arvados/v1/nodes_controller_test.rb

diff --git a/services/api/test/functional/arvados/v1/nodes_controller_test.rb b/services/api/test/functional/arvados/v1/nodes_controller_test.rb
index 76915eddc3..3e239c36c9 100644
--- a/services/api/test/functional/arvados/v1/nodes_controller_test.rb
+++ b/services/api/test/functional/arvados/v1/nodes_controller_test.rb
@@ -2,19 +2,68 @@ require 'test_helper'
 
 class Arvados::V1::NodesControllerTest < ActionController::TestCase
 
-  test "should get index" do
+  test "should get index with ping_secret" do
     authorize_with :admin
     get :index
     assert_response :success
     assert_not_nil assigns(:objects)
+    node_items = JSON.parse(@response.body)['items']
+    assert_not_equal 0, node_items.size
+    assert_not_nil node_items[0]['info'].andand['ping_secret']
   end
 
-  # inactive user should not see any nodes
-  test "should get empty index" do
+  # inactive user does not see any nodes
+  test "inactive user should get empty index" do
     authorize_with :inactive
     get :index
     assert_response :success
-    assert_equal 0, JSON.parse(@response.body)['items'].size
+    node_items = JSON.parse(@response.body)['items']
+    assert_equal 0, node_items.size
+  end
+
+  # active user sees non-secret attributes of up and recently-up nodes
+  test "active user should get non-empty index with no ping_secret" do
+    authorize_with :active
+    get :index
+    assert_response :success
+    node_items = JSON.parse(@response.body)['items']
+    assert_not_equal 0, node_items.size
+    found_busy_node = false
+    node_items.each do |node|
+      assert_nil node['info'].andand['ping_secret']
+      assert_not_nil node['crunch_worker_state']
+      if node['uuid'] == nodes(:busy).uuid
+        found_busy_node = true
+        assert_equal 'busy', node['crunch_worker_state']
+      end
+    end
+    assert_equal true, found_busy_node
+  end
+
+  test "node should ping with ping_secret and no token" do
+    post :ping, {
+      uuid: 'zzzzz-7ekkf-2z3mc76g2q73aio',
+      instance_id: 'i-0000000',
+      local_ipv4: '172.17.2.174',
+      ping_secret: '69udawxvn3zzj45hs8bumvndricrha4lcpi23pd69e44soanc0'
+    }
+    assert_response :success
+    response = JSON.parse(@response.body)
+    assert_equal 'zzzzz-7ekkf-2z3mc76g2q73aio', response['uuid']
+    # Ensure we are getting the "superuser" attributes, too
+    assert_not_nil response['first_ping_at'], '"first_ping_at" attr missing'
+    assert_not_nil response['info'], '"info" attr missing'
+    assert_not_nil response['nameservers'], '"nameservers" attr missing'
+  end
+
+  test "node should fail ping with invalid ping_secret" do
+    post :ping, {
+      uuid: 'zzzzz-7ekkf-2z3mc76g2q73aio',
+      instance_id: 'i-0000000',
+      local_ipv4: '172.17.2.174',
+      ping_secret: 'dricrha4lcpi23pd69e44soanc069udawxvn3zzj45hs8bumvn'
+    }
+    assert_response 401
   end
 
 end