X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8c5f2973a5c5f042d1d12aef1c470b37519fd416..0e12d049716003b08c4fc881343ebf14c3522b99:/apps/workbench/app/controllers/container_requests_controller.rb diff --git a/apps/workbench/app/controllers/container_requests_controller.rb b/apps/workbench/app/controllers/container_requests_controller.rb index ef7665b34d..f61596ecc7 100644 --- a/apps/workbench/app/controllers/container_requests_controller.rb +++ b/apps/workbench/app/controllers/container_requests_controller.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + class ContainerRequestsController < ApplicationController skip_around_filter :require_thread_api_token, if: proc { |ctrl| Rails.configuration.anonymous_user_token and @@ -7,19 +11,56 @@ class ContainerRequestsController < ApplicationController def generate_provenance(cr) return if params['tab_pane'] != "Provenance" - nodes = {} - nodes[cr[:uuid]] = cr + nodes = {cr[:uuid] => cr} + child_crs = [] + col_uuids = [] + col_pdhs = [] + col_uuids << cr[:output_uuid] if cr[:output_uuid] + col_pdhs += ProvenanceHelper::cr_input_pdhs(cr) + + # Search for child CRs if cr[:container_uuid] - ContainerRequest.where(requesting_container_uuid: cr[:container_uuid]).each do |child| + child_crs = ContainerRequest.where(requesting_container_uuid: cr[:container_uuid]) + + child_crs.each do |child| nodes[child[:uuid]] = child + col_uuids << child[:output_uuid] if child[:output_uuid] + col_pdhs += ProvenanceHelper::cr_input_pdhs(child) end end - @svg = ProvenanceHelper::create_provenance_graph nodes, - "provenance_svg", - { - :request => request, - :direction => :top_down, - } + + output_cols = {} # Indexed by UUID + input_cols = {} # Indexed by PDH + output_pdhs = [] + + # Batch requests to get all related collections + # First fetch output collections by UUID. + Collection.filter([['uuid', 'in', col_uuids.uniq]]).each do |c| + output_cols[c[:uuid]] = c + output_pdhs << c[:portable_data_hash] + end + # Then, get only input collections by PDH. There could be more than one collection + # per PDH: the number of collections is used on the collection node label. + Collection.filter( + [['portable_data_hash', 'in', col_pdhs - output_pdhs]]).each do |c| + if input_cols[c[:portable_data_hash]] + input_cols[c[:portable_data_hash]] << c + else + input_cols[c[:portable_data_hash]] = [c] + end + end + + @svg = ProvenanceHelper::create_provenance_graph( + nodes, "provenance_svg", + { + :request => request, + :direction => :top_down, + :output_collections => output_cols, + :input_collections => input_cols, + :cr_children_of => { + cr[:uuid] => child_crs.select{|child| child[:uuid]}, + }, + }) end def show_pane_list @@ -87,7 +128,26 @@ class ContainerRequestsController < ApplicationController @object = ContainerRequest.new - @object.command = src.command + # By default the copied CR won't be reusing containers, unless use_existing=true + # param is passed. + command = src.command + if params[:use_existing] + @object.use_existing = true + # Pass the correct argument to arvados-cwl-runner command. + if src.command[0] == 'arvados-cwl-runner' + command = src.command - ['--disable-reuse'] + command.insert(1, '--enable-reuse') + end + else + @object.use_existing = false + # Pass the correct argument to arvados-cwl-runner command. + if src.command[0] == 'arvados-cwl-runner' + command = src.command - ['--enable-reuse'] + command.insert(1, '--disable-reuse') + end + end + + @object.command = command @object.container_image = src.container_image @object.cwd = src.cwd @object.description = src.description @@ -100,7 +160,6 @@ class ContainerRequestsController < ApplicationController @object.runtime_constraints = src.runtime_constraints @object.scheduling_parameters = src.scheduling_parameters @object.state = 'Uncommitted' - @object.use_existing = false # set owner_uuid to that of source, provided it is a project and writable by current user current_project = Group.find(src.owner_uuid) rescue nil @@ -110,4 +169,10 @@ class ContainerRequestsController < ApplicationController super end + + def index + @limit = 20 + super + end + end