X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/88bb9b9fc4392f4a3514ae59e3ffd454d3ce90a8..7285b2204d2650179782981dea2af454e607fd7f:/lib/dispatchcloud/worker/runner.go diff --git a/lib/dispatchcloud/worker/runner.go b/lib/dispatchcloud/worker/runner.go index 0fd99aeeef..29c4b8e0a3 100644 --- a/lib/dispatchcloud/worker/runner.go +++ b/lib/dispatchcloud/worker/runner.go @@ -9,9 +9,11 @@ import ( "encoding/json" "fmt" "net" + "strings" "syscall" "time" + "git.arvados.org/arvados.git/lib/crunchrun" "github.com/sirupsen/logrus" ) @@ -20,8 +22,9 @@ import ( type remoteRunner struct { uuid string executor Executor - envJSON json.RawMessage + configJSON json.RawMessage runnerCmd string + runnerArgs []string remoteUser string timeoutTERM time.Duration timeoutSignal time.Duration @@ -45,7 +48,8 @@ func newRemoteRunner(uuid string, wkr *worker) *remoteRunner { if err := enc.Encode(wkr.instType); err != nil { panic(err) } - env := map[string]string{ + var configData crunchrun.ConfigData + configData.Env = map[string]string{ "ARVADOS_API_HOST": wkr.wp.arvClient.APIHost, "ARVADOS_API_TOKEN": wkr.wp.arvClient.AuthToken, "InstanceType": instJSON.String(), @@ -53,17 +57,22 @@ func newRemoteRunner(uuid string, wkr *worker) *remoteRunner { "GatewayAuthSecret": wkr.wp.gatewayAuthSecret(uuid), } if wkr.wp.arvClient.Insecure { - env["ARVADOS_API_HOST_INSECURE"] = "1" + configData.Env["ARVADOS_API_HOST_INSECURE"] = "1" } - envJSON, err := json.Marshal(env) + if bufs := wkr.wp.cluster.Containers.LocalKeepBlobBuffersPerVCPU; bufs > 0 { + configData.Cluster = wkr.wp.cluster + configData.KeepBuffers = bufs * wkr.instType.VCPUs + } + configJSON, err := json.Marshal(configData) if err != nil { panic(err) } rr := &remoteRunner{ uuid: uuid, executor: wkr.executor, - envJSON: envJSON, + configJSON: configJSON, runnerCmd: wkr.wp.runnerCmd, + runnerArgs: wkr.wp.runnerArgs, remoteUser: wkr.instance.RemoteUser(), timeoutTERM: wkr.wp.timeoutTERM, timeoutSignal: wkr.wp.timeoutSignal, @@ -81,11 +90,15 @@ func newRemoteRunner(uuid string, wkr *worker) *remoteRunner { // assume the remote process _might_ have started, at least until it // probes the worker and finds otherwise. func (rr *remoteRunner) Start() { - cmd := rr.runnerCmd + " --detach --stdin-env '" + rr.uuid + "'" + cmd := rr.runnerCmd + " --detach --stdin-config" + for _, arg := range rr.runnerArgs { + cmd += " '" + strings.Replace(arg, "'", "'\\''", -1) + "'" + } + cmd += " '" + rr.uuid + "'" if rr.remoteUser != "root" { cmd = "sudo " + cmd } - stdin := bytes.NewBuffer(rr.envJSON) + stdin := bytes.NewBuffer(rr.configJSON) stdout, stderr, err := rr.executor.Execute(nil, cmd, stdin) if err != nil { rr.logger.WithField("stdout", string(stdout)).