X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/889d94070d54e47ddb44afcfe457cbaed2e6a2e3..8c52fddd7b87b36bbd5cb0d362009df33ef5f0fc:/apps/workbench/app/controllers/projects_controller.rb diff --git a/apps/workbench/app/controllers/projects_controller.rb b/apps/workbench/app/controllers/projects_controller.rb index 31cb5eff3e..2cbdcc90c8 100644 --- a/apps/workbench/app/controllers/projects_controller.rb +++ b/apps/workbench/app/controllers/projects_controller.rb @@ -1,17 +1,98 @@ class ProjectsController < ApplicationController + before_filter :set_share_links, if: -> { defined? @object } + def model_class Group end + def find_object_by_uuid + if current_user and params[:uuid] == current_user.uuid + @object = current_user.dup + @object.uuid = current_user.uuid + class << @object + def name + 'Home' + end + def description + '' + end + def attribute_editable? attr, *args + case attr + when 'description', 'name' + false + else + super + end + end + end + else + super + end + end + + def set_share_links + @user_is_manager = false + @share_links = [] + if @object.uuid != current_user.uuid + begin + @share_links = Link.permissions_for(@object) + @user_is_manager = true + rescue ArvadosApiClient::AccessForbiddenException, + ArvadosApiClient::NotFoundException + end + end + end + def index_pane_list %w(Projects) end + # Returning an array of hashes instead of an array of strings will allow + # us to tell the interface to get counts for each pane (using :filters). + # It also seems to me that something like these could be used to configure the contents of the panes. def show_pane_list - if @user_is_manager - %w(Contents Sharing Advanced) - else - %w(Contents Advanced) + pane_list = [ + { + :name => 'Data_collections', + :filters => [%w(uuid is_a arvados#collection)] + }, + { + :name => 'Jobs_and_pipelines', + :filters => [%w(uuid is_a) + [%w(arvados#job arvados#pipelineInstance)]] + }, + { + :name => 'Pipeline_templates', + :filters => [%w(uuid is_a arvados#pipelineTemplate)] + }, + { + :name => 'Subprojects', + :filters => [%w(uuid is_a arvados#group)] + }, + { :name => 'Other_objects', + :filters => [%w(uuid is_a) + [%w(arvados#human arvados#specimen arvados#trait)]] + } + ] + pane_list << { :name => 'Sharing', + :count => @share_links.count } if @user_is_manager + pane_list << { :name => 'Advanced' } + end + + # Called via AJAX and returns Javascript that populates tab counts into tab titles. + # References #show_pane_list action which should return an array of hashes each with :name + # and then optionally a :filters to run or a straight up :count + # + # This action could easily be moved to the ApplicationController to genericize the tab_counts behaviour, + # but one or more new routes would have to be created, the js.erb would also have to be moved + def tab_counts + @tab_counts = {} + show_pane_list.each do |pane| + if pane.is_a?(Hash) + if pane[:count] + @tab_counts[pane[:name]] = pane[:count] + elsif pane[:filters] + @tab_counts[pane[:name]] = @object.contents(filters: pane[:filters]).items_available + end + end end end @@ -46,8 +127,21 @@ class ProjectsController < ApplicationController if item.owner_uuid == @object.uuid # Object is owned by this project. Remove it from the project by # changing owner to the current user. - item.update_attributes owner_uuid: current_user.uuid - @removed_uuids << item.uuid + begin + item.update_attributes owner_uuid: current_user.uuid + @removed_uuids << item.uuid + rescue ArvadosApiClient::ApiErrorResponseException => e + if e.message.include? 'collection_owner_uuid_name_unique' + rename_to = item.name + ' removed from ' + + (@object.name ? @object.name : @object.uuid) + + ' at ' + Time.now.to_s + updates = {} + updates[:name] = rename_to + updates[:owner_uuid] = current_user.uuid + item.update_attributes updates + @removed_uuids << item.uuid + end + end end end end @@ -77,62 +171,77 @@ class ProjectsController < ApplicationController super end - def show - if !@object - return render_not_found("object not found") + def load_contents_objects kinds=[] + kind_filters = @filters.select do |attr,op,val| + op == 'is_a' and val.is_a? Array and val.count > 1 end - @objects = @object.contents(limit: 50, - include_linked: true, - offset: params[:offset] || 0) - @logs = Log.limit(10).filter([['object_uuid', '=', @object.uuid]]) - @users = User.limit(10000). - select(["uuid", "is_active", "first_name", "last_name"]). - filter([['is_active', '=', 'true']]) - @groups = Group.limit(10000). - select(["uuid", "name", "description"]) - - begin - @share_links = Link.permissions_for(@object) - @user_is_manager = true - rescue ArvadosApiClient::AccessForbiddenException, - ArvadosApiClient::NotFoundException - @share_links = [] - @user_is_manager = false - end - - @objects_and_names = [] - @objects.each do |object| - if !(name_links = @objects.links_for(object, 'name')).empty? - name_links.each do |name_link| - @objects_and_names << [object, name_link] + if /^created_at\b/ =~ @order[0] and kind_filters.count == 1 + # If filtering on multiple types and sorting by date: Get the + # first page of each type, sort the entire set, truncate to one + # page, and use the last item on this page as a filter for + # retrieving the next page. Ideally the API would do this for + # us, but it doesn't (yet). + nextpage_operator = /\bdesc$/i =~ @order[0] ? '<' : '>' + @objects = [] + @name_link_for = {} + kind_filters.each do |attr,op,val| + (val.is_a?(Array) ? val : [val]).each do |type| + objects = @object.contents(order: @order, + limit: @limit, + include_linked: true, + filters: (@filters - kind_filters + [['uuid', 'is_a', type]]), + offset: @offset) + objects.each do |object| + @name_link_for[object.andand.uuid] = objects.links_for(object, 'name').first + end + @objects += objects end - elsif object.respond_to? :name - @objects_and_names << [object, object] + end + @objects = @objects.to_a.sort_by(&:created_at) + @objects.reverse! if nextpage_operator == '<' + @objects = @objects[0..@limit-1] + @next_page_filters = @filters.reject do |attr,op,val| + attr == 'created_at' and op == nextpage_operator + end + if @objects.any? + @next_page_filters += [['created_at', + nextpage_operator, + @objects.last.created_at]] + @next_page_href = url_for(partial: :contents_rows, + filters: @next_page_filters.to_json) else - @objects_and_names << [object, - Link.new(owner_uuid: @object.uuid, - tail_uuid: @object.uuid, - head_uuid: object.uuid, - link_class: "name", - name: "")] + @next_page_href = nil end + else + @objects = @object.contents(order: @order, + limit: @limit, + include_linked: true, + filters: @filters, + offset: @offset) + @next_page_href = next_page_href(partial: :contents_rows) end + + preload_links_for_objects(@objects.to_a) + end + + def show + if !@object + return render_not_found("object not found") + end + if params[:partial] + load_contents_objects respond_to do |f| f.json { render json: { content: render_to_string(partial: 'show_contents_rows.html', - formats: [:html], - locals: { - objects_and_names: @objects_and_names, - project: @object - }), - next_page_href: (next_page_offset and - url_for(offset: next_page_offset, partial: true)) + formats: [:html]), + next_page_href: @next_page_href } } end else + @objects = [] super end end @@ -148,23 +257,61 @@ class ProjectsController < ApplicationController super end + helper_method :get_objects_and_names + def get_objects_and_names(objects=nil) + objects = @objects if objects.nil? + objects_and_names = [] + objects.each do |object| + if objects.respond_to? :links_for and + !(name_links = objects.links_for(object, 'name')).empty? + name_links.each do |name_link| + objects_and_names << [object, name_link] + end + elsif @name_link_for.andand[object.uuid] + objects_and_names << [object, @name_link_for[object.uuid]] + elsif object.respond_to? :name + objects_and_names << [object, object] + else + objects_and_names << [object, + Link.new(owner_uuid: @object.uuid, + tail_uuid: @object.uuid, + head_uuid: object.uuid, + link_class: "name", + name: "")] + + end + end + objects_and_names + end + def share_with if not params[:uuids].andand.any? @errors = ["No user/group UUIDs specified to share with."] return render_error(status: 422) end - results = {"success" => [], "failure" => {}} + results = {"success" => [], "errors" => []} params[:uuids].each do |shared_uuid| begin Link.create(tail_uuid: shared_uuid, link_class: "permission", name: "can_read", head_uuid: @object.uuid) rescue ArvadosApiClient::ApiError => error - results["failure"][shared_uuid] = error.api_response.andand[:errors] + error_list = error.api_response.andand[:errors] + if error_list.andand.any? + results["errors"] += error_list.map { |e| "#{shared_uuid}: #{e}" } + else + error_code = error.api_status || "Bad status" + results["errors"] << "#{shared_uuid}: #{error_code} response" + end else results["success"] << shared_uuid end end - status = (results["failure"].empty?) ? 200 : 422 + if results["errors"].empty? + results.delete("errors") + status = 200 + else + status = 422 + end respond_to do |f| f.json { render(json: results, status: status) } end