X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/87a3cc47267fad4cc769d9d866754c072a83c35e..2adcde44af5b170b9c602ffbc3d035bd92b4f05f:/tools/crunchstat-summary/tests/test_examples.py diff --git a/tools/crunchstat-summary/tests/test_examples.py b/tools/crunchstat-summary/tests/test_examples.py index a19d7ad0a4..6c1443733c 100644 --- a/tools/crunchstat-summary/tests/test_examples.py +++ b/tools/crunchstat-summary/tests/test_examples.py @@ -1,7 +1,6 @@ import arvados import collections import crunchstat_summary.command -import crunchstat_summary.summarizer import difflib import glob import gzip @@ -9,17 +8,17 @@ import mock import os import unittest - TESTS_DIR = os.path.dirname(os.path.abspath(__file__)) + class ReportDiff(unittest.TestCase): - def diff_known_report(self, logfile, summarizer): + def diff_known_report(self, logfile, cmd): expectfile = logfile+'.report' expect = open(expectfile).readlines() - self.diff_report(summarizer, expect, expectfile=expectfile) + self.diff_report(cmd, expect, expectfile=expectfile) - def diff_report(self, summarizer, expect, expectfile=None): - got = [x+"\n" for x in summarizer.report().strip("\n").split("\n")] + def diff_report(self, cmd, expect, expectfile=None): + got = [x+"\n" for x in cmd.report().strip("\n").split("\n")] self.assertEqual(got, expect, "\n"+"".join(difflib.context_diff( expect, got, fromfile=expectfile, tofile="(generated)"))) @@ -30,13 +29,34 @@ class SummarizeFile(ReportDiff): logfile = os.path.join(TESTS_DIR, fnm) args = crunchstat_summary.command.ArgumentParser().parse_args( ['--log-file', logfile]) - summarizer = crunchstat_summary.command.Command(args).summarizer() - summarizer.run() - self.diff_known_report(logfile, summarizer) + cmd = crunchstat_summary.command.Command(args) + cmd.run() + self.diff_known_report(logfile, cmd) + + +class HTMLFromFile(ReportDiff): + def test_example_files(self): + # Note we don't test the output content at all yet; we're + # mainly just verifying the --format=html option isn't ignored + # and the HTML code path doesn't crash. + for fnm in glob.glob(os.path.join(TESTS_DIR, '*.txt.gz')): + logfile = os.path.join(TESTS_DIR, fnm) + args = crunchstat_summary.command.ArgumentParser().parse_args( + ['--format=html', '--log-file', logfile]) + cmd = crunchstat_summary.command.Command(args) + cmd.run() + self.assertRegexpMatches(cmd.report(), r'(?is).*\s*$') + + +class SummarizeEdgeCases(unittest.TestCase): + def test_error_messages(self): + logfile = open(os.path.join(TESTS_DIR, 'crunchstat_error_messages.txt')) + s = crunchstat_summary.summarizer.Summarizer(logfile) + s.run() class SummarizeJob(ReportDiff): - fake_job_uuid = 'zzzzz-8i9sb-jjjjjjjjjjjjjjj' + fake_job_uuid = '4xphq-8i9sb-jq0ekny1xou3zoh' fake_log_id = 'fake-log-collection-id' fake_job = { 'uuid': fake_job_uuid, @@ -52,9 +72,9 @@ class SummarizeJob(ReportDiff): mock_cr().open.return_value = gzip.open(self.logfile) args = crunchstat_summary.command.ArgumentParser().parse_args( ['--job', self.fake_job_uuid]) - summarizer = crunchstat_summary.command.Command(args).summarizer() - summarizer.run() - self.diff_known_report(self.logfile, summarizer) + cmd = crunchstat_summary.command.Command(args) + cmd.run() + self.diff_known_report(self.logfile, cmd) mock_api().jobs().get.assert_called_with(uuid=self.fake_job_uuid) mock_cr.assert_called_with(self.fake_log_id) mock_cr().open.assert_called_with('fake-logfile.txt') @@ -70,7 +90,7 @@ class SummarizePipeline(ReportDiff): 'uuid': 'zzzzz-8i9sb-000000000000000', 'log': 'fake-log-pdh-0', 'runtime_constraints': { - 'min_ram_mb_per_node': 1024, + 'min_ram_mb_per_node': 900, 'min_cores_per_node': 1, }, }, @@ -80,7 +100,7 @@ class SummarizePipeline(ReportDiff): 'uuid': 'zzzzz-8i9sb-000000000000001', 'log': 'fake-log-pdh-1', 'runtime_constraints': { - 'min_ram_mb_per_node': 1024, + 'min_ram_mb_per_node': 900, 'min_cores_per_node': 1, }, }, @@ -96,7 +116,7 @@ class SummarizePipeline(ReportDiff): 'uuid': 'zzzzz-8i9sb-000000000000002', 'log': 'fake-log-pdh-2', 'runtime_constraints': { - 'min_ram_mb_per_node': 1024, + 'min_ram_mb_per_node': 900, 'min_cores_per_node': 1, }, }, @@ -113,8 +133,8 @@ class SummarizePipeline(ReportDiff): mock_cr().open.side_effect = [gzip.open(logfile) for _ in range(3)] args = crunchstat_summary.command.ArgumentParser().parse_args( ['--pipeline-instance', self.fake_instance['uuid']]) - summarizer = crunchstat_summary.command.Command(args).summarizer() - summarizer.run() + cmd = crunchstat_summary.command.Command(args) + cmd.run() job_report = [ line for line in open(logfile+'.report').readlines() @@ -126,7 +146,7 @@ class SummarizePipeline(ReportDiff): job_report + ['\n'] + ['### Summary for baz (zzzzz-8i9sb-000000000000002)\n'] + job_report) - self.diff_report(summarizer, expect) + self.diff_report(cmd, expect) mock_cr.assert_has_calls( [ mock.call('fake-log-pdh-0'),