X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/85add8b41d3469772af29b9a015f6c1f23cb8686..140012f16cc5945a8c469db3e11f13cc4493cc22:/apps/workbench/test/integration/pipeline_instances_test.rb?ds=sidebyside

diff --git a/apps/workbench/test/integration/pipeline_instances_test.rb b/apps/workbench/test/integration/pipeline_instances_test.rb
index eb9b987560..4e53db7783 100644
--- a/apps/workbench/test/integration/pipeline_instances_test.rb
+++ b/apps/workbench/test/integration/pipeline_instances_test.rb
@@ -117,12 +117,55 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
     create_and_run_pipeline_in_aproject true
   end
 
-  # Create a pipeline instance from within a project and run
+  # Create a pipeline instance from without a project
   test 'Run a pipeline from dashboard' do
     visit page_with_token('active_trustedclient')
     create_and_run_pipeline_in_aproject false
   end
 
+  # Test that the portable_data_hash is recorded when choosing an
+  # input collection for a pipeline
+  test 'pipeline input collections are recorded with portable_data_hash' do
+    visit page_with_token('active_trustedclient')
+
+    template = api_fixture('pipeline_templates')['simple_pipeline']
+
+    visit '/pipeline_templates'
+    within('tr', text: 'Pipeline Template With Collection Input') do
+      find('a,button', text: 'Run').click
+    end
+
+    # project chooser
+    project = api_fixture('groups')['aproject']
+    within('.modal-dialog') do
+      find('.selectable', text: 'A Project').click
+      find('button', text: 'Choose').click
+    end
+
+    # find the collection input field
+    input = page.all('a', text: 'Choose').select { |a|
+      a[:href] =~ /Choose.a.dataset.for.foo.template.input/
+    }
+    assert_not_empty input
+    input.first.click
+
+    # Select a collection
+    col = api_fixture('collections')['foo_collection_in_aproject']
+    within('.modal-dialog') do
+      find('div', text: col['name']).click
+      find('button', text: 'OK').click
+    end
+
+    # The collection's portable_data_hash, name, and uuid should have
+    # been recorded, respectively, as the value, selection_name and selection_uuid
+    # for this component's input script_parameter.
+    api_response = JSON.parse(find('div#advanced_api_response pre').text)
+    input_params = api_response['components']['part-one']['script_parameters']['input']
+    assert_equal input_params['value'], col['portable_data_hash']
+    assert_equal input_params['selection_name'], col['name']
+    assert_equal input_params['selection_uuid'], col['uuid']
+  end
+
   test 'view pipeline with job and see graph' do
     visit page_with_token('active_trustedclient')
 
@@ -202,15 +245,18 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
   end
 
   [
-    [false, false, false],
-    [false, false, true],
-    [true, false, false],
-    [true, true, false],
-    [true, false, true],
-    [true, true, true],
-  ].each do |with_options, choose_options, in_aproject|
-    test "Rerun pipeline instance using options #{with_options} #{choose_options} in #{in_aproject}" do
-      visit page_with_token('active_trustedclient')
+    ['active', false, false, false],
+    ['active', false, false, true],
+    ['active', true, false, false],
+    ['active', true, true, false],
+    ['active', true, false, true],
+    ['active', true, true, true],
+    ['project_viewer', false, false, true],
+    ['project_viewer', true, false, true],
+    ['project_viewer', true, true, true],
+  ].each do |user, with_options, choose_options, in_aproject|
+    test "Rerun pipeline instance as #{user} using options #{with_options} #{choose_options} in #{in_aproject}" do
+      visit page_with_token('active')
 
       if in_aproject
         find("#projects-menu").click
@@ -220,13 +266,23 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
       create_and_run_pipeline_in_aproject in_aproject
       instance_path = current_path
 
-      # pause the pipeline
+      # Pause the pipeline
       find('a,button', text: 'Pause').click
       assert page.has_text? 'Paused'
       page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
       page.assert_selector 'a,button', text: 'Re-run with latest'
       page.assert_selector 'a,button', text: 'Re-run options'
 
+      # Pipeline can be re-run now. Access it as the specified user, and re-run
+      if user == 'project_viewer'
+        visit page_with_token(user, instance_path)
+        assert page.has_text? 'A Project'
+        page.assert_no_selector 'a.disabled,button.disabled', text: 'Resume'
+        page.assert_selector 'a,button', text: 'Re-run with latest'
+        page.assert_selector 'a,button', text: 'Re-run options'
+      end
+
+      # Now re-run the pipeline
       if with_options
         find('a,button', text: 'Re-run options').click
         within('.modal-dialog') do
@@ -242,12 +298,16 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
         find('a,button', text: 'Re-run with latest').click
       end
 
-      # verify that the newly created instance is in the expected project
+      # Verify that the newly created instance is created in the right project.
+      # In case of project_viewer user, since the use cannot write to the project,
+      # the pipeline should have been created in the user's Home project.
       rerun_instance_path = current_path
       assert_not_equal instance_path, rerun_instance_path, 'Rerun instance path expected to be different'
       assert page.has_text? 'Home'
-      if in_aproject
+      if in_aproject && (user != 'project_viewer')
         assert page.has_text? 'A Project'
+      else
+        assert page.has_no_text? 'A Project'
       end
     end
   end
@@ -296,4 +356,26 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest
     assert_not page.has_text? 'Graph'
   end
 
+  [
+    [0, 0], # run time 0 minutes
+    [9, 17*60*60 + 51*60], # run time 17 hours and 51 minutes
+  ].each do |index, run_time|
+    test "pipeline start and finish time display #{index}" do
+      visit page_with_token("user1_with_load", "/pipeline_instances/zzzzz-d1hrv-10pipelines0#{index.to_s.rjust(3, '0')}")
+
+      assert page.has_text? 'This pipeline started at'
+      page_text = page.text
+      match = /This pipeline started at (.*)\. It failed after (.*) seconds at (.*)\. Check the Log/.match page_text
+
+      start_at = match[1]
+      finished_at = match[3]
+
+      # start and finished time display is of the format '2:20 PM 10/20/2014'
+      start_time = DateTime.strptime(start_at, '%I:%M %p %m/%d/%Y').to_time
+      finished_time = DateTime.strptime(finished_at, '%I:%M %p %m/%d/%Y').to_time
+
+      assert_equal(run_time, finished_time-start_time,
+        "Time difference did not match for start_at #{start_at}, finished_at #{finished_at}, ran_for  #{match[2]}")
+    end
+  end
 end