X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/83561af02e156758b09ea771510ad4f9ee506b06..b6e28fbe905737bd0ea5bda5f4fd74fd259c58b1:/services/api/app/controllers/application_controller.rb diff --git a/services/api/app/controllers/application_controller.rb b/services/api/app/controllers/application_controller.rb index 58d14fd559..d3b5c6b147 100644 --- a/services/api/app/controllers/application_controller.rb +++ b/services/api/app/controllers/application_controller.rb @@ -35,7 +35,7 @@ class ApplicationController < ActionController::Base except: [:index, :create] + ERROR_ACTIONS) before_filter :load_limit_offset_order_params, only: [:index, :contents] before_filter :load_where_param, only: [:index, :contents] - before_filter :load_filters_param, only: [:index, :contents, :choose] + before_filter :load_filters_param, only: [:index, :contents] before_filter :find_objects_for_index, :only => :index before_filter :reload_object_before_update, :only => :update before_filter(:render_404_if_no_object, @@ -106,6 +106,7 @@ class ApplicationController < ActionController::Base end if @object and @object.errors and @object.errors.full_messages and not @object.errors.full_messages.empty? errors = @object.errors.full_messages + logger.error errors.inspect else errors = [e.inspect] end @@ -202,7 +203,17 @@ class ApplicationController < ActionController::Base end end - @objects = @objects.select(@select.map { |s| "#{table_name}.#{ActiveRecord::Base.connection.quote_column_name s.to_s}" }.join ", ") if @select + if @select + # Map attribute names in @select to real column names, resolve + # those to fully-qualified SQL column names, and pass the + # resulting string to the select method. + api_column_map = model_class.attributes_required_columns + columns_list = @select. + flat_map { |attr| api_column_map[attr] }. + uniq. + map { |s| "#{table_name}.#{ActiveRecord::Base.connection.quote_column_name s}" } + @objects = @objects.select(columns_list.join(", ")) + end @objects = @objects.order(@orders.join ", ") if @orders.any? @objects = @objects.limit(@limit) @objects = @objects.offset(@offset)