X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/8295ba721133c341fd72350f7ca9438d1a99cdbe..ef2d368867bfae2ca702184c57a8cd873f1c4e43:/sdk/cli/bin/arv

diff --git a/sdk/cli/bin/arv b/sdk/cli/bin/arv
index 96acd01f8b..a142dba10f 100755
--- a/sdk/cli/bin/arv
+++ b/sdk/cli/bin/arv
@@ -24,6 +24,7 @@ begin
   require 'active_support/inflector'
   require 'yaml'
   require 'tempfile'
+  require 'net/http'
 rescue LoadError
   abort <<-EOS
 
@@ -154,7 +155,7 @@ def check_subcommands client, arvados, subcommand, global_opts, remaining_opts
 end
 
 def command_exists?(command)
-  File.executable?(command) || ENV['PATH'].split(':').select {|folder| File.executable?(File.join(folder, command))}.any?
+  File.executable?(command) || ENV['PATH'].split(':').any? {|folder| File.executable?(File.join(folder, command))}
 end
 
 def run_editor path
@@ -217,19 +218,31 @@ def edit_and_commit_object initial_obj, tmp_stem, global_opts, &block
 
         break
       rescue => e
-        puts "Error: #{e}"
+        can_retry = true
+        if e.is_a? Psych::SyntaxError
+          this_error = "YAML error parsing your input: #{e}"
+        elsif e.is_a? JSON::ParserError or e.is_a? Oj::ParseError
+          this_error = "JSON error parsing your input: #{e}"
+        elsif e.is_a? ArvadosAPIError
+          this_error = "API responded with error #{e}"
+        else
+          this_error = "#{e.class}: #{e}"
+          can_retry = false
+        end
+        puts this_error
+
         tmp_file.open
         newcontent = tmp_file.read()
         tmp_file.close
 
-        if newcontent == error_text
+        if newcontent == error_text or not can_retry
           FileUtils::cp tmp_file.path, tmp_file.path + ".saved"
-          puts "File is unchanged, edit aborted."
+          puts "File is unchanged, edit aborted." if can_retry
           abort "Saved contents to " + tmp_file.path + ".saved"
         else
           tmp_file.open
           tmp_file.truncate 0
-          error_text = e.to_s.lines.map {|l| '# ' + l}.join + "\n"
+          error_text = this_error.to_s.lines.map {|l| '# ' + l}.join + "\n"
           error_text += "# Please fix the error and try again.\n"
           error_text += newcontent.lines.select {|l| !l.start_with? '#'}.join
           tmp_file.write error_text
@@ -244,15 +257,20 @@ def edit_and_commit_object initial_obj, tmp_stem, global_opts, &block
   nil
 end
 
+class ArvadosAPIError < RuntimeError
+end
+
 def check_response result
   begin
     results = JSON.parse result.body
-  rescue JSON::ParserError => e
+  rescue JSON::ParserError, Oj::ParseError => e
     raise "Failed to parse server response:\n" + e.to_s
   end
 
   if result.response.status != 200
-    raise "#{result.response.status}: " + (results['errors'] && results['errors'].join('\n') || "")
+    raise ArvadosAPIError.new("#{result.response.status}: #{
+                              ((results['errors'] && results['errors'].join('\n')) ||
+                                Net::HTTPResponse::CODE_TO_OBJ[status.to_s].to_s.sub(/^Net::HTTP/, '').titleize)}")
   end
 
   results
@@ -282,7 +300,7 @@ def arv_edit client, arvados, global_opts, remaining_opts
     if /^[a-f0-9]{32}/.match uuid
       abort "Arvados collections are not editable."
     else
-      abort "#{uuid} does not appear to be an Arvados uuid"
+      abort "'#{uuid}' does not appear to be an Arvados uuid"
     end
   end
 
@@ -325,7 +343,8 @@ def arv_edit client, arvados, global_opts, remaining_opts
                      :headers => {
                        authorization: 'OAuth2 '+ENV['ARVADOS_API_TOKEN']
                      })
-      check_response result
+      results = check_response result
+      puts "Updated object #{results['uuid']}"
     else
       puts "Object is unchanged, did not update."
     end