X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/7b5729d984a9c516920270250f050bf72f1896d1..1293a55ede38d16119b04a6584ca9da143ea3725:/services/keepstore/logging_router.go

diff --git a/services/keepstore/logging_router.go b/services/keepstore/logging_router.go
index e30df87632..9edfb6e69d 100644
--- a/services/keepstore/logging_router.go
+++ b/services/keepstore/logging_router.go
@@ -8,21 +8,33 @@ import (
 	"log"
 	"net/http"
 	"strings"
+	"time"
 )
 
+// LoggingResponseWriter has anonymous fields ResponseWriter and ResponseBody
 type LoggingResponseWriter struct {
 	Status int
 	Length int
 	http.ResponseWriter
 	ResponseBody string
+	sentHdr      time.Time
 }
 
+// WriteHeader writes header to ResponseWriter
 func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) {
+	if loggingWriter.sentHdr == zeroTime {
+		loggingWriter.sentHdr = time.Now()
+	}
 	loggingWriter.Status = code
 	loggingWriter.ResponseWriter.WriteHeader(code)
 }
 
+var zeroTime time.Time
+
 func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) {
+	if loggingWriter.Length == 0 && len(data) > 0 && loggingWriter.sentHdr == zeroTime {
+		loggingWriter.sentHdr = time.Now()
+	}
 	loggingWriter.Length += len(data)
 	if loggingWriter.Status >= 400 {
 		loggingWriter.ResponseBody += string(data)
@@ -30,22 +42,29 @@ func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) {
 	return loggingWriter.ResponseWriter.Write(data)
 }
 
+// LoggingRESTRouter is used to add logging capabilities to mux.Router
 type LoggingRESTRouter struct {
 	router *mux.Router
 }
 
+// MakeLoggingRESTRouter initializes LoggingRESTRouter
 func MakeLoggingRESTRouter() *LoggingRESTRouter {
 	router := MakeRESTRouter()
 	return (&LoggingRESTRouter{router})
 }
 
 func (loggingRouter *LoggingRESTRouter) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
-	loggingWriter := LoggingResponseWriter{200, 0, resp, ""}
+	t0 := time.Now()
+	loggingWriter := LoggingResponseWriter{http.StatusOK, 0, resp, "", zeroTime}
 	loggingRouter.router.ServeHTTP(&loggingWriter, req)
-	statusText := "OK"
+	statusText := http.StatusText(loggingWriter.Status)
 	if loggingWriter.Status >= 400 {
 		statusText = strings.Replace(loggingWriter.ResponseBody, "\n", "", -1)
 	}
-	log.Printf("[%s] %s %s %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length, statusText)
+	now := time.Now()
+	tTotal := now.Sub(t0)
+	tLatency := loggingWriter.sentHdr.Sub(t0)
+	tResponse := now.Sub(loggingWriter.sentHdr)
+	log.Printf("[%s] %s %s %d %.6fs %.6fs %.6fs %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], req.ContentLength, tTotal.Seconds(), tLatency.Seconds(), tResponse.Seconds(), loggingWriter.Status, loggingWriter.Length, statusText)
 
 }