X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/77d9c05d89dabc9e9e9a15f46cd12c8ad61ed64e..cdff1d7e5eadb611578090585e1e54aae41e7e66:/services/api/app/models/arvados_model.rb diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb index 84897d04ef..518d4c8ff3 100644 --- a/services/api/app/models/arvados_model.rb +++ b/services/api/app/models/arvados_model.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'has_uuid' require 'record_filters' require 'serializers' @@ -46,6 +50,12 @@ class ArvadosModel < ActiveRecord::Base end end + class LockFailedError < StandardError + def http_status + 422 + end + end + class InvalidStateTransitionError < StandardError def http_status 422 @@ -98,6 +108,12 @@ class ArvadosModel < ActiveRecord::Base super(self.class.permit_attribute_params(raw_params), *args) end + # Reload "old attributes" for logging, too. + def reload(*args) + super + log_start_state + end + def self.create raw_params={}, *args super(permit_attribute_params(raw_params), *args) end @@ -184,6 +200,14 @@ class ArvadosModel < ActiveRecord::Base ["id", "uuid"] end + def self.limit_index_columns_read + # This method returns a list of column names. + # If an index request reads that column from the database, + # APIs that return lists will only fetch objects until reaching + # max_index_database_read bytes of data from those columns. + [] + end + # If current user can manage the object, return an array of uuids of # users and groups that have permission to write the object. The # first two elements are always [self.owner_uuid, current user's @@ -228,48 +252,79 @@ class ArvadosModel < ActiveRecord::Base kwargs = {} end - # Check if any of the users are admin. If so, we're done. - if users_list.select { |u| u.is_admin }.any? - return self - end - # Collect the UUIDs of the authorized users. - user_uuids = users_list.map { |u| u.uuid } - - # Collect the UUIDs of all groups readable by any of the - # authorized users. If one of these (or the UUID of one of the - # authorized users themselves) is an object's owner_uuid, that - # object is readable. - owner_uuids = user_uuids + users_list.flat_map { |u| u.groups_i_can(:read) } - owner_uuids.uniq! - - sql_conds = [] sql_table = kwargs.fetch(:table_name, table_name) + include_trash = kwargs.fetch(:include_trash, false) + query_on = kwargs.fetch(:query_on, self) - # Match any object (evidently a group or user) whose UUID is - # listed explicitly in owner_uuids. - sql_conds += ["#{sql_table}.uuid in (:owner_uuids)"] + sql_conds = [] + user_uuids = users_list.map { |u| u.uuid } - # Match any object whose owner is listed explicitly in - # owner_uuids. - sql_conds += ["#{sql_table}.owner_uuid IN (:owner_uuids)"] + User.install_view('permission') - # Match the head of any permission link whose tail is listed - # explicitly in owner_uuids. - sql_conds += ["#{sql_table}.uuid IN (SELECT head_uuid FROM links WHERE link_class='permission' AND tail_uuid IN (:owner_uuids))"] + # Check if any of the users are admin. + if users_list.select { |u| u.is_admin }.any? + if !include_trash + # exclude rows that are trashed. + if self.column_names.include? "owner_uuid" + sql_conds += ["NOT EXISTS(SELECT target_uuid + FROM permission_view + WHERE trashed = 1 AND + (#{sql_table}.uuid = target_uuid OR #{sql_table}.owner_uuid = target_uuid))"] + else + sql_conds += ["NOT EXISTS(SELECT target_uuid + FROM permission_view + WHERE trashed = 1 AND + (#{sql_table}.uuid = target_uuid))"] + end + end + else + trash_clause = if !include_trash then "trashed = 0 AND" else "" end + + # Can read object (evidently a group or user) whose UUID is listed + # explicitly in user_uuids. + sql_conds += ["#{sql_table}.uuid IN (:user_uuids)"] + + direct_permission_check = "EXISTS(SELECT 1 FROM permission_view + WHERE user_uuid IN (:user_uuids) AND perm_level >= 1 AND #{trash_clause} + (#{sql_table}.uuid = target_uuid))" + + if self.column_names.include? "owner_uuid" + # if an explicit permission row exists for the uuid in question, apply + # the "direct_permission_check" + # if not, check for permission to read the owner instead + sql_conds += ["CASE + WHEN EXISTS(select 1 FROM permission_view where target_uuid = #{sql_table}.uuid) + THEN #{direct_permission_check} + ELSE EXISTS(SELECT 1 FROM permission_view + WHERE user_uuid IN (:user_uuids) AND perm_level >= 1 AND #{trash_clause} + (#{sql_table}.owner_uuid = target_uuid AND target_owner_uuid is NOT NULL)) + END"] + # Can also read if one of the users is the owner of the object. + trash_clause = if !include_trash + "1 NOT IN (SELECT trashed + FROM permission_view + WHERE #{sql_table}.uuid = target_uuid) AND" + else + "" + end + sql_conds += ["(#{trash_clause} #{sql_table}.owner_uuid IN (:user_uuids))"] + else + sql_conds += [direct_permission_check] + end - if sql_table == "links" - # Match any permission link that gives one of the authorized - # users some permission _or_ gives anyone else permission to - # view one of the authorized users. - sql_conds += ["(#{sql_table}.link_class in (:permission_link_classes) AND "+ - "(#{sql_table}.head_uuid IN (:user_uuids) OR #{sql_table}.tail_uuid IN (:user_uuids)))"] + if sql_table == "links" + # Match any permission link that gives one of the authorized + # users some permission _or_ gives anyone else permission to + # view one of the authorized users. + sql_conds += ["(#{sql_table}.link_class IN (:permission_link_classes) AND "+ + "(#{sql_table}.head_uuid IN (:user_uuids) OR #{sql_table}.tail_uuid IN (:user_uuids)))"] + end end - where(sql_conds.join(' OR '), - owner_uuids: owner_uuids, - user_uuids: user_uuids, - permission_link_classes: ['permission', 'resources']) + query_on.where(sql_conds.join(' OR '), + user_uuids: user_uuids, + permission_link_classes: ['permission', 'resources']) end def save_with_unique_name!