X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/779547997857b04c27e5df52f70d527fcaa7a551..49b58cc43218106f1633c389598894d59447a26b:/services/api/app/models/arvados_model.rb diff --git a/services/api/app/models/arvados_model.rb b/services/api/app/models/arvados_model.rb index 5798b4ef75..a170fb9b54 100644 --- a/services/api/app/models/arvados_model.rb +++ b/services/api/app/models/arvados_model.rb @@ -21,8 +21,8 @@ class ArvadosModel < ActiveRecord::Base after_update :log_update after_destroy :log_destroy after_find :convert_serialized_symbols_to_strings + before_validation :normalize_collection_uuids validate :ensure_serialized_attribute_type - validate :normalize_collection_uuids validate :ensure_valid_uuids # Note: This only returns permission links. It does not account for @@ -36,6 +36,12 @@ class ArvadosModel < ActiveRecord::Base end end + class AlreadyLockedError < StandardError + def http_status + 403 + end + end + class UnauthorizedError < StandardError def http_status 401 @@ -90,16 +96,26 @@ class ArvadosModel < ActiveRecord::Base api_column_map end - # Return nil if current user is not allowed to see the list of - # writers. Otherwise, return a list of user_ and group_uuids with - # write permission. (If not returning nil, current_user is always in - # the list because can_manage permission is needed to see the list - # of writers.) + # If current user can manage the object, return an array of uuids of + # users and groups that have permission to write the object. The + # first two elements are always [self.owner_uuid, current user's + # uuid]. + # + # If current user can write but not manage the object, return + # [self.owner_uuid, current user's uuid]. + # + # If current user cannot write this object, just return + # [self.owner_uuid]. def writable_by unless (owner_uuid == current_user.uuid or current_user.is_admin or - current_user.groups_i_can(:manage).index(owner_uuid)) - return nil + (current_user.groups_i_can(:manage) & [uuid, owner_uuid]).any?) + if ((current_user.groups_i_can(:write) + [current_user.uuid]) & + [uuid, owner_uuid]).any? + return [owner_uuid, current_user.uuid] + else + return [owner_uuid] + end end [owner_uuid, current_user.uuid] + permissions.collect do |p| if ['can_write', 'can_manage'].index p.name @@ -131,8 +147,6 @@ class ArvadosModel < ActiveRecord::Base # Collect the uuids for each user and any groups readable by each user. user_uuids = users_list.map { |u| u.uuid } uuid_list = user_uuids + users_list.flat_map { |u| u.groups_i_can(:read) } - sanitized_uuid_list = uuid_list. - collect { |uuid| sanitize(uuid) }.join(', ') sql_conds = [] sql_params = [] sql_table = kwargs.fetch(:table_name, table_name) @@ -146,12 +160,18 @@ class ArvadosModel < ActiveRecord::Base # A permission link exists ('write' and 'manage' implicitly include # 'read') from a member of users_list, or a group readable by users_list, # to this row, or to the owner of this row (see join() below). - permitted_uuids = "(SELECT head_uuid FROM links WHERE link_class='permission' AND tail_uuid IN (#{sanitized_uuid_list}))" + sql_conds += ["#{sql_table}.uuid in (?)"] + sql_params += [user_uuids] - sql_conds += ["#{sql_table}.owner_uuid in (?)", - "#{sql_table}.uuid in (?)", - "#{sql_table}.uuid IN #{permitted_uuids}"] - sql_params += [uuid_list, user_uuids] + if uuid_list.any? + sql_conds += ["#{sql_table}.owner_uuid in (?)"] + sql_params += [uuid_list] + + sanitized_uuid_list = uuid_list. + collect { |uuid| sanitize(uuid) }.join(', ') + permitted_uuids = "(SELECT head_uuid FROM links WHERE link_class='permission' AND tail_uuid IN (#{sanitized_uuid_list}))" + sql_conds += ["#{sql_table}.uuid IN #{permitted_uuids}"] + end if sql_table == "links" and users_list.any? # This row is a 'permission' or 'resources' link class @@ -170,12 +190,6 @@ class ArvadosModel < ActiveRecord::Base sql_params += [uuid_list] end - if sql_table == "collections" and users_list.any? - # There is a 'name' link going from a readable group to the collection. - name_links = "(SELECT head_uuid FROM links WHERE link_class='name' AND tail_uuid IN (#{sanitized_uuid_list}))" - sql_conds += ["#{sql_table}.uuid IN #{name_links}"] - end - # Link head points to this row, or to the owner of this row (the # thing to be read) # @@ -191,20 +205,13 @@ class ArvadosModel < ActiveRecord::Base attributes end - def has_permission? perm_type, target_uuid - Link.where(link_class: "permission", - name: perm_type, - tail_uuid: uuid, - head_uuid: target_uuid).any? - end - protected def ensure_ownership_path_leads_to_user if new_record? or owner_uuid_changed? uuid_in_path = {owner_uuid => true, uuid => true} x = owner_uuid - while (owner_class = self.class.resource_class_for_uuid(x)) != User + while (owner_class = ArvadosModel::resource_class_for_uuid(x)) != User begin if x == uuid # Test for cycles with the new version, not the DB contents @@ -234,12 +241,29 @@ class ArvadosModel < ActiveRecord::Base def ensure_owner_uuid_is_permitted raise PermissionDeniedError if !current_user + if new_record? and respond_to? :owner_uuid= self.owner_uuid ||= current_user.uuid end - # Verify permission to write to old owner (unless owner_uuid was - # nil -- or hasn't changed, in which case the following - # "permission to write to new owner" block will take care of us) + + if self.owner_uuid.nil? + errors.add :owner_uuid, "cannot be nil" + raise PermissionDeniedError + end + + rsc_class = ArvadosModel::resource_class_for_uuid owner_uuid + unless rsc_class == User or rsc_class == Group + errors.add :owner_uuid, "must be set to User or Group" + raise PermissionDeniedError + end + + # Verify "write" permission on old owner + # default fail unless one of: + # owner_uuid did not change + # previous owner_uuid is nil + # current user is the old owner + # current user is this object + # current user can_write old owner unless !owner_uuid_changed? or owner_uuid_was.nil? or current_user.uuid == self.owner_uuid_was or @@ -249,12 +273,18 @@ class ArvadosModel < ActiveRecord::Base errors.add :owner_uuid, "cannot be changed without write permission on old owner" raise PermissionDeniedError end - # Verify permission to write to new owner + + # Verify "write" permission on new owner + # default fail unless one of: + # current_user is this object + # current user can_write new owner unless current_user == self or current_user.can? write: owner_uuid logger.warn "User #{current_user.uuid} tried to modify #{self.class.to_s} #{uuid} but does not have permission to write new owner_uuid #{owner_uuid}" errors.add :owner_uuid, "cannot be changed without write permission on new owner" raise PermissionDeniedError end + + true end def ensure_permission_to_save @@ -398,8 +428,6 @@ class ArvadosModel < ActiveRecord::Base end end - @@UUID_REGEX = /^[0-9a-z]{5}-([0-9a-z]{5})-[0-9a-z]{15}$/ - @@prefixes_hash = nil def self.uuid_prefixes unless @@prefixes_hash @@ -417,8 +445,12 @@ class ArvadosModel < ActiveRecord::Base "_____-#{uuid_prefix}-_______________" end + def self.uuid_regex + %r/[a-z0-9]{5}-#{uuid_prefix}-[a-z0-9]{15}/ + end + def ensure_valid_uuids - specials = [system_user_uuid, 'd41d8cd98f00b204e9800998ecf8427e+0'] + specials = [system_user_uuid] foreign_key_attributes.each do |attr| if new_record? or send (attr + "_changed?") @@ -464,13 +496,10 @@ class ArvadosModel < ActiveRecord::Base unless uuid.is_a? String return nil end - if uuid.match /^[0-9a-f]{32}(\+[^,]+)*(,[0-9a-f]{32}(\+[^,]+)*)*$/ - return Collection - end resource_class = nil Rails.application.eager_load! - uuid.match @@UUID_REGEX do |re| + uuid.match HasUuid::UUID_REGEX do |re| return uuid_prefixes[re[1]] if uuid_prefixes[re[1]] end @@ -502,7 +531,6 @@ class ArvadosModel < ActiveRecord::Base log = Log.new(event_type: event_type).fill_object(self) yield log log.save! - connection.execute "NOTIFY logs, '#{log.id}'" log_start_state end