X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/7699440ac6000480ffbcd22f5a1c2982fb056dc5..a882872e54809a5f5a19fc5673f7dd53655f1cb8:/services/keepstore/pull_worker.go

diff --git a/services/keepstore/pull_worker.go b/services/keepstore/pull_worker.go
index db1d756ad8..46b933c5e0 100644
--- a/services/keepstore/pull_worker.go
+++ b/services/keepstore/pull_worker.go
@@ -8,12 +8,9 @@ import (
 	"io"
 	"io/ioutil"
 	"log"
-	"os"
 	"time"
 )
 
-var keepClient keepclient.KeepClient
-
 /*
 	Keepstore initiates pull worker channel goroutine.
 	The channel will process pull list.
@@ -22,11 +19,16 @@ var keepClient keepclient.KeepClient
 			Skip the rest of the servers if no errors
 		Repeat
 */
-func RunPullWorker(pullq *WorkQueue, kc keepclient.KeepClient) {
+func RunPullWorker(pullq *WorkQueue, keepClient keepclient.KeepClient) {
 	nextItem := pullq.NextItem
-	keepClient = kc
 	for item := range nextItem {
-		Pull(item.(PullRequest))
+		pullRequest := item.(PullRequest)
+		err := Pull(item.(PullRequest), keepClient)
+		if err == nil {
+			log.Printf("Pull %s success", pullRequest)
+		} else {
+			log.Printf("Pull %s error: %s", pullRequest, err)
+		}
 	}
 }
 
@@ -37,15 +39,7 @@ func RunPullWorker(pullq *WorkQueue, kc keepclient.KeepClient) {
 		Using this token & signature, retrieve the given block.
 		Write to storage
 */
-func Pull(pullRequest PullRequest) (err error) {
-	defer func() {
-		if err == nil {
-			log.Printf("Pull %s success", pullRequest)
-		} else {
-			log.Printf("Pull %s error: %s", pullRequest, err)
-		}
-	}()
-
+func Pull(pullRequest PullRequest, keepClient keepclient.KeepClient) (err error) {
 	service_roots := make(map[string]string)
 	for _, addr := range pullRequest.Servers {
 		service_roots[addr] = addr
@@ -53,11 +47,10 @@ func Pull(pullRequest PullRequest) (err error) {
 	keepClient.SetServiceRoots(service_roots)
 
 	// Generate signature with a random token
-	PermissionSecret = []byte(os.Getenv("ARVADOS_API_TOKEN"))
 	expires_at := time.Now().Add(60 * time.Second)
 	signedLocator := SignLocator(pullRequest.Locator, GenerateRandomApiToken(), expires_at)
 
-	reader, contentLen, _, err := GetContent(pullRequest.Locator, signedLocator)
+	reader, contentLen, _, err := GetContent(signedLocator, keepClient)
 	if err != nil {
 		return
 	}
@@ -80,7 +73,8 @@ func Pull(pullRequest PullRequest) (err error) {
 }
 
 // Fetch the content for the given locator using keepclient.
-var GetContent = func(locator string, signedLocator string) (reader io.ReadCloser, contentLength int64, url string, err error) {
+var GetContent = func(signedLocator string, keepClient keepclient.KeepClient) (
+	reader io.ReadCloser, contentLength int64, url string, err error) {
 	reader, blocklen, url, err := keepClient.Get(signedLocator)
 	return reader, blocklen, url, err
 }