X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/7699440ac6000480ffbcd22f5a1c2982fb056dc5..231a86fd3f7e30e9f66d71d92ad7c26578637e37:/apps/workbench/test/integration/pipeline_instances_test.rb diff --git a/apps/workbench/test/integration/pipeline_instances_test.rb b/apps/workbench/test/integration/pipeline_instances_test.rb index f8d5796199..adfd62bd8e 100644 --- a/apps/workbench/test/integration/pipeline_instances_test.rb +++ b/apps/workbench/test/integration/pipeline_instances_test.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'integration_helper' class PipelineInstancesTest < ActionDispatch::IntegrationTest @@ -5,6 +9,58 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest need_javascript end + def parse_browser_timestamp t + # Timestamps are displayed in the browser's time zone (which can + # differ from ours) and they come from toLocaleTimeString (which + # means they don't necessarily tell us which time zone they're + # using). In order to make sense of them, we need to ask the + # browser to parse them and generate a timestamp that can be + # parsed reliably. + # + # Note: Even with all this help, phantomjs seem to behave badly + # when parsing timestamps on the other side of a DST transition. + # See skipped tests below. + + # In some locales (e.g., en_CA.UTF-8) Firefox can't parse what its + # own toLocaleString() puts out. + t.sub!(/(\d\d\d\d)-(\d\d)-(\d\d)/, '\2/\3/\1') + + if /(\d+:\d+ [AP]M) (\d+\/\d+\/\d+)/ =~ t + # Currently dates.js renders timestamps as + # '{t.toLocaleTimeString()} {t.toLocaleDateString()}' which even + # en_US browsers can't make sense of. First we need to flip it + # around so it looks like what toLocaleString() would have made. + t = $~[2] + ', ' + $~[1] + end + + utc = page.evaluate_script("new Date('#{t}').toUTCString()") + DateTime.parse(utc).to_time + end + + if false + # No need to test (or mention) these all the time. If they start + # working (without need_selenium) then some real tests might not + # need_selenium any more. + + test 'phantomjs DST' do + skip '^^' + t0s = '3/8/2015, 01:59 AM' + t1s = '3/8/2015, 03:01 AM' + t0 = parse_browser_timestamp t0s + t1 = parse_browser_timestamp t1s + assert_equal 120, t1-t0, "'#{t0s}' to '#{t1s}' was reported as #{t1-t0} seconds, should be 120" + end + + test 'phantomjs DST 2' do + skip '^^' + t0s = '2015-03-08T10:43:00Z' + t1s = '2015-03-09T03:43:00Z' + t0 = parse_browser_timestamp page.evaluate_script("new Date('#{t0s}').toLocaleString()") + t1 = parse_browser_timestamp page.evaluate_script("new Date('#{t1s}').toLocaleString()") + assert_equal 17*3600, t1-t0, "'#{t0s}' to '#{t1s}' was reported as #{t1-t0} seconds, should be #{17*3600} (17 hours)" + end + end + test 'Create and run a pipeline' do visit page_with_token('active_trustedclient', '/pipeline_templates') within('tr', text: 'Two Part Pipeline Template') do @@ -12,7 +68,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest end # project chooser - within('.modal-dialog') do + within('.modal-dialog') do #FIXME: source of 1 test error find('.selectable', text: 'A Project').click find('button', text: 'Choose').click end @@ -33,11 +89,11 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest first('span', text: 'foo_tag').click find('.btn', text: 'Copy').click end - using_wait_time(Capybara.default_wait_time * 3) do + using_wait_time(Capybara.default_max_wait_time * 3) do wait_for_ajax end - click_link 'Jobs and pipelines' + click_link 'Pipelines and processes' find('tr[data-kind="arvados#pipelineInstance"]', text: '(none)'). find('a', text: 'Show'). click @@ -84,9 +140,9 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest click_link 'API response' api_response = JSON.parse(find('div#advanced_api_response pre').text) input_params = api_response['components']['part-one']['script_parameters']['input'] - assert_equal input_params['value'], collection['portable_data_hash'] - assert_equal input_params['selection_name'], collection['name'] - assert_equal input_params['selection_uuid'], collection['uuid'] + assert_equal collection['portable_data_hash'], input_params['value'] + assert_equal collection['name'], input_params['selection_name'] + assert_equal collection['uuid'], input_params['selection_uuid'] # "Run" button is now enabled page.assert_no_selector 'a.disabled,button.disabled', text: 'Run' @@ -104,7 +160,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest page.assert_selector 'a,button', text: 'Re-run options' # Since it is test env, no jobs are created to run. So, graph not visible - assert_not page.has_text? 'Graph' + assert page.has_no_text? 'Graph' end # Create a pipeline instance from within a project and run @@ -121,7 +177,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest first('span', text: 'foo_tag').click find('.btn', text: 'Copy').click end - using_wait_time(Capybara.default_wait_time * 3) do + using_wait_time(Capybara.default_max_wait_time * 3) do wait_for_ajax end @@ -181,7 +237,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest template_uuid = api_fixture("pipeline_templates", template_name, "uuid") visit page_with_token("active", "/pipeline_templates/#{template_uuid}") click_on "Run this pipeline" - within(".modal-dialog") do + within(".modal-dialog") do # FIXME: source of 3 test errors # Set project for the new pipeline instance find(".selectable", text: project_name).click click_on "Choose" @@ -337,9 +393,10 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest def create_and_run_pipeline_in_aproject in_aproject, template_name, collection_fixture, choose_file=false # collection in aproject to be used as input collection = api_fixture('collections', collection_fixture) + collection['name'] ||= '' # API response is "" even if fixture attr is null # create a pipeline instance - find('.btn', text: 'Run a pipeline').click + find('.btn', text: 'Run a process').click within('.modal-dialog') do find('.selectable', text: template_name).click find('.btn', text: 'Next: choose inputs').click @@ -365,7 +422,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest if collection_fixture == 'foo_collection_in_aproject' first('span', text: 'foo_tag').click - elsif collection['name'] + elsif collection['name'] != '' first('span', text: "#{collection['name']}").click else collection_uuid = collection['uuid'] @@ -389,13 +446,13 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest api_response = JSON.parse(find('div#advanced_api_response pre').text) input_params = api_response['components']['part-one']['script_parameters']['input'] - assert_equal(input_params['selection_uuid'], collection['uuid'], "Not found expected input param uuid") + assert_equal(collection['uuid'], input_params['selection_uuid'], "Not found expected input param uuid") if choose_file - assert_equal(input_params['value'], collection['portable_data_hash']+'/foo', "Not found expected input file param value") - assert_equal(input_params['selection_name'], collection['name']+'/foo', "Not found expected input file param name") + assert_equal(collection['portable_data_hash']+'/foo', input_params['value'], "Not found expected input file param value") + assert_equal(collection['name']+'/foo', input_params['selection_name'], "Not found expected input file param name") else - assert_equal(input_params['value'], collection['portable_data_hash'], "Not found expected input param value") - assert_equal(input_params['selection_name'], collection['name'], "Not found expected input selection name") + assert_equal(collection['portable_data_hash'], input_params['value'], "Not found expected input param value") + assert_equal(collection['name'], input_params['selection_name'], "Not found expected input selection name") end # "Run" button present and enabled @@ -408,7 +465,7 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest page.assert_selector 'a,button', text: 'Pause' # Since it is test env, no jobs are created to run. So, graph not visible - assert_not page.has_text? 'Graph' + assert page.has_no_text? 'Graph' end [ @@ -417,33 +474,25 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest ['active', 'zzzzz-d1hrv-runningpipeline', nil], # state = running ].each do |user, uuid, run_time| test "pipeline start and finish time display for #{uuid}" do + need_selenium 'to parse timestamps correctly across DST boundaries' visit page_with_token(user, "/pipeline_instances/#{uuid}") - assert page.has_text? 'This pipeline started at' - page_text = page.text - + regexp = "This pipeline started at (.+?)\\. " if run_time - match = /This pipeline started at (.*)\. It failed after (.*) seconds at (.*)\. Check the Log/.match page_text + regexp += "It failed after (.+?) at (.+?)\\. Check the Log" else - match = /This pipeline started at (.*). It has been active for(.*)/.match page_text + regexp += "It has been active for \\d" end - assert_not_nil(match, 'Did not find text - This pipeline started at . . . ') + assert_match /#{regexp}/, page.text - start_at = match[1] - assert_not_nil(start_at, 'Did not find start_at time') + return if !run_time - # start and finished time display is of the format '2:20 PM 10/20/2014' - start_time = DateTime.strptime(start_at, '%H:%M %p %m/%d/%Y').to_time - if run_time - finished_at = match[3] - assert_not_nil(finished_at, 'Did not find finished_at time') - finished_time = DateTime.strptime(finished_at, '%H:%M %p %m/%d/%Y').to_time - assert_equal(run_time, finished_time-start_time, - "Time difference did not match for start_at #{start_at}, finished_at #{finished_at}, ran_for #{match[2]}") - else - match = /\d(.*)/.match match[2] - assert_not_nil match, 'Did not find expected match for running component' - end + # match again to capture (.*) + _, started, duration, finished = *(/#{regexp}/.match(page.text)) + assert_equal( + run_time, + parse_browser_timestamp(finished) - parse_browser_timestamp(started), + "expected: #{run_time}, got: started #{started}, finished #{finished}, duration #{duration}") end end @@ -496,4 +545,45 @@ class PipelineInstancesTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/pipeline_instances/' + pi['uuid'] assert_text 'Queued for ' end + + test "job logs linked for running pipeline" do + pi = api_fixture("pipeline_instances", "running_pipeline_with_complete_job") + visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}")) + find(:xpath, "//a[@href='#Log']").click + within "#Log" do + assert_text "Log for previous" + log_link = find("a", text: "Log for previous") + assert_includes(log_link[:href], + "/jobs/#{pi["components"]["previous"]["job"]["uuid"]}#Log") + assert_selector "#event_log_div" + end + end + + test "job logs linked for complete pipeline" do + pi = api_fixture("pipeline_instances", "complete_pipeline_with_two_jobs") + visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}")) + find(:xpath, "//a[@href='#Log']").click + within "#Log" do + assert_text "Log for previous" + pi["components"].each do |cname, cspec| + log_link = find("a", text: "Log for #{cname}") + assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log") + end + assert_no_selector "#event_log_div" + end + end + + test "job logs linked for failed pipeline" do + pi = api_fixture("pipeline_instances", "failed_pipeline_with_two_jobs") + visit(page_with_token("active", "/pipeline_instances/#{pi['uuid']}")) + find(:xpath, "//a[@href='#Log']").click + within "#Log" do + assert_text "Log for previous" + pi["components"].each do |cname, cspec| + log_link = find("a", text: "Log for #{cname}") + assert_includes(log_link[:href], "/jobs/#{cspec["job"]["uuid"]}#Log") + end + assert_no_selector "#event_log_div" + end + end end