X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/763af5413e6195fe004846abf86a7ae134168990..9b61792d905324a98b24224d45347082efbe5205:/services/api/test/unit/collection_test.rb

diff --git a/services/api/test/unit/collection_test.rb b/services/api/test/unit/collection_test.rb
index 8853319e63..1386a25e74 100644
--- a/services/api/test/unit/collection_test.rb
+++ b/services/api/test/unit/collection_test.rb
@@ -9,14 +9,14 @@ class CollectionTest < ActiveSupport::TestCase
 
   test 'accept ASCII manifest_text' do
     act_as_system_user do
-      c = create_collection 'foo'
+      c = create_collection 'foo', Encoding::US_ASCII
       assert c.valid?
     end
   end
 
   test 'accept UTF-8 manifest_text' do
     act_as_system_user do
-      c = create_collection "f\xc3\x98\xc3\x98"
+      c = create_collection "f\xc3\x98\xc3\x98", Encoding::UTF_8
       assert c.valid?
     end
   end
@@ -38,4 +38,57 @@ class CollectionTest < ActiveSupport::TestCase
       assert_match /UTF-8/, c.errors.messages[:manifest_text].first
     end
   end
+
+  test 'create and update collection and verify file_names' do
+    act_as_system_user do
+      c = create_collection 'foo', Encoding::US_ASCII
+      assert c.valid?
+      created_file_names = c.file_names
+      assert created_file_names
+      assert_match /foo.txt/, c.file_names
+
+      c.update_attribute 'manifest_text', ". d41d8cd98f00b204e9800998ecf8427e+0 0:0:foo2.txt\n"
+      assert_not_equal created_file_names, c.file_names
+      assert_match /foo2.txt/, c.file_names
+    end
+  end
+
+  [
+    [2**8, false],
+    [2**18, true],
+  ].each do |manifest_size, gets_truncated|
+    test "create collection with manifest size #{manifest_size} which gets truncated #{gets_truncated},
+          and not expect exceptions even on very large manifest texts" do
+      # file_names has a max size, hence there will be no errors even on large manifests
+      act_as_system_user do
+        manifest_text = './blurfl d41d8cd98f00b204e9800998ecf8427e+0'
+        index = 0
+        while manifest_text.length < manifest_size
+          manifest_text += ' ' + "0:0:veryverylongfilename000000000000#{index}.txt\n./subdir1"
+          index += 1
+        end
+        manifest_text += "\n"
+        c = Collection.create(manifest_text: manifest_text)
+
+        assert c.valid?
+        assert c.file_names
+        assert_match /veryverylongfilename0000000000001.txt/, c.file_names
+        assert_match /veryverylongfilename0000000000002.txt/, c.file_names
+        if !gets_truncated
+          assert_match /blurfl/, c.file_names
+          assert_match /subdir1/, c.file_names
+        end
+      end
+    end
+  end
+
+  [0, 2, 4, nil].each do |ask|
+    test "replication_desired reports #{ask or 2} if redundancy is #{ask}" do
+      act_as_user users(:active) do
+        c = collections(:collection_owned_by_active)
+        c.update_attributes redundancy: ask
+        assert_equal (ask or 2), c.replication_desired
+      end
+    end
+  end
 end