X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/73d8ff765611e02a44525a75e1b97348ea3dc185..e3c562dff0f84634c12e14c232a5ab677892ed6e:/apps/workbench/test/integration/anonymous_access_test.rb

diff --git a/apps/workbench/test/integration/anonymous_access_test.rb b/apps/workbench/test/integration/anonymous_access_test.rb
index 2a0aa87d11..0fb21b2d2f 100644
--- a/apps/workbench/test/integration/anonymous_access_test.rb
+++ b/apps/workbench/test/integration/anonymous_access_test.rb
@@ -8,85 +8,57 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest
 
   setup do
     need_javascript
+    Rails.configuration.anonymous_user_token = api_fixture('api_client_authorizations')['anonymous']['api_token']
   end
 
-  def verify_homepage_anonymous_enabled user, is_active, has_profile
+  PUBLIC_PROJECT = "/projects/#{api_fixture('groups')['anonymously_accessible_project']['uuid']}"
+
+  def verify_site_navigation_anonymous_enabled user, is_active
     if user
       if user['is_active']
-        if has_profile
-          assert_text 'Unrestricted public data'
-          assert_selector 'a', text: 'Projects'
-        else
-          assert_text 'All required fields must be completed before you can proceed'
-        end
+        assert_text 'Unrestricted public data'
+        assert_selector 'a', text: 'Projects'
       else
         assert_text 'indicate that you have read and accepted the user agreement'
       end
       within('.navbar-fixed-top') do
-        assert_no_text 'You are viewing public data'
+        assert_selector 'a', text: Rails.configuration.site_name.downcase
         assert_selector 'a', text: "#{user['email']}"
         find('a', text: "#{user['email']}").click
         within('.dropdown-menu') do
           assert_selector 'a', text: 'Log out'
         end
       end
-    else
+    else  # anonymous
       assert_text 'Unrestricted public data'
       within('.navbar-fixed-top') do
-        assert_text 'You are viewing public data'
-        anonymous_user = api_fixture('users')['anonymous']
-        assert_selector 'a', "#{anonymous_user['email']}"
-        find('a', text: "#{anonymous_user['email']}").click
-        within('.dropdown-menu') do
-          assert_selector 'a', text: 'Log in'
-          assert_no_selector 'a', text: 'Log out'
-        end
+        assert_text Rails.configuration.site_name.downcase
+        assert_no_selector 'a', text: Rails.configuration.site_name.downcase
+        assert_selector 'a', text: 'Log in'
       end
     end
   end
 
-  def visit_publicly_accessible_project token=nil, use_config=true, path=nil
-    if use_config
-      Rails.configuration.anonymous_user_token = api_fixture('api_client_authorizations')['anonymous']['api_token']
-    else
-      Rails.configuration.anonymous_user_token = false
-    end
-
-    path = "/projects/#{api_fixture('groups')['anonymously_accessible_project']['uuid']}/?public_data=true" if !path
-
-    if token
-        visit page_with_token(token, path)
-    else
-      visit path
-    end
-  end
-
   [
     [nil, nil, false, false],
     ['inactive', api_fixture('users')['inactive'], false, false],
     ['active', api_fixture('users')['active'], true, true],
-    ['active_no_prefs_profile', api_fixture('users')['active_no_prefs_profile'], true, false],
-  ].each do |token, user, is_active, has_profile|
+  ].each do |token, user, is_active|
     test "visit public project as user #{token.inspect} when anonymous browsing is enabled" do
-      visit_publicly_accessible_project token
-      verify_homepage_anonymous_enabled user, is_active, has_profile
-    end
-  end
-
-  test "anonymous user visit public project when anonymous browsing not enabled and expect to see login page" do
-    visit_publicly_accessible_project nil, false
-    assert_text 'Please log in'
-  end
+      if !token
+        visit PUBLIC_PROJECT
+      else
+        visit page_with_token(token, PUBLIC_PROJECT)
+      end
 
-  test "visit non-public project as anonymous when anonymous browsing is enabled and expect page not found" do
-    visit_publicly_accessible_project nil, true,
-        "/projects/#{api_fixture('groups')['aproject']['uuid']}/?public_data=true"
-    assert_text 'Not Found'
+      verify_site_navigation_anonymous_enabled user, is_active
+    end
   end
 
   test "selection actions when anonymous user accesses shared project" do
-    visit_publicly_accessible_project
+    visit PUBLIC_PROJECT
 
+    assert_selector 'a', text: 'Description'
     assert_selector 'a', text: 'Data collections'
     assert_selector 'a', text: 'Jobs and pipelines'
     assert_selector 'a', text: 'Pipeline templates'
@@ -95,6 +67,7 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest
     assert_no_selector 'a', text: 'Other objects'
     assert_no_selector 'button', text: 'Add data'
 
+    click_link 'Data collections'
     click_button 'Selection'
     within('.selection-action-container') do
       assert_selector 'li', text: 'Compare selected'
@@ -105,127 +78,95 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest
     end
   end
 
-  [
-    ['All pipelines', 'Pipeline in publicly accessible project'],
-    ['All jobs', 'job submitted'],
-    ['All collections', 'GNU_General_Public_License,_version_3.pdf'],
-  ].each do |selector, expectation|
-    test "verify dashboard when anonymous user accesses shared project and click #{selector}" do
-      visit_publicly_accessible_project
-
-      # go to dashboard
-      click_link 'You are viewing public data'
-
-      assert_no_selector 'a', text: 'Run a pipeline'
-      assert_selector 'a', text: selector
-      click_link selector
-      assert_text expectation
-    end
-  end
-
   test "anonymous user accesses data collections tab in shared project" do
-    visit_publicly_accessible_project
+    visit PUBLIC_PROJECT
+    click_link 'Data collections'
+    collection = api_fixture('collections')['user_agreement_in_anonymously_accessible_project']
+    assert_text 'GNU General Public License'
 
-    assert_selector 'a', text: 'Data collections (1)'
+    assert_selector 'a', text: 'Data collections'
 
     # click on show collection
-    within first('tr[data-kind="arvados#collection"]') do
+    within "tr[data-object-uuid=\"#{collection['uuid']}\"]" do
       click_link 'Show'
     end
 
     # in collection page
     assert_no_selector 'input', text: 'Create sharing link'
+    assert_no_text 'Sharing and permissions'
     assert_no_selector 'a', text: 'Upload'
     assert_no_selector 'button', 'Selection'
 
-    within ('#collection_files') do
-      assert_text 'GNU_General_Public_License,_version_3.pdf'
-      # how do i assert the view and download link existence?
+    within '#collection_files tr,li', text: 'GNU_General_Public_License,_version_3.pdf' do
+      assert page.has_no_selector?('[value*="GNU_General_Public_License"]')
+      find 'a[title~=View]'
+      find 'a[title~=Download]'
     end
   end
 
-  [
-    [nil, 'running_job'],
-    [nil, 'completed_job'],
-    ['admin', 'running_job', api_fixture('jobs')['running_job_in_publicly_accessible_project']['uuid']],
-    ['admin', 'completed_job', api_fixture('jobs')['completed_job_in_publicly_accessible_project']['uuid']],
-    [nil, 'pipelineInstance'],
-    ['admin', 'pipelineInstance', api_fixture('pipeline_instances')['pipeline_in_publicly_accessible_project']['uuid']],
-  ].each do |token, type, uuid=nil|
-    test "user #{token.inspect} accesses jobs and pipelines tab in shared project and clicks on #{type}" do
-      if !token 
-        visit_publicly_accessible_project
-        click_link 'Jobs and pipelines'
-        assert_text 'Pipeline in publicly accessible project'
-      else
-        # directly go to the job or pipeline instance page to save test run time; see below
-      end
+  test 'view file' do
+    magic = rand(2**512).to_s 36
+    CollectionsController.any_instance.stubs(:file_enumerator).returns([magic])
+    collection = api_fixture('collections')['public_text_file']
+    visit '/collections/' + collection['uuid']
+    find('tr,li', text: 'Hello world.txt').
+      find('a[title~=View]').click
+    assert_text magic
+  end
 
-      # click on type specified collection
+  [
+    'running_job',
+    'completed_job',
+    'pipelineInstance'
+  ].each do |type|
+    test "anonymous user accesses jobs and pipelines tab in shared project and clicks on #{type}" do
+      visit PUBLIC_PROJECT
+      click_link 'Data collections'
+      assert_text 'GNU General Public License'
+
+      click_link 'Jobs and pipelines'
+      assert_text 'Pipeline in publicly accessible project'
+
+      # click on the specified job
       if type.include? 'job'
-        verify_job_row token, type, uuid
+        verify_job_row type
       else
-        verify_pipeline_instance_row token, uuid
+        verify_pipeline_instance_row
       end
     end
   end
 
-  def verify_job_row user, look_for, uuid
-    if user
-      visit page_with_token user, "/jobs/#{uuid}"
-    else
-      within first('tr', text: look_for) do
-        click_link 'Show'
-      end
+  def verify_job_row look_for
+    within first('tr', text: look_for) do
+      click_link 'Show'
     end
     assert_text 'script_version'
 
-    if user
-      assert_selector 'a', text: 'Active User'  # modified by user
-      assert_selector 'a', text: 'Log'
-      assert_selector 'a', text: 'Move job'
-      if look_for.include? 'running'
-        assert_selector 'button', text: 'Cancel'
-        assert_no_selector 'button', text: 'Re-run job'
-      else
-        assert_selector 'button', text: 'Re-run job'
-        assert_no_selector 'button', text: 'Cancel'
-      end
-    else
-      assert_text 'zzzzz-tpzed-xurymjxw79nv3jz' # modified by user
-      assert_no_selector 'a', text: 'zzzzz-tpzed-xurymjxw79nv3jz'
-      assert_no_selector 'a', text: 'Log'
-      assert_no_selector 'a', text: 'Move job'
-      assert_no_selector 'button', text: 'Cancel'
-      assert_no_selector 'button', text: 'Re-run job'
-    end
+    assert_text 'zzzzz-tpzed-xurymjxw79nv3jz' # modified by user
+    assert_no_selector 'a', text: 'zzzzz-tpzed-xurymjxw79nv3jz'
+    assert_no_selector 'a', text: 'Move job'
+    assert_no_selector 'button', text: 'Cancel'
+    assert_no_selector 'button', text: 'Re-run job'
   end
 
-  def verify_pipeline_instance_row user, uuid
-    if user
-      visit page_with_token user, "/pipeline_instances/#{uuid}"
-    else
-      within first('tr[data-kind="arvados#pipelineInstance"]') do
-        assert_text 'Pipeline in publicly accessible project'
-        click_link 'Show'
-      end
+  def verify_pipeline_instance_row
+    within first('tr[data-kind="arvados#pipelineInstance"]') do
+      assert_text 'Pipeline in publicly accessible project'
+      click_link 'Show'
     end
 
     # in pipeline instance page
     assert_text 'This pipeline is complete'
-    if user
-      assert_selector 'a', text: 'Re-run with latest'
-      assert_selector 'a', text: 'Re-run options'
-    else
-      assert_no_selector 'a', text: 'Re-run with latest'
-      assert_no_selector 'a', text: 'Re-run options'
-    end
+    assert_no_selector 'a', text: 'Re-run with latest'
+    assert_no_selector 'a', text: 'Re-run options'
   end
 
   test "anonymous user accesses pipeline templates tab in shared project" do
-    visit_publicly_accessible_project
+    visit PUBLIC_PROJECT
+    click_link 'Data collections'
+    assert_text 'GNU General Public License'
 
-    assert_selector 'a', 'Pipeline templates (1)'
+    assert_selector 'a', text: 'Pipeline templates'
 
     click_link 'Pipeline templates'
     assert_text 'Pipeline template in publicly accessible project'
@@ -238,46 +179,4 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest
     assert_text 'script version'
     assert_no_selector 'a', text: 'Run this pipeline'
   end
-
-  [
-    [nil, '/users'],
-    [nil, '/groups'],
-    ['admin', '/users'],
-    ['admin', '/groups'],
-  ].each do |token, page|
-    test "user #{token.inspect} accesses publicly accessible project and then traverses to #{page}" do
-      # go to the page
-      if token
-        visit page_with_token(token, page)
-      else
-        # when anonymous, first visit publicly accessible project
-        visit_publicly_accessible_project token if !token
-        visit page
-      end
-
-      if page == '/users'
-        verify_users_page token
-      elsif page == '/groups'
-        verify_groups_page token
-      end
-    end
-  end
-
-  def verify_users_page user
-    assert_text 'user'
-    if user
-      assert_selector 'a', text: 'Add a new user'
-    else
-      assert_no_selector 'a', text: 'Add a new user'
-    end
-  end
-
-  def verify_groups_page user
-    assert_text 'Group'
-    if user
-      assert_selector 'button', text: 'Add a new group'
-    else
-      assert_no_selector 'button', text: 'Add a new group'
-    end
-  end
 end