X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/7178ac911e7b160c1348da404b5aa07b9829d3c8..aaa45b09de0e9437743fce53d7c0bf8165074b5e:/sdk/python/tests/test_retry.py diff --git a/sdk/python/tests/test_retry.py b/sdk/python/tests/test_retry.py index 8c3916b009..cc12f39a35 100644 --- a/sdk/python/tests/test_retry.py +++ b/sdk/python/tests/test_retry.py @@ -7,8 +7,6 @@ import arvados.errors as arv_error import arvados.retry as arv_retry import mock -from arvados_testutil import fake_httplib2_response - class RetryLoopTestMixin(object): @staticmethod def loop_success(result): @@ -143,15 +141,14 @@ class RetryLoopBackoffTestCase(unittest.TestCase, RetryLoopTestMixin): def test_backoff_multiplier(self, sleep_mock, time_mock): self.run_loop(5, 500, 501, 502, 503, 504, 505, - backoff_start=5, backoff_growth=10) + backoff_start=5, backoff_growth=10, max_wait=1000000000) self.check_backoff(sleep_mock, 5, 9) class CheckHTTPResponseSuccessTestCase(unittest.TestCase): def results_map(self, *codes): for code in codes: - response = (fake_httplib2_response(code), None) - yield code, arv_retry.check_http_response_success(response) + yield code, arv_retry.check_http_response_success(code) def check(assert_name): def check_method(self, expected, *codes): @@ -204,8 +201,10 @@ class RetryMethodTestCase(unittest.TestCase): return (a, num_retries, z) - def test_positional_arg_passed(self): - self.assertEqual((3, 2, 0), self.Tester().check(3, 2)) + def test_positional_arg_raises(self): + # unsupported use -- make sure we raise rather than ignore + with self.assertRaises(TypeError): + self.assertEqual((3, 2, 0), self.Tester().check(3, 2)) def test_keyword_arg_passed(self): self.assertEqual((4, 3, 0), self.Tester().check(num_retries=3, a=4))