X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/7178ac911e7b160c1348da404b5aa07b9829d3c8..2def202591164c9ade2c2b7ab6f67dc892d10557:/apps/workbench/app/controllers/pipeline_instances_controller.rb diff --git a/apps/workbench/app/controllers/pipeline_instances_controller.rb b/apps/workbench/app/controllers/pipeline_instances_controller.rb index 8ee06c3d01..a618d43517 100644 --- a/apps/workbench/app/controllers/pipeline_instances_controller.rb +++ b/apps/workbench/app/controllers/pipeline_instances_controller.rb @@ -16,12 +16,16 @@ class PipelineInstancesController < ApplicationController @object.components.each do |cname, component| # Go through the script parameters of each component # that are marked as user input and copy them over. - component[:script_parameters].each do |pname, val| - if val.is_a? Hash and val[:dataclass] - # this is user-inputtable, so check the value from the source pipeline - srcvalue = source.components[cname][:script_parameters][pname] - if not srcvalue.nil? - component[:script_parameters][pname] = srcvalue + # Skip any components that are not present in the + # source instance (there's nothing to copy) + if source.components.include? cname + component[:script_parameters].each do |pname, val| + if val.is_a? Hash and val[:dataclass] + # this is user-inputtable, so check the value from the source pipeline + srcvalue = source.components[cname][:script_parameters][pname] + if not srcvalue.nil? + component[:script_parameters][pname] = srcvalue + end end end end @@ -33,7 +37,7 @@ class PipelineInstancesController < ApplicationController if params['script'] == 'use_same' # Go through each component and copy the script_version from each job. @object.components.each do |cname, component| - if source.components[cname][:job] + if source.components.include? cname and source.components[cname][:job] component[:script_version] = source.components[cname][:job][:script_version] end end @@ -43,6 +47,13 @@ class PipelineInstancesController < ApplicationController component.delete :job end @object.state = 'New' + + # set owner_uuid to that of source, provided it is a project and wriable by current user + current_project = Group.find(source.owner_uuid) rescue nil + if (current_project && current_project.writable_by.andand.include?(current_user.uuid)) + @object.owner_uuid = source.owner_uuid + end + super end