X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/707ed2964a24ebe940ae440af22fdcb56781fcbd..bac58f7cf76f347f4eeb5e2436412e5ccbdebf7f:/services/keepstore/trash_worker.go

diff --git a/services/keepstore/trash_worker.go b/services/keepstore/trash_worker.go
index cbb831ebc0..d7c73127eb 100644
--- a/services/keepstore/trash_worker.go
+++ b/services/keepstore/trash_worker.go
@@ -2,73 +2,69 @@
 //
 // SPDX-License-Identifier: AGPL-3.0
 
-package main
+package keepstore
 
 import (
 	"errors"
 	"time"
 
-	"git.curoverse.com/arvados.git/sdk/go/arvados"
+	"git.arvados.org/arvados.git/sdk/go/arvados"
+	"github.com/sirupsen/logrus"
 )
 
-// RunTrashWorker is used by Keepstore to initiate trash worker channel goroutine.
-//	The channel will process trash list.
-//		For each (next) trash request:
-//      Delete the block indicated by the trash request Locator
-//		Repeat
-//
-func RunTrashWorker(trashq *WorkQueue) {
+// RunTrashWorker processes the trash request queue.
+func RunTrashWorker(volmgr *RRVolumeManager, logger logrus.FieldLogger, cluster *arvados.Cluster, trashq *WorkQueue) {
 	for item := range trashq.NextItem {
 		trashRequest := item.(TrashRequest)
-		TrashItem(trashRequest)
+		TrashItem(volmgr, logger, cluster, trashRequest)
 		trashq.DoneItem <- struct{}{}
 	}
 }
 
 // TrashItem deletes the indicated block from every writable volume.
-func TrashItem(trashRequest TrashRequest) {
+func TrashItem(volmgr *RRVolumeManager, logger logrus.FieldLogger, cluster *arvados.Cluster, trashRequest TrashRequest) {
 	reqMtime := time.Unix(0, trashRequest.BlockMtime)
-	if time.Since(reqMtime) < theConfig.BlobSignatureTTL.Duration() {
-		log.Printf("WARNING: data manager asked to delete a %v old block %v (BlockMtime %d = %v), but my blobSignatureTTL is %v! Skipping.",
+	if time.Since(reqMtime) < cluster.Collections.BlobSigningTTL.Duration() {
+		logger.Warnf("client asked to delete a %v old block %v (BlockMtime %d = %v), but my blobSignatureTTL is %v! Skipping.",
 			arvados.Duration(time.Since(reqMtime)),
 			trashRequest.Locator,
 			trashRequest.BlockMtime,
 			reqMtime,
-			theConfig.BlobSignatureTTL)
+			cluster.Collections.BlobSigningTTL)
 		return
 	}
 
-	var volumes []Volume
+	var volumes []*VolumeMount
 	if uuid := trashRequest.MountUUID; uuid == "" {
-		volumes = KeepVM.AllWritable()
-	} else if v := KeepVM.Lookup(uuid, true); v == nil {
-		log.Printf("warning: trash request for nonexistent mount: %v", trashRequest)
+		volumes = volmgr.AllWritable()
+	} else if mnt := volmgr.Lookup(uuid, true); mnt == nil {
+		logger.Warnf("trash request for nonexistent mount: %v", trashRequest)
 		return
 	} else {
-		volumes = []Volume{v}
+		volumes = []*VolumeMount{mnt}
 	}
 
 	for _, volume := range volumes {
 		mtime, err := volume.Mtime(trashRequest.Locator)
 		if err != nil {
-			log.Printf("%v Delete(%v): %v", volume, trashRequest.Locator, err)
+			logger.WithError(err).Errorf("%v Trash(%v)", volume, trashRequest.Locator)
 			continue
 		}
 		if trashRequest.BlockMtime != mtime.UnixNano() {
-			log.Printf("%v Delete(%v): stored mtime %v does not match trash list value %v", volume, trashRequest.Locator, mtime.UnixNano(), trashRequest.BlockMtime)
+			logger.Infof("%v Trash(%v): stored mtime %v does not match trash list value %v; skipping", volume, trashRequest.Locator, mtime.UnixNano(), trashRequest.BlockMtime)
 			continue
 		}
 
-		if !theConfig.EnableDelete {
-			err = errors.New("did not delete block because EnableDelete is false")
+		if !cluster.Collections.BlobTrash {
+			err = errors.New("skipping because Collections.BlobTrash is false")
 		} else {
 			err = volume.Trash(trashRequest.Locator)
 		}
 
 		if err != nil {
-			log.Printf("%v Delete(%v): %v", volume, trashRequest.Locator, err)
+			logger.WithError(err).Errorf("%v Trash(%v)", volume, trashRequest.Locator)
 		} else {
-			log.Printf("%v Delete(%v) OK", volume, trashRequest.Locator)
+			logger.Infof("%v Trash(%v) OK", volume, trashRequest.Locator)
 		}
 	}
 }