X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/6d93d2ecf9c3d75c2b032f0ad9689af6501570e0..b0a3771f2110b691882226c559eab736ab9aa34d:/services/api/test/unit/collection_test.rb diff --git a/services/api/test/unit/collection_test.rb b/services/api/test/unit/collection_test.rb index 0783114990..d8b8365efa 100644 --- a/services/api/test/unit/collection_test.rb +++ b/services/api/test/unit/collection_test.rb @@ -92,28 +92,165 @@ class CollectionTest < ActiveSupport::TestCase [ ['foo', true], - ['foo bar', true], - ['foox barx', false], # no match for either - ['foo barx', true], - ['file4', true], # whole string match + ['foo bar', false], # no collection matching both + ['foo&bar', false], # no collection matching both + ['foo|bar', true], # works only no spaces between the words + ['Gnu public', true], # both prefixes found, though not consecutively + ['Gnu&public', true], # both prefixes found, though not consecutively + ['file4', true], # prefix match ['file4.txt', true], # whole string match - ['filex', false], # looks for the whole string and fails + ['filex', false], # no such prefix + ['subdir', true], # prefix matches ['subdir2', true], ['subdir2/', true], ['subdir2/subdir3', true], ['subdir2/subdir3/subdir4', true], - ['subdir', true], # prefix matches - ['no-such-file', false], # looks for whole string and fails - ['no such file', true], # matches "file" + ['subdir2 file4', true], # look for both prefixes + ['subdir4', false], # not a prefix match ].each do |search_filter, expect_results| - search_filters = search_filter.split.each {|s| s.concat(':*')} - results = Collection.where("to_tsvector('english', file_names) @@ to_tsquery(?)", - "#{search_filters.join('|')}") + search_filters = search_filter.split.each {|s| s.concat(':*')}.join('&') + results = Collection.where("#{Collection.full_text_tsvector} @@ to_tsquery(?)", + "#{search_filters}") if expect_results - assert_equal true, results.length>0, "No results found for '#{search_filter}'" + refute_empty results else - assert_equal 0, results.length, "Found #{results.length} results for '#{search_filter}'" + assert_empty results + end + end + end + + test 'portable data hash with missing size hints' do + [[". d41d8cd98f00b204e9800998ecf8427e+0+Bar 0:0:x", + ". d41d8cd98f00b204e9800998ecf8427e+0 0:0:x"], + [". d41d8cd98f00b204e9800998ecf8427e+Foo 0:0:x", + ". d41d8cd98f00b204e9800998ecf8427e 0:0:x"], + [". d41d8cd98f00b204e9800998ecf8427e 0:0:x", + ". d41d8cd98f00b204e9800998ecf8427e 0:0:x"], + ].each do |unportable, portable| + c = Collection.new(manifest_text: unportable) + assert c.valid? + assert_equal(Digest::MD5.hexdigest(portable)+"+#{portable.length}", + c.portable_data_hash) + end + end + + [0, 2, 4, nil].each do |ask| + test "set replication_desired to #{ask.inspect}" do + Rails.configuration.default_collection_replication = 2 + act_as_user users(:active) do + c = collections(:replication_undesired_unconfirmed) + c.update_attributes replication_desired: ask + assert_equal ask, c.replication_desired + end + end + end + + test "replication_confirmed* can be set by admin user" do + c = collections(:replication_desired_2_unconfirmed) + act_as_user users(:admin) do + assert c.update_attributes(replication_confirmed: 2, + replication_confirmed_at: Time.now) + end + end + + test "replication_confirmed* cannot be set by non-admin user" do + act_as_user users(:active) do + c = collections(:replication_desired_2_unconfirmed) + # Cannot set just one at a time. + assert_raise ArvadosModel::PermissionDeniedError do + c.update_attributes replication_confirmed: 1 + end + assert_raise ArvadosModel::PermissionDeniedError do + c.update_attributes replication_confirmed_at: Time.now + end + # Cannot set both at once, either. + assert_raise ArvadosModel::PermissionDeniedError do + c.update_attributes(replication_confirmed: 1, + replication_confirmed_at: Time.now) + end + end + end + + test "replication_confirmed* can be cleared (but only together) by non-admin user" do + act_as_user users(:active) do + c = collections(:replication_desired_2_confirmed_2) + # Cannot clear just one at a time. + assert_raise ArvadosModel::PermissionDeniedError do + c.update_attributes replication_confirmed: nil + end + c.reload + assert_raise ArvadosModel::PermissionDeniedError do + c.update_attributes replication_confirmed_at: nil end + # Can clear both at once. + c.reload + assert c.update_attributes(replication_confirmed: nil, + replication_confirmed_at: nil) + end + end + + test "clear replication_confirmed* when introducing a new block in manifest" do + c = collections(:replication_desired_2_confirmed_2) + act_as_user users(:active) do + assert c.update_attributes(manifest_text: collections(:user_agreement).signed_manifest_text) + assert_nil c.replication_confirmed + assert_nil c.replication_confirmed_at + end + end + + test "don't clear replication_confirmed* when just renaming a file" do + c = collections(:replication_desired_2_confirmed_2) + act_as_user users(:active) do + new_manifest = c.signed_manifest_text.sub(':bar', ':foo') + assert c.update_attributes(manifest_text: new_manifest) + assert_equal 2, c.replication_confirmed + assert_not_nil c.replication_confirmed_at + end + end + + test "don't clear replication_confirmed* when just deleting a data block" do + c = collections(:replication_desired_2_confirmed_2) + act_as_user users(:active) do + new_manifest = c.signed_manifest_text + new_manifest.sub!(/ \S+:bar/, '') + new_manifest.sub!(/ acbd\S+/, '') + + # Confirm that we did just remove a block from the manifest (if + # not, this test would pass without testing the relevant case): + assert_operator new_manifest.length+40, :<, c.signed_manifest_text.length + + assert c.update_attributes(manifest_text: new_manifest) + assert_equal 2, c.replication_confirmed + assert_not_nil c.replication_confirmed_at + end + end + + test "create collection with properties" do + act_as_system_user do + c = Collection.create(manifest_text: ". acbd18db4cc2f85cedef654fccc4a4d8+3 0:3:foo\n", + properties: {'property_1' => 'value_1'}) + assert c.valid? + assert_equal 'value_1', c.properties['property_1'] + end + end + + test 'create, delete, recreate collection with same name and owner' do + act_as_user users(:active) do + # create collection with name + c = Collection.create(manifest_text: '', + name: "test collection name") + assert c.valid? + uuid = c.uuid + + # mark collection as expired + c.update_attribute 'expires_at', Time.new.strftime("%Y-%m-%d") + c = Collection.where(uuid: uuid) + assert_empty c, 'Should not be able to find expired collection' + + # recreate collection with the same name + c = Collection.create(manifest_text: '', + name: "test collection name") + assert c.valid? end end end