X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/6d59f29ba37c608e4b01b27a2fa78bc065fdc2a6..27f5c1635d56c3f3cb6c5ef069c28db939eec2a1:/apps/workbench/app/controllers/application_controller.rb diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb index 412f86ce07..2fbd8c560f 100644 --- a/apps/workbench/app/controllers/application_controller.rb +++ b/apps/workbench/app/controllers/application_controller.rb @@ -1,12 +1,18 @@ class ApplicationController < ActionController::Base respond_to :html, :json, :js protect_from_forgery + + ERROR_ACTIONS = [:render_error, :render_not_found] + around_filter :thread_clear - around_filter :thread_with_mandatory_api_token, :except => [:render_exception, :render_not_found] + around_filter(:thread_with_mandatory_api_token, + except: [:index, :show] + ERROR_ACTIONS) around_filter :thread_with_optional_api_token - before_filter :find_object_by_uuid, :except => [:index, :render_exception, :render_not_found] - before_filter :check_user_agreements, :except => [:render_exception, :render_not_found] - before_filter :check_user_notifications, :except => [:render_exception, :render_not_found] + before_filter :check_user_agreements, except: ERROR_ACTIONS + before_filter :check_user_notifications, except: ERROR_ACTIONS + around_filter :using_reader_tokens, only: [:index, :show] + before_filter :find_object_by_uuid, except: [:index] + ERROR_ACTIONS + before_filter :check_my_folders, :except => ERROR_ACTIONS theme :select_theme begin @@ -30,6 +36,7 @@ class ApplicationController < ActionController::Base end def render_error(opts) + opts = {status: 500}.merge opts respond_to do |f| # json must come before html here, so it gets used as the # default format when js is requested by the client. This lets @@ -58,7 +65,27 @@ class ApplicationController < ActionController::Base end def index - @objects ||= model_class.limit(200).all + @limit ||= 200 + if params[:limit] + @limit = params[:limit].to_i + end + + @offset ||= 0 + if params[:offset] + @offset = params[:offset].to_i + end + + @filters ||= [] + if params[:filters] + filters = params[:filters] + if filters.is_a? String + filters = Oj.load filters + end + @filters += filters + end + + @objects ||= model_class + @objects = @objects.filter(@filters).limit(@limit).offset(@offset).all respond_to do |f| f.json { render json: @objects } f.html { render } @@ -71,7 +98,7 @@ class ApplicationController < ActionController::Base return render_not_found("object not found") end respond_to do |f| - f.json { render json: @object } + f.json { render json: @object.attributes.merge(href: url_for(@object)) } f.html { if request.method == 'GET' render @@ -96,8 +123,16 @@ class ApplicationController < ActionController::Base def update updates = params[@object.class.to_s.underscore.singularize.to_sym] updates.keys.each do |attr| - if @object.send(attr).is_a? Hash and updates[attr].is_a? String - updates[attr] = Oj.load updates[attr] + if @object.send(attr).is_a? Hash + if updates[attr].is_a? String + updates[attr] = Oj.load updates[attr] + end + if params[:merge] || params["merge_#{attr}".to_sym] + # Merge provided Hash with current Hash, instead of + # replacing. + updates[attr] = @object.send(attr).with_indifferent_access. + deep_merge(updates[attr].with_indifferent_access) + end end end if @object.update_attributes updates @@ -108,16 +143,12 @@ class ApplicationController < ActionController::Base end def create - @object ||= model_class.new params[model_class.to_s.underscore.singularize] + @new_resource_attrs ||= params[model_class.to_s.underscore.singularize] + @new_resource_attrs ||= {} + @new_resource_attrs.reject! { |k,v| k.to_s == 'uuid' } + @object ||= model_class.new @new_resource_attrs @object.save! - - respond_to do |f| - f.json { render json: @object } - f.html { - redirect_to(params[:return_to] || @object) - } - f.js { render } - end + show end def destroy @@ -149,7 +180,8 @@ class ApplicationController < ActionController::Base def breadcrumb_page_name (@breadcrumb_page_name || - (@object.friendly_link_name if @object.respond_to? :friendly_link_name)) + (@object.friendly_link_name if @object.respond_to? :friendly_link_name) || + action_name) end def index_pane_list @@ -161,13 +193,68 @@ class ApplicationController < ActionController::Base end protected - + + def redirect_to_login + respond_to do |f| + f.html { + if request.method == 'GET' + redirect_to $arvados_api_client.arvados_login_url(return_to: request.url) + else + flash[:error] = "Either you are not logged in, or your session has timed out. I can't automatically log you in and re-attempt this request." + redirect_to :back + end + } + f.json { + @errors = ['You do not seem to be logged in. You did not supply an API token with this request, and your session (if any) has timed out.'] + self.render_error status: 422 + } + end + false # For convenience to return from callbacks + end + + def using_reader_tokens(login_optional=false) + if params[:reader_tokens].is_a?(Array) and params[:reader_tokens].any? + Thread.current[:reader_tokens] = params[:reader_tokens] + end + begin + yield + rescue ArvadosApiClient::NotLoggedInException + if login_optional + raise + else + return redirect_to_login + end + ensure + Thread.current[:reader_tokens] = nil + end + end + + def using_specific_api_token(api_token) + start_values = {} + [:arvados_api_token, :user].each do |key| + start_values[key] = Thread.current[key] + end + Thread.current[:arvados_api_token] = api_token + Thread.current[:user] = nil + begin + yield + ensure + start_values.each_key { |key| Thread.current[key] = start_values[key] } + end + end + def find_object_by_uuid if params[:id] and params[:id].match /\D/ params[:uuid] = params.delete :id end - if params[:uuid].is_a? String - @object = model_class.find(params[:uuid]) + if not model_class + @object = nil + elsif params[:uuid].is_a? String + if params[:uuid].empty? + @object = nil + else + @object = model_class.find(params[:uuid]) + end else @object = model_class.where(uuid: params[:uuid]).first end @@ -220,20 +307,7 @@ class ApplicationController < ActionController::Base end if try_redirect_to_login unless login_optional - respond_to do |f| - f.html { - if request.method == 'GET' - redirect_to $arvados_api_client.arvados_login_url(return_to: request.url) - else - flash[:error] = "Either you are not logged in, or your session has timed out. I can't automatically log you in and re-attempt this request." - redirect_to :back - end - } - f.json { - @errors = ['You do not seem to be logged in. You did not supply an API token with this request, and your session (if any) has timed out.'] - self.render_error status: 422 - } - end + redirect_to_login else # login is optional for this route so go on to the regular controller Thread.current[:arvados_api_token] = nil @@ -259,7 +333,7 @@ class ApplicationController < ActionController::Base yield else # We skipped thread_with_mandatory_api_token. Use the optional version. - thread_with_api_token(true) do + thread_with_api_token(true) do yield end end @@ -312,7 +386,7 @@ class ApplicationController < ActionController::Base @@notification_tests = [] @@notification_tests.push lambda { |controller, current_user| - AuthorizedKey.limit(1).where(authorized_user_uuid: current_user.uuid).each do + AuthorizedKey.limit(1).where(authorized_user_uuid: current_user.uuid).each do return nil end return lambda { |view| @@ -320,14 +394,14 @@ class ApplicationController < ActionController::Base } } - @@notification_tests.push lambda { |controller, current_user| - Job.limit(1).where(created_by: current_user.uuid).each do - return nil - end - return lambda { |view| - view.render partial: 'notifications/jobs_notification' - } - } + #@@notification_tests.push lambda { |controller, current_user| + # Job.limit(1).where(created_by: current_user.uuid).each do + # return nil + # end + # return lambda { |view| + # view.render partial: 'notifications/jobs_notification' + # } + #} @@notification_tests.push lambda { |controller, current_user| Collection.limit(1).where(created_by: current_user.uuid).each do @@ -347,12 +421,21 @@ class ApplicationController < ActionController::Base } } + def check_my_folders + @my_top_level_folders = lambda do + @top_level_folders ||= Group. + filter([['group_class','=','folder'], + ['owner_uuid','=',current_user.uuid]]). + sort_by { |x| x.name || '' } + end + end + def check_user_notifications @notification_count = 0 @notifications = [] if current_user - @showallalerts = false + @showallalerts = false @@notification_tests.each do |t| a = t.call(self, current_user) if a