X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/6bf9e1a4b5640f3cdd057810f0c9b8a945bb88bd..fb96637bf76fe8779e7a7e58f052b8f55ed76f4f:/lib/controller/handler.go diff --git a/lib/controller/handler.go b/lib/controller/handler.go index 25bba558dc..b51d909110 100644 --- a/lib/controller/handler.go +++ b/lib/controller/handler.go @@ -9,6 +9,7 @@ import ( "errors" "fmt" "net/http" + "net/http/httptest" "net/url" "strings" "sync" @@ -25,6 +26,8 @@ import ( "git.arvados.org/arvados.git/sdk/go/health" "git.arvados.org/arvados.git/sdk/go/httpserver" "github.com/jmoiron/sqlx" + + // sqlx needs lib/pq to talk to PostgreSQL _ "github.com/lib/pq" ) @@ -72,7 +75,21 @@ func (h *Handler) CheckHealth() error { return err } _, _, err = railsproxy.FindRailsAPI(h.Cluster) - return err + if err != nil { + return err + } + if h.Cluster.API.VocabularyPath != "" { + req, err := http.NewRequest("GET", "/arvados/v1/vocabulary", nil) + if err != nil { + return err + } + var resp httptest.ResponseRecorder + h.handlerStack.ServeHTTP(&resp, req) + if resp.Result().StatusCode != http.StatusOK { + return fmt.Errorf("%d %s", resp.Result().StatusCode, resp.Result().Status) + } + } + return nil } func (h *Handler) Done() <-chan struct{} { @@ -83,25 +100,39 @@ func neverRedirect(*http.Request, []*http.Request) error { return http.ErrUseLas func (h *Handler) setup() { mux := http.NewServeMux() + healthFuncs := make(map[string]health.Func) + + oidcAuthorizer := localdb.OIDCAccessTokenAuthorizer(h.Cluster, h.db) + rtr := router.New(federation.New(h.Cluster, &healthFuncs), router.Config{ + MaxRequestSize: h.Cluster.API.MaxRequestSize, + WrapCalls: api.ComposeWrappers(ctrlctx.WrapCallsInTransactions(h.db), oidcAuthorizer.WrapCalls), + }) + + healthRoutes := health.Routes{"ping": func() error { _, err := h.db(context.TODO()); return err }} + for name, f := range healthFuncs { + healthRoutes[name] = f + } mux.Handle("/_health/", &health.Handler{ Token: h.Cluster.ManagementToken, Prefix: "/_health/", - Routes: health.Routes{"ping": func() error { _, err := h.db(context.TODO()); return err }}, + Routes: healthRoutes, }) - - oidcAuthorizer := localdb.OIDCAccessTokenAuthorizer(h.Cluster, h.db) - rtr := router.New(federation.New(h.Cluster), api.ComposeWrappers(ctrlctx.WrapCallsInTransactions(h.db), oidcAuthorizer.WrapCalls)) mux.Handle("/arvados/v1/config", rtr) - mux.Handle("/"+arvados.EndpointUserAuthenticate.Path, rtr) - - if !h.Cluster.ForceLegacyAPI14 { - mux.Handle("/arvados/v1/collections", rtr) - mux.Handle("/arvados/v1/collections/", rtr) - mux.Handle("/arvados/v1/users", rtr) - mux.Handle("/arvados/v1/users/", rtr) - mux.Handle("/login", rtr) - mux.Handle("/logout", rtr) - } + mux.Handle("/arvados/v1/vocabulary", rtr) + mux.Handle("/"+arvados.EndpointUserAuthenticate.Path, rtr) // must come before .../users/ + mux.Handle("/arvados/v1/collections", rtr) + mux.Handle("/arvados/v1/collections/", rtr) + mux.Handle("/arvados/v1/users", rtr) + mux.Handle("/arvados/v1/users/", rtr) + mux.Handle("/arvados/v1/connect/", rtr) + mux.Handle("/arvados/v1/container_requests", rtr) + mux.Handle("/arvados/v1/container_requests/", rtr) + mux.Handle("/arvados/v1/groups", rtr) + mux.Handle("/arvados/v1/groups/", rtr) + mux.Handle("/arvados/v1/links", rtr) + mux.Handle("/arvados/v1/links/", rtr) + mux.Handle("/login", rtr) + mux.Handle("/logout", rtr) hs := http.NotFoundHandler() hs = prepend(hs, h.proxyRailsAPI)