X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/68b9c7d30c7f47f8a9f9cff8a327fa9a3812d4da..1f0da8d97cfb16e478d5dfed896e86112eb82120:/services/api/app/models/container.rb diff --git a/services/api/app/models/container.rb b/services/api/app/models/container.rb index af058494b2..08f87bbdb1 100644 --- a/services/api/app/models/container.rb +++ b/services/api/app/models/container.rb @@ -22,7 +22,8 @@ class Container < ArvadosModel attribute :secret_mounts, :jsonbHash, default: {} attribute :runtime_status, :jsonbHash, default: {} attribute :runtime_auth_scopes, :jsonbArray, default: [] - attribute :output_storage_classes, :jsonbArray, default: ["default"] + attribute :output_storage_classes, :jsonbArray, default: lambda { Rails.configuration.DefaultStorageClasses } + attribute :output_properties, :jsonbHash, default: {} serialize :environment, Hash serialize :mounts, Hash @@ -81,6 +82,7 @@ class Container < ArvadosModel t.add :gateway_address t.add :interactive_session_started t.add :output_storage_classes + t.add :output_properties end # Supported states for a container @@ -289,7 +291,21 @@ class Container < ArvadosModel candidates = candidates.where('secret_mounts_md5 = ?', secret_mounts_md5) log_reuse_info(candidates) { "after filtering on secret_mounts_md5 #{secret_mounts_md5.inspect}" } - candidates = candidates.where_serialized(:runtime_constraints, resolve_runtime_constraints(attrs[:runtime_constraints]), md5: true) + if attrs[:runtime_constraints]['cuda'].nil? + attrs[:runtime_constraints]['cuda'] = { + 'device_count' => 0, + 'driver_version' => '', + 'hardware_capability' => '', + } + end + resolved_runtime_constraints = [resolve_runtime_constraints(attrs[:runtime_constraints])] + if resolved_runtime_constraints[0]['cuda']['device_count'] == 0 + # If no CUDA requested, extend search to include older container + # records that don't have a 'cuda' section in runtime_constraints + resolved_runtime_constraints << resolved_runtime_constraints[0].except('cuda') + end + + candidates = candidates.where_serialized(:runtime_constraints, resolved_runtime_constraints, md5: true, multivalue: true) log_reuse_info(candidates) { "after filtering on runtime_constraints #{attrs[:runtime_constraints].inspect}" } log_reuse_info { "checking for state=Complete with readable output and log..." } @@ -462,8 +478,8 @@ class Container < ArvadosModel def validate_change permitted = [:state] - progress_attrs = [:progress, :runtime_status, :log, :output] - final_attrs = [:exit_code, :finished_at] + progress_attrs = [:progress, :runtime_status, :log, :output, :output_properties, :exit_code] + final_attrs = [:finished_at] if self.new_record? permitted.push(:owner_uuid, :command, :container_image, :cwd, @@ -482,7 +498,7 @@ class Container < ArvadosModel permitted.push :priority when Running - permitted.push :priority, *progress_attrs + permitted.push :priority, :output_properties, *progress_attrs if self.state_changed? permitted.push :started_at, :gateway_address end