X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/67f0d86c20139eee996816d44ef75fa52288c515..9bf790498c20c9f8ab9bffbf9c8e5311864bd91e:/apps/workbench/test/integration/collections_test.rb diff --git a/apps/workbench/test/integration/collections_test.rb b/apps/workbench/test/integration/collections_test.rb index 2eee6fe8db..8b43e5dbe3 100644 --- a/apps/workbench/test/integration/collections_test.rb +++ b/apps/workbench/test/integration/collections_test.rb @@ -20,17 +20,6 @@ class CollectionsTest < ActionDispatch::IntegrationTest assert_text "Copy of #{collection_name}" end - test "Collection page renders name" do - Capybara.current_driver = :rack_test - uuid = api_fixture('collections')['foo_file']['uuid'] - coll_name = api_fixture('collections')['foo_file']['name'] - visit page_with_token('active', "/collections/#{uuid}") - assert(page.has_text?(coll_name), "Collection page did not include name") - # Now check that the page is otherwise normal, and the collection name - # isn't only showing up in an error message. - assert(page.has_link?('foo'), "Collection page did not include file link") - end - def check_sharing(want_state, link_regexp) # We specifically want to click buttons. See #4291. if want_state == :off @@ -42,7 +31,7 @@ class CollectionsTest < ActionDispatch::IntegrationTest text_assertion = :assert_text link_assertion = :refute_empty end - using_wait_time(Capybara.default_wait_time * 3) do + using_wait_time(Capybara.default_max_wait_time * 3) do send(text_assertion, "Shared at:") end send(link_assertion, all("a").select { |a| a[:href] =~ link_regexp }) @@ -91,13 +80,6 @@ class CollectionsTest < ActionDispatch::IntegrationTest end end - test "can view empty collection" do - Capybara.current_driver = :rack_test - uuid = 'd41d8cd98f00b204e9800998ecf8427e+0' - visit page_with_token('active', "/collections/#{uuid}") - assert page.has_text?(/This collection is empty|The following collections have this content/) - end - test "combine selected collections into new collection" do foo_collection = api_fixture('collections')['foo_file'] bar_collection = api_fixture('collections')['bar_file'] @@ -191,33 +173,6 @@ class CollectionsTest < ActionDispatch::IntegrationTest assert(page.has_text?('file2_in_subdir4.txt'), 'file not found - file1_in_subdir4.txt') end - test "Collection portable data hash redirect" do - di = api_fixture('collections')['docker_image'] - visit page_with_token('active', "/collections/#{di['portable_data_hash']}") - - # check redirection - assert current_path.end_with?("/collections/#{di['uuid']}") - assert page.has_text?("docker_image") - assert page.has_text?("Activity") - assert page.has_text?("Sharing and permissions") - end - - test "Collection portable data hash with multiple matches" do - pdh = api_fixture('collections')['foo_file']['portable_data_hash'] - visit page_with_token('admin', "/collections/#{pdh}") - - matches = api_fixture('collections').select {|k,v| v["portable_data_hash"] == pdh} - assert matches.size > 1 - - matches.each do |k,v| - assert page.has_link?(v["name"]), "Page /collections/#{pdh} should contain link '#{v['name']}'" - end - assert_text 'The following collections have this content:' - assert_no_text 'more results are not shown' - assert_no_text 'Activity' - assert_no_text 'Sharing and permissions' - end - test "Collection portable data hash with multiple matches with more than one page of results" do pdh = api_fixture('collections')['baz_file']['portable_data_hash'] visit page_with_token('admin', "/collections/#{pdh}") @@ -343,4 +298,126 @@ class CollectionsTest < ActionDispatch::IntegrationTest # Make sure we're not still on the old collection page. refute_match(%r{/collections/#{col['uuid']}}, page.current_url) end + + test "remove a file from collection using checkbox and dropdown option" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + assert(page.has_text?('file1'), 'file not found - file1') + + unlock_collection + + # remove first file + input_files = page.all('input[type=checkbox]') + input_files[0].click + + click_button 'Selection...' + within('.selection-action-container') do + click_link 'Remove selected files' + end + + assert(page.has_no_text?('file1'), 'file found - file') + assert(page.has_text?('file2'), 'file not found - file2') + end + + test "remove a file in collection using trash icon" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + assert(page.has_text?('file1'), 'file not found - file1') + + unlock_collection + + first('.fa-trash-o').click + accept_alert + + assert(page.has_no_text?('file1'), 'file found - file') + assert(page.has_text?('file2'), 'file not found - file2') + end + + test "rename a file in collection" do + need_selenium 'to confirm unlock' + + visit page_with_token('active', '/collections/zzzzz-4zz18-a21ux3541sxa8sf') + + unlock_collection + + within('.collection_files') do + first('.fa-pencil').click + find('.editable-input input').set('file1renamed') + find('.editable-submit').click + end + + assert(page.has_text?('file1renamed'), 'file not found - file1renamed') + end + + test "remove/rename file options not presented if user cannot update a collection" do + # visit a publicly accessible collection as 'spectator' + visit page_with_token('spectator', '/collections/zzzzz-4zz18-uukreo9rbgwsujr') + + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li', text: 'Create new collection with selected files' + assert_no_selector 'li', text: 'Remove selected files' + end + + within('.collection_files') do + assert(page.has_text?('GNU_General_Public_License'), 'file not found - GNU_General_Public_License') + assert_nil first('.fa-pencil') + assert_nil first('.fa-trash-o') + end + end + + test "unlock collection to modify files" do + need_selenium 'to confirm remove' + + collection = api_fixture('collections')['collection_owned_by_active'] + + # On load, collection is locked, and upload tab, rename and remove options are disabled + visit page_with_token('active', "/collections/#{collection['uuid']}") + + assert_selector 'a[data-toggle="disabled"]', text: 'Upload' + + within('.collection_files') do + file_ctrls = page.all('.btn-collection-file-control') + assert_equal 2, file_ctrls.size + assert_equal true, file_ctrls[0]['class'].include?('disabled') + assert_equal true, file_ctrls[1]['class'].include?('disabled') + find('input[type=checkbox]').click + end + + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Remove selected files' + assert_selector 'li', text: 'Create new collection with selected files' + end + + unlock_collection + + assert_no_selector 'a[data-toggle="disabled"]', text: 'Upload' + assert_selector 'a', text: 'Upload' + + within('.collection_files') do + file_ctrls = page.all('.btn-collection-file-control') + assert_equal 2, file_ctrls.size + assert_equal false, file_ctrls[0]['class'].include?('disabled') + assert_equal false, file_ctrls[1]['class'].include?('disabled') + + # previous checkbox selection won't result in firing a new event; + # undo and redo checkbox to fire the selection event again + find('input[type=checkbox]').click + find('input[type=checkbox]').click + end + + click_button 'Selection' + within('.selection-action-container') do + assert_no_selector 'li.disabled', text: 'Remove selected files' + assert_selector 'li', text: 'Remove selected files' + end + end + + def unlock_collection + first('.lock-collection-btn').click + accept_alert + end end