X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/679eef491b59a4c38a0b2914ff85e0a8c5059b2c..682dd5b6cc23a455766a7651e3e841257660b31c:/sdk/python/arvados/collection.py diff --git a/sdk/python/arvados/collection.py b/sdk/python/arvados/collection.py index 11eb666478..89cbda937c 100644 --- a/sdk/python/arvados/collection.py +++ b/sdk/python/arvados/collection.py @@ -488,6 +488,7 @@ class RichCollectionBase(CollectionBase): def __init__(self, parent=None): self.parent = parent self._modified = True + self._callback = None self._items = {} def _my_api(self): @@ -537,9 +538,9 @@ class RichCollectionBase(CollectionBase): if item is None: # create new file if create_type == COLLECTION: - item = Subcollection(self) + item = Subcollection(self, pathcomponents[0]) else: - item = ArvadosFile(self) + item = ArvadosFile(self, pathcomponents[0]) self._items[pathcomponents[0]] = item self._modified = True self.notify(ADD, self, pathcomponents[0], item) @@ -547,14 +548,14 @@ class RichCollectionBase(CollectionBase): else: if item is None: # create new collection - item = Subcollection(self) + item = Subcollection(self, pathcomponents[0]) self._items[pathcomponents[0]] = item self._modified = True self.notify(ADD, self, pathcomponents[0], item) if isinstance(item, RichCollectionBase): return item.find_or_create(pathcomponents[1], create_type) else: - raise IOError((errno.ENOTDIR, "Interior path components must be subcollection")) + raise IOError(errno.ENOTDIR, "Interior path components must be subcollection") else: return self @@ -580,9 +581,9 @@ class RichCollectionBase(CollectionBase): else: return item else: - raise IOError((errno.ENOTDIR, "Interior path components must be subcollection")) + raise IOError(errno.ENOTDIR, "Interior path components must be subcollection") - def mkdirs(path): + def mkdirs(self, path): """Recursive subcollection create. Like `os.mkdirs()`. Will create intermediate subcollections needed to @@ -615,7 +616,7 @@ class RichCollectionBase(CollectionBase): create = (mode != "r") if create and not self.writable(): - raise IOError((errno.EROFS, "Collection is read only")) + raise IOError(errno.EROFS, "Collection is read only") if create: arvfile = self.find_or_create(path, FILE) @@ -623,9 +624,9 @@ class RichCollectionBase(CollectionBase): arvfile = self.find(path) if arvfile is None: - raise IOError((errno.ENOENT, "File not found")) + raise IOError(errno.ENOENT, "File not found") if not isinstance(arvfile, ArvadosFile): - raise IOError((errno.EISDIR, "Path must refer to a file.")) + raise IOError(errno.EISDIR, "Path must refer to a file.") if mode[0] == "w": arvfile.truncate(0) @@ -633,9 +634,9 @@ class RichCollectionBase(CollectionBase): name = os.path.basename(path) if mode == "r": - return ArvadosFileReader(arvfile, name, mode, num_retries=self.num_retries) + return ArvadosFileReader(arvfile, mode, num_retries=self.num_retries) else: - return ArvadosFileWriter(arvfile, name, mode, num_retries=self.num_retries) + return ArvadosFileWriter(arvfile, mode, num_retries=self.num_retries) @synchronized def modified(self): @@ -720,10 +721,10 @@ class RichCollectionBase(CollectionBase): pathcomponents = path.split("/", 1) item = self._items.get(pathcomponents[0]) if item is None: - raise IOError((errno.ENOENT, "File not found")) + raise IOError(errno.ENOENT, "File not found") if len(pathcomponents) == 1: if isinstance(self._items[pathcomponents[0]], RichCollectionBase) and len(self._items[pathcomponents[0]]) > 0 and not recursive: - raise IOError((errno.ENOTEMPTY, "Subcollection not empty")) + raise IOError(errno.ENOTEMPTY, "Subcollection not empty") deleteditem = self._items[pathcomponents[0]] del self._items[pathcomponents[0]] self._modified = True @@ -733,15 +734,15 @@ class RichCollectionBase(CollectionBase): def _clonefrom(self, source): for k,v in source.items(): - self._items[k] = v.clone(self) + self._items[k] = v.clone(self, k) def clone(self): raise NotImplementedError() @must_be_writable @synchronized - def add(self, source_obj, target_name, overwrite=False): - """Copy a file or subcollection to this collection. + def add(self, source_obj, target_name, overwrite=False, reparent=False): + """Copy or move a file or subcollection to this collection. :source_obj: An ArvadosFile, or Subcollection object @@ -753,24 +754,74 @@ class RichCollectionBase(CollectionBase): :overwrite: Whether to overwrite target file if it already exists. + :reparent: + If True, source_obj will be moved from its parent collection to this collection. + If False, source_obj will be copied and the parent collection will be + unmodified. + """ if target_name in self and not overwrite: - raise IOError((errno.EEXIST, "File already exists")) + raise IOError(errno.EEXIST, "File already exists") modified_from = None if target_name in self: modified_from = self[target_name] - # Actually make the copy. - dup = source_obj.clone(self) - self._items[target_name] = dup + # Actually make the move or copy. + if reparent: + source_obj.reparent(self, target_name) + item = source_obj + else: + item = source_obj.clone(self, target_name) + + self._items[target_name] = item self._modified = True if modified_from: - self.notify(MOD, self, target_name, (modified_from, dup)) + self.notify(MOD, self, target_name, (modified_from, item)) + else: + self.notify(ADD, self, target_name, item) + + def _get_src_target(self, source, target_path, source_collection, create_dest): + if source_collection is None: + source_collection = self + + # Find the object + if isinstance(source, basestring): + source_obj = source_collection.find(source) + if source_obj is None: + raise IOError(errno.ENOENT, "File not found") + sourcecomponents = source.split("/") + else: + source_obj = source + sourcecomponents = None + + # Find parent collection the target path + targetcomponents = target_path.split("/") + + # Determine the name to use. + target_name = targetcomponents[-1] if targetcomponents[-1] else sourcecomponents[-1] + + if not target_name: + raise errors.ArgumentError("Target path is empty and source is an object. Cannot determine destination filename to use.") + + if create_dest: + target_dir = self.find_or_create("/".join(targetcomponents[0:-1]), COLLECTION) else: - self.notify(ADD, self, target_name, dup) + if len(targetcomponents) > 1: + target_dir = self.find("/".join(targetcomponents[0:-1])) + else: + target_dir = self + + if target_dir is None: + raise IOError(errno.ENOENT, "Target directory not found.") + + if target_name in target_dir and isinstance(self[target_name], RichCollectionBase) and sourcecomponents: + target_dir = target_dir[target_name] + target_name = sourcecomponents[-1] + + return (source_obj, target_dir, target_name) @must_be_writable @synchronized @@ -792,35 +843,35 @@ class RichCollectionBase(CollectionBase): :overwrite: Whether to overwrite target file if it already exists. """ - if source_collection is None: - source_collection = self - # Find the object to copy - if isinstance(source, basestring): - source_obj = source_collection.find(source) - if source_obj is None: - raise IOError((errno.ENOENT, "File not found")) - sourcecomponents = source.split("/") - else: - source_obj = source - sourcecomponents = None + source_obj, target_dir, target_name = self._get_src_target(source, target_path, source_collection, True) + target_dir.add(source_obj, target_name, overwrite, False) - # Find parent collection the target path - targetcomponents = target_path.split("/") + @must_be_writable + @synchronized + def rename(self, source, target_path, source_collection=None, overwrite=False): + """Move a file or subcollection from `source_collection` to a new path in this collection. - # Determine the name to use. - target_name = targetcomponents[-1] if targetcomponents[-1] else (sourcecomponents[-1] if sourcecomponents else None) + :source: + A string with a path to source file or subcollection. - if not target_name: - raise errors.ArgumentError("Target path is empty and source is an object. Cannot determine destination filename to use.") + :target_path: + Destination file or path. If the target path already exists and is a + subcollection, the item will be placed inside the subcollection. If + the target path already exists and is a file, this will raise an error + unless you specify `overwrite=True`. - target_dir = self.find_or_create("/".join(targetcomponents[0:-1]), COLLECTION) + :source_collection: + Collection to copy `source_path` from (default `self`) - if target_name in target_dir and isinstance(self[target_name], RichCollectionBase) and sourcecomponents: - target_dir = target_dir[target_name] - target_name = sourcecomponents[-1] + :overwrite: + Whether to overwrite target file if it already exists. + """ - target_dir.add(source_obj, target_name, overwrite) + source_obj, target_dir, target_name = self._get_src_target(source, target_path, source_collection, False) + if not source_obj.writable(): + raise IOError(errno.EROFS, "Source collection must be writable.") + target_dir.add(source_obj, target_name, overwrite, True) def portable_manifest_text(self, stream_name="."): """Get the manifest text for this collection, sub collections and files. @@ -917,15 +968,15 @@ class RichCollectionBase(CollectionBase): holding_collection = Collection(api_client=self._my_api(), keep_client=self._my_keep()) for k in self: if k not in end_collection: - changes.append((DEL, os.path.join(prefix, k), self[k].clone(holding_collection))) + changes.append((DEL, os.path.join(prefix, k), self[k].clone(holding_collection, ""))) for k in end_collection: if k in self: if isinstance(end_collection[k], Subcollection) and isinstance(self[k], Subcollection): changes.extend(self[k].diff(end_collection[k], os.path.join(prefix, k), holding_collection)) elif end_collection[k] != self[k]: - changes.append((MOD, os.path.join(prefix, k), self[k].clone(holding_collection), end_collection[k].clone(holding_collection))) + changes.append((MOD, os.path.join(prefix, k), self[k].clone(holding_collection, ""), end_collection[k].clone(holding_collection, ""))) else: - changes.append((ADD, os.path.join(prefix, k), end_collection[k].clone(holding_collection))) + changes.append((ADD, os.path.join(prefix, k), end_collection[k].clone(holding_collection, ""))) return changes @must_be_writable @@ -980,6 +1031,24 @@ class RichCollectionBase(CollectionBase): stripped = self.portable_manifest_text() return hashlib.md5(stripped).hexdigest() + '+' + str(len(stripped)) + @synchronized + def subscribe(self, callback): + if self._callback is None: + self._callback = callback + else: + raise errors.ArgumentError("A callback is already set on this collection.") + + @synchronized + def unsubscribe(self): + if self._callback is not None: + self._callback = None + + @synchronized + def notify(self, event, collection, name, item): + if self._callback: + self._callback(event, collection, name, item) + self.root_collection().notify(event, collection, name, item) + @synchronized def __eq__(self, other): if other is self: @@ -1082,7 +1151,6 @@ class Collection(RichCollectionBase): self._api_response = None self.lock = threading.RLock() - self.callbacks = [] self.events = None if manifest_locator_or_text: @@ -1215,7 +1283,7 @@ class Collection(RichCollectionBase): def __exit__(self, exc_type, exc_value, traceback): """Support scoped auto-commit in a with: block.""" - if exc_type is not None: + if exc_type is None: if self.writable() and self._has_collection_uuid(): self.save() if self._block_manager is not None: @@ -1236,7 +1304,7 @@ class Collection(RichCollectionBase): return self._manifest_locator @synchronized - def clone(self, new_parent=None, readonly=False, new_config=None): + def clone(self, new_parent=None, new_name=None, readonly=False, new_config=None): if new_config is None: new_config = self._config if readonly: @@ -1362,6 +1430,7 @@ class Collection(RichCollectionBase): if create_collection_record: if name is None: name = "Collection created %s" % (time.strftime("%Y-%m-%d %H:%M:%S %Z", time.localtime())) + ensure_unique_name = True body = {"manifest_text": text, "name": name} @@ -1378,19 +1447,6 @@ class Collection(RichCollectionBase): return text - @synchronized - def subscribe(self, callback): - self.callbacks.append(callback) - - @synchronized - def unsubscribe(self, callback): - self.callbacks.remove(callback) - - @synchronized - def notify(self, event, collection, name, item): - for c in self.callbacks: - c(event, collection, name, item) - @synchronized def _import_manifest(self, manifest_text): """Import a manifest into a `Collection`. @@ -1420,13 +1476,14 @@ class Collection(RichCollectionBase): segments = [] streamoffset = 0L state = BLOCKS + self.mkdirs(stream_name) continue if state == BLOCKS: block_locator = re.match(r'[0-9a-f]{32}\+(\d+)(\+\S+)*', tok) if block_locator: blocksize = long(block_locator.group(1)) - blocks.append(Range(tok, streamoffset, blocksize)) + blocks.append(Range(tok, streamoffset, blocksize, 0)) streamoffset += blocksize else: state = SEGMENTS @@ -1453,6 +1510,11 @@ class Collection(RichCollectionBase): self.set_unmodified() + @synchronized + def notify(self, event, collection, name, item): + if self._callback: + self._callback(event, collection, name, item) + class Subcollection(RichCollectionBase): """This is a subdirectory within a collection that doesn't have its own API @@ -1462,10 +1524,12 @@ class Subcollection(RichCollectionBase): """ - def __init__(self, parent): + def __init__(self, parent, name): super(Subcollection, self).__init__(parent) self.lock = self.root_collection().lock self._manifest_text = None + self.name = name + self.num_retries = parent.num_retries def root_collection(self): return self.parent.root_collection() @@ -1482,18 +1546,12 @@ class Subcollection(RichCollectionBase): def _my_block_manager(self): return self.root_collection()._my_block_manager() - def notify(self, event, collection, name, item): - return self.root_collection().notify(event, collection, name, item) - def stream_name(self): - for k, v in self.parent.items(): - if v is self: - return os.path.join(self.parent.stream_name(), k) - return '.' + return os.path.join(self.parent.stream_name(), self.name) @synchronized - def clone(self, new_parent): - c = Subcollection(new_parent) + def clone(self, new_parent, new_name): + c = Subcollection(new_parent, new_name) c._clonefrom(self) return c