X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/5bcba288077488791daa43a15d5fd5fb0c6e653c..13288c69988380210150124d7991af6ca6e3d62b:/services/nodemanager/tests/test_computenode_driver_ec2.py diff --git a/services/nodemanager/tests/test_computenode_driver_ec2.py b/services/nodemanager/tests/test_computenode_driver_ec2.py index fae63a5663..297eac0ef3 100644 --- a/services/nodemanager/tests/test_computenode_driver_ec2.py +++ b/services/nodemanager/tests/test_computenode_driver_ec2.py @@ -1,4 +1,7 @@ #!/usr/bin/env python +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 from __future__ import absolute_import, print_function @@ -12,15 +15,8 @@ import mock import arvnodeman.computenode.driver.ec2 as ec2 from . import testutil -class EC2ComputeNodeDriverTestCase(unittest.TestCase): - def setUp(self): - self.driver_mock = mock.MagicMock(name='driver_mock') - - def new_driver(self, auth_kwargs={}, list_kwargs={}, create_kwargs={}): - create_kwargs.setdefault('ping_host', '100::') - return ec2.ComputeNodeDriver( - auth_kwargs, list_kwargs, create_kwargs, - driver_class=self.driver_mock) +class EC2ComputeNodeDriverTestCase(testutil.DriverTestMixin, unittest.TestCase): + TEST_CLASS = ec2.ComputeNodeDriver def test_driver_instantiation(self): kwargs = {'key': 'testkey'} @@ -37,15 +33,12 @@ class EC2ComputeNodeDriverTestCase(unittest.TestCase): self.assertEqual({'tag:test': 'true'}, list_method.call_args[1].get('ex_filters')) - def test_create_location_loaded_at_initialization(self): - kwargs = {'location': 'testregion'} - driver = self.new_driver(create_kwargs=kwargs) - self.assertTrue(self.driver_mock().list_locations) - def test_create_image_loaded_at_initialization(self): - kwargs = {'image': 'testimage'} - driver = self.new_driver(create_kwargs=kwargs) - self.assertTrue(self.driver_mock().list_images) + list_method = self.driver_mock().list_images + list_method.return_value = [testutil.cloud_object_mock(c) + for c in 'abc'] + driver = self.new_driver(create_kwargs={'image_id': 'id_b'}) + self.assertEqual(1, list_method.call_count) def test_create_includes_ping_secret(self): arv_node = testutil.arvados_node_mock(info={'ping_secret': 'ssshh'}) @@ -57,17 +50,28 @@ class EC2ComputeNodeDriverTestCase(unittest.TestCase): create_method.call_args[1].get('ex_userdata', 'arg missing')) + def test_create_includes_metadata(self): + arv_node = testutil.arvados_node_mock() + driver = self.new_driver(list_kwargs={'tag_test': 'testvalue'}) + driver.create_node(testutil.MockSize(1), arv_node) + create_method = self.driver_mock().create_node + self.assertTrue(create_method.called) + self.assertEqual( + {'test':'testvalue'}, + create_method.call_args[1].get('ex_metadata', {'arg': 'missing'}) + ) + def test_hostname_from_arvados_node(self): arv_node = testutil.arvados_node_mock(8) driver = self.new_driver() self.assertEqual('compute8.zzzzz.arvadosapi.com', - driver.arvados_create_kwargs(arv_node)['name']) + driver.arvados_create_kwargs(testutil.MockSize(1), arv_node)['name']) def test_default_hostname_from_new_arvados_node(self): arv_node = testutil.arvados_node_mock(hostname=None) driver = self.new_driver() self.assertEqual('dynamic.compute.zzzzz.arvadosapi.com', - driver.arvados_create_kwargs(arv_node)['name']) + driver.arvados_create_kwargs(testutil.MockSize(1), arv_node)['name']) def check_node_tagged(self, cloud_node, expected_tags): tag_mock = self.driver_mock().ex_create_tags @@ -75,16 +79,6 @@ class EC2ComputeNodeDriverTestCase(unittest.TestCase): self.assertIs(cloud_node, tag_mock.call_args[0][0]) self.assertEqual(expected_tags, tag_mock.call_args[0][1]) - def test_post_create_node_tags_from_list_kwargs(self): - expect_tags = {'key1': 'test value 1', 'key2': 'test value 2'} - list_kwargs = {('tag_' + key): value - for key, value in expect_tags.iteritems()} - list_kwargs['instance-state-name'] = 'running' - cloud_node = testutil.cloud_node_mock() - driver = self.new_driver(list_kwargs=list_kwargs) - driver.post_create_node(cloud_node) - self.check_node_tagged(cloud_node, expect_tags) - def test_sync_node(self): arv_node = testutil.arvados_node_mock(1) cloud_node = testutil.cloud_node_mock(2) @@ -101,15 +95,58 @@ class EC2ComputeNodeDriverTestCase(unittest.TestCase): reftuple)} self.assertEqual(refsecs, ec2.ComputeNodeDriver.node_start_time(node)) - def test_cloud_exceptions(self): - for error in [Exception("test exception"), - IOError("test exception"), - ssl.SSLError("test exception"), - cloud_types.LibcloudError("test exception")]: - self.assertTrue(ec2.ComputeNodeDriver.is_cloud_exception(error), - "{} not flagged as cloud exception".format(error)) - - def test_noncloud_exceptions(self): - self.assertFalse( - ec2.ComputeNodeDriver.is_cloud_exception(ValueError("test error")), - "ValueError flagged as cloud exception") + def test_node_fqdn(self): + name = 'fqdntest.zzzzz.arvadosapi.com' + node = testutil.cloud_node_mock() + node.name = name + self.assertEqual(name, ec2.ComputeNodeDriver.node_fqdn(node)) + + def test_create_ebs_volume(self): + arv_node = testutil.arvados_node_mock() + driver = self.new_driver() + # libcloud/ec2 "disk" sizes are in GB, Arvados/SLURM "scratch" value is in MB + size = testutil.MockSize(1) + size.disk=5 + size.scratch=20000 + driver.create_node(size, arv_node) + create_method = self.driver_mock().create_node + self.assertTrue(create_method.called) + self.assertEqual([{ + "DeviceName": "/dev/xvdt", + "Ebs": { + "DeleteOnTermination": True, + "VolumeSize": 16, + "VolumeType": "gp2" + }}], + create_method.call_args[1].get('ex_blockdevicemappings')) + + def test_ebs_volume_not_needed(self): + arv_node = testutil.arvados_node_mock() + driver = self.new_driver() + # libcloud/ec2 "disk" sizes are in GB, Arvados/SLURM "scratch" value is in MB + size = testutil.MockSize(1) + size.disk=80 + size.scratch=20000 + driver.create_node(size, arv_node) + create_method = self.driver_mock().create_node + self.assertTrue(create_method.called) + self.assertIsNone(create_method.call_args[1].get('ex_blockdevicemappings')) + + def test_ebs_volume_too_big(self): + arv_node = testutil.arvados_node_mock() + driver = self.new_driver() + # libcloud/ec2 "disk" sizes are in GB, Arvados/SLURM "scratch" value is in MB + size = testutil.MockSize(1) + size.disk=80 + size.scratch=20000000 + driver.create_node(size, arv_node) + create_method = self.driver_mock().create_node + self.assertTrue(create_method.called) + self.assertEqual([{ + "DeviceName": "/dev/xvdt", + "Ebs": { + "DeleteOnTermination": True, + "VolumeSize": 16384, + "VolumeType": "gp2" + }}], + create_method.call_args[1].get('ex_blockdevicemappings'))