X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/5823ffd02299b125dfb372cd8a225e62e0ccd4fe..ddfb91e9eee0902fba8b972e2724b2eb4707654a:/src/services/common-service/common-service.ts diff --git a/src/services/common-service/common-service.ts b/src/services/common-service/common-service.ts index bdae87ab40..8e9fe63170 100644 --- a/src/services/common-service/common-service.ts +++ b/src/services/common-service/common-service.ts @@ -87,11 +87,13 @@ export class CommonService { return mapKeys ? CommonService.mapResponseKeys(response) : response.data; }) .catch(({ response }) => { - actions.progressFn(reqId, false); - const errors = CommonService.mapResponseKeys(response) as Errors; - errors.status = response.status; - actions.errorFn(reqId, errors, showErrors); - throw errors; + if (response) { + actions.progressFn(reqId, false); + const errors = CommonService.mapResponseKeys(response) as Errors; + errors.status = response.status; + actions.errorFn(reqId, errors, showErrors); + throw errors; + } }); } @@ -105,12 +107,14 @@ export class CommonService { ); } - delete(uuid: string): Promise { + delete(uuid: string, showErrors?: boolean): Promise { this.validateUuid(uuid); return CommonService.defaultResponse( this.serverApi .delete(`/${this.resourceType}/${uuid}`), - this.actions + this.actions, + true, // mapKeys + showErrors ); } @@ -152,6 +156,7 @@ export class CommonService { return CommonService.defaultResponse( this.serverApi.get(`/${this.resourceType}`, { params }), this.actions, + true, showErrors ); } else { @@ -168,17 +173,20 @@ export class CommonService { return CommonService.defaultResponse( this.serverApi.post(`/${this.resourceType}`, formData, {}), this.actions, + true, showErrors ); } } - update(uuid: string, data: Partial) { + update(uuid: string, data: Partial, showErrors?: boolean) { this.validateUuid(uuid); return CommonService.defaultResponse( this.serverApi .put(`/${this.resourceType}/${uuid}`, data && CommonService.mapKeys(snakeCase)(data)), - this.actions + this.actions, + undefined, // mapKeys + showErrors ); } }