X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/5126d94fd644a657243e5ec80d5ef1fc250f8b76..9b98829c565a2aa487d21ecd7f9429c23d0cec20:/services/api/app/models/link.rb diff --git a/services/api/app/models/link.rb b/services/api/app/models/link.rb index bb069ee97d..24872b21ec 100644 --- a/services/api/app/models/link.rb +++ b/services/api/app/models/link.rb @@ -9,8 +9,7 @@ class Link < ArvadosModel after_create :maybe_invalidate_permissions_cache after_destroy :maybe_invalidate_permissions_cache attr_accessor :head_kind, :tail_kind - validate :name_link_has_valid_name - validate :name_link_owner_is_tail + validate :name_links_are_obsolete api_accessible :user, extend: :common do |t| t.add :tail_uuid @@ -67,30 +66,23 @@ class Link < ArvadosModel # permissions for head_uuid and tail_uuid, and invalidate the # cache for only those users. (This would require a browseable # cache.) - User.invalidate_permissions_cache + User.invalidate_permissions_cache db_current_time.to_i end end - def name_link_has_valid_name + def name_links_are_obsolete if link_class == 'name' - unless name.is_a? String and !name.empty? - errors.add('name', 'must be a non-empty string') - end + errors.add('name', 'Name links are obsolete') + false else true end end - def name_link_owner_is_tail - if link_class == 'name' - self.owner_uuid = tail_uuid - ensure_owner_uuid_is_permitted - end - end - # A user is permitted to create, update or modify a permission link - # if and only if they have "manage" permission on the destination - # object. + # if and only if they have "manage" permission on the object + # indicated by the permission link's head_uuid. + # # All other links are treated as regular ArvadosModel objects. # def ensure_owner_uuid_is_permitted @@ -104,4 +96,5 @@ class Link < ArvadosModel super end end + end