X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/4689cec4c94dbbfcf990250e15ae6e822f9fd170..bde0fdb92ba9d667c380617ae7374cd957b4545d:/services/arv-git-httpd/gitolite_test.go diff --git a/services/arv-git-httpd/gitolite_test.go b/services/arv-git-httpd/gitolite_test.go index 74c2b8cf4d..cfedd88f17 100644 --- a/services/arv-git-httpd/gitolite_test.go +++ b/services/arv-git-httpd/gitolite_test.go @@ -1,3 +1,7 @@ +// Copyright (C) The Arvados Authors. All rights reserved. +// +// SPDX-License-Identifier: AGPL-3.0 + package main import ( @@ -6,8 +10,9 @@ import ( "os/exec" "strings" - "git.curoverse.com/arvados.git/sdk/go/arvados" - "git.curoverse.com/arvados.git/sdk/go/arvadostest" + "git.arvados.org/arvados.git/lib/config" + "git.arvados.org/arvados.git/sdk/go/arvados" + "git.arvados.org/arvados.git/sdk/go/ctxlog" check "gopkg.in/check.v1" ) @@ -43,24 +48,24 @@ func (s *GitoliteSuite) SetUpTest(c *check.C) { runGitolite("gitolite", "setup", "--admin", "root") s.tmpRepoRoot = s.gitoliteHome + "/repositories" - s.Config = &Config{ - Client: arvados.Client{ - APIHost: arvadostest.APIHost(), - Insecure: true, - }, - Listen: ":0", - GitCommand: "/usr/share/gitolite3/gitolite-shell", - RepoRoot: s.tmpRepoRoot, - } + + cfg, err := config.NewLoader(nil, ctxlog.TestLogger(c)).Load() + c.Assert(err, check.Equals, nil) + s.cluster, err = cfg.GetCluster("") + c.Assert(err, check.Equals, nil) + + s.cluster.Services.GitHTTP.InternalURLs = map[arvados.URL]arvados.ServiceInstance{{Host: "localhost:0"}: {}} + s.cluster.TLS.Insecure = true + s.cluster.Git.GitCommand = "/usr/share/gitolite3/gitolite-shell" + s.cluster.Git.GitoliteHome = s.gitoliteHome + s.cluster.Git.Repositories = s.tmpRepoRoot + s.IntegrationSuite.SetUpTest(c) // Install the gitolite hooks in the bare repo we made in // (*IntegrationTest)SetUpTest() -- see 2.2.4 at // http://gitolite.com/gitolite/gitolite.html runGitolite("gitolite", "setup") - - os.Setenv("GITOLITE_HTTP_HOME", s.gitoliteHome) - os.Setenv("GL_BYPASS_ACCESS_CHECKS", "1") } func (s *GitoliteSuite) TearDownTest(c *check.C) { @@ -76,7 +81,7 @@ func (s *GitoliteSuite) TearDownTest(c *check.C) { } func (s *GitoliteSuite) TestFetch(c *check.C) { - err := s.RunGit(c, activeToken, "fetch", "active/foo.git") + err := s.RunGit(c, activeToken, "fetch", "active/foo.git", "refs/heads/main") c.Check(err, check.Equals, nil) } @@ -86,7 +91,7 @@ func (s *GitoliteSuite) TestFetchUnreadable(c *check.C) { } func (s *GitoliteSuite) TestPush(c *check.C) { - err := s.RunGit(c, activeToken, "push", "active/foo.git", "master:gitolite-push") + err := s.RunGit(c, activeToken, "push", "active/foo.git", "main:gitolite-push") c.Check(err, check.Equals, nil) // Check that the commit hash appears in the gitolite log, as @@ -104,6 +109,6 @@ func (s *GitoliteSuite) TestPush(c *check.C) { } func (s *GitoliteSuite) TestPushUnwritable(c *check.C) { - err := s.RunGit(c, spectatorToken, "push", "active/foo.git", "master:gitolite-push-fail") - c.Check(err, check.ErrorMatches, `.*HTTP code = 403.*`) + err := s.RunGit(c, spectatorToken, "push", "active/foo.git", "main:gitolite-push-fail") + c.Check(err, check.ErrorMatches, `.*HTTP (code = )?403.*`) }