X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/45f10d80d1b584808a6e375214b5be6bc7d2a730..4139c5dfde60cdd20d39f385ca36107b0c44906f:/services/api/test/unit/arvados_model_test.rb diff --git a/services/api/test/unit/arvados_model_test.rb b/services/api/test/unit/arvados_model_test.rb index 6918aa0d00..d447c76c6d 100644 --- a/services/api/test/unit/arvados_model_test.rb +++ b/services/api/test/unit/arvados_model_test.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' class ArvadosModelTest < ActiveSupport::TestCase @@ -53,38 +57,38 @@ class ArvadosModelTest < ActiveSupport::TestCase {'a' => {'foo' => {:bar => 'baz'}}}, {'a' => {'foo' => {'bar' => :baz}}}, {'a' => {'foo' => ['bar', :baz]}}, + ].each do |x| + test "prevent symbol keys in serialized db columns: #{x.inspect}" do + set_user_from_auth :active + link = Link.create!(link_class: 'test', + properties: x) + raw = ActiveRecord::Base.connection. + select_value("select properties from links where uuid='#{link.uuid}'") + refute_match(/:[fb]/, raw) + end + end + + [ {['foo'] => 'bar'}, + {'a' => {['foo', :foo] => 'bar'}}, + {'a' => {{'foo' => 'bar'} => 'bar'}}, {'a' => {['foo', :foo] => ['bar', 'baz']}}, ].each do |x| - test "refuse symbol keys in serialized attribute: #{x.inspect}" do - set_user_from_auth :admin_trustedclient - assert_nothing_raised do - Link.create!(link_class: 'test', - properties: {}) - end - assert_raises ActiveRecord::RecordInvalid do + test "refuse non-string keys in serialized db columns: #{x.inspect}" do + set_user_from_auth :active + assert_raises(ArgumentError) do Link.create!(link_class: 'test', properties: x) end end end - test "Stringify symbols coming from serialized attribute in database" do - set_user_from_auth :admin_trustedclient - fixed = Link.find_by_uuid(links(:has_symbol_keys_in_database_somehow).uuid) - assert_equal(["baz", "foo"], fixed.properties.keys.sort, - "Hash symbol keys from DB did not get stringified.") - assert_equal(['waz', 'waz', 'waz', 1, nil, false, true], - fixed.properties['baz'], - "Array symbol values from DB did not get stringified.") - assert_equal true, fixed.save, "Failed to save fixed model back to db." - end - test "No HashWithIndifferentAccess in database" do set_user_from_auth :admin_trustedclient - assert_raises ActiveRecord::RecordInvalid do - Link.create!(link_class: 'test', - properties: {'foo' => 'bar'}.with_indifferent_access) - end + link = Link.create!(link_class: 'test', + properties: {'foo' => 'bar'}.with_indifferent_access) + raw = ActiveRecord::Base.connection. + select_value("select properties from links where uuid='#{link.uuid}'") + assert_equal '{"foo": "bar"}', raw end test "store long string" do @@ -124,6 +128,8 @@ class ArvadosModelTest < ActiveSupport::TestCase test "search index exists on models that go into projects" do all_tables = ActiveRecord::Base.connection.tables all_tables.delete 'schema_migrations' + all_tables.delete 'permission_refresh_lock' + all_tables.delete 'ar_internal_metadata' all_tables.each do |table| table_class = table.classify.constantize @@ -136,7 +142,10 @@ class ArvadosModelTest < ActiveSupport::TestCase indexes = ActiveRecord::Base.connection.indexes(table) search_index_by_columns = indexes.select do |index| - index.columns.sort == search_index_columns.sort + # After rails 5.0 upgrade, AR::Base.connection.indexes() started to include + # GIN indexes, with its 'columns' attribute being a String like + # 'to_tsvector(...)' + index.columns.is_a?(Array) ? index.columns.sort == search_index_columns.sort : false end search_index_by_name = indexes.select do |index| index.name == "#{table}_search_index" @@ -146,6 +155,75 @@ class ArvadosModelTest < ActiveSupport::TestCase end end + test "full text search index exists on models" do + indexes = {} + conn = ActiveRecord::Base.connection + conn.exec_query("SELECT i.relname as indname, + i.relowner as indowner, + idx.indrelid::regclass::text as table, + am.amname as indam, + idx.indkey, + ARRAY( + SELECT pg_get_indexdef(idx.indexrelid, k + 1, true) + FROM generate_subscripts(idx.indkey, 1) as k + ORDER BY k + ) as keys, + idx.indexprs IS NOT NULL as indexprs, + idx.indpred IS NOT NULL as indpred + FROM pg_index as idx + JOIN pg_class as i + ON i.oid = idx.indexrelid + JOIN pg_am as am + ON i.relam = am.oid + JOIN pg_namespace as ns + ON ns.oid = i.relnamespace + AND ns.nspname = ANY(current_schemas(false))").each do |idx| + if idx['keys'].match(/to_tsvector/) + indexes[idx['table']] ||= [] + indexes[idx['table']] << idx + end + end + fts_tables = ["collections", "container_requests", "groups", "jobs", + "pipeline_instances", "pipeline_templates", "workflows"] + fts_tables.each do |table| + table_class = table.classify.constantize + if table_class.respond_to?('full_text_searchable_columns') + expect = table_class.full_text_searchable_columns + ok = false + indexes[table].andand.each do |idx| + if expect == idx['keys'].scan(/COALESCE\(([A-Za-z_]+)/).flatten + ok = true + end + end + assert ok, "#{table} has no full-text index\nexpect: #{expect.inspect}\nfound: #{indexes[table].inspect}" + end + end + end + + [ + %w[collections collections_trgm_text_search_idx], + %w[container_requests container_requests_trgm_text_search_idx], + %w[groups groups_trgm_text_search_idx], + %w[jobs jobs_trgm_text_search_idx], + %w[pipeline_instances pipeline_instances_trgm_text_search_idx], + %w[pipeline_templates pipeline_templates_trgm_text_search_idx], + %w[workflows workflows_trgm_text_search_idx] + ].each do |model| + table = model[0] + indexname = model[1] + test "trigram index exists on #{table} model" do + table_class = table.classify.constantize + expect = table_class.full_text_searchable_columns + ok = false + conn = ActiveRecord::Base.connection + conn.exec_query("SELECT indexdef FROM pg_indexes WHERE tablename = '#{table}' AND indexname = '#{indexname}'").each do |res| + searchable = res['indexdef'].scan(/COALESCE\(+([A-Za-z_]+)/).flatten + ok = (expect == searchable) + assert ok, "Invalid or no trigram index on #{table} named #{indexname}\nexpect: #{expect.inspect}\nfound: #{searchable}" + end + end + end + test "selectable_attributes includes database attributes" do assert_includes(Job.selectable_attributes, "success") end @@ -197,4 +275,24 @@ class ArvadosModelTest < ActiveSupport::TestCase assert_equal true, (updated_at_2 > updated_at_1), "Expected updated time 2 to be newer than 1" end + + test 'jsonb column' do + set_user_from_auth :active + + c = Collection.create!(properties: {}) + assert_equal({}, c.properties) + + c.update_attributes(properties: {'foo' => 'foo'}) + c.reload + assert_equal({'foo' => 'foo'}, c.properties) + + c.update_attributes(properties: nil) + c.reload + assert_equal({}, c.properties) + + c.update_attributes(properties: {foo: 'bar'}) + assert_equal({'foo' => 'bar'}, c.properties) + c.reload + assert_equal({'foo' => 'bar'}, c.properties) + end end