X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/451a6d3590ed7c049ad6ce24f8f6c01685d7d3d3..a048d6957ff6284c4234198ed9b868bff07d057f:/services/api/test/unit/node_test.rb diff --git a/services/api/test/unit/node_test.rb b/services/api/test/unit/node_test.rb index 96d31a8c4c..4cb7a0a1b1 100644 --- a/services/api/test/unit/node_test.rb +++ b/services/api/test/unit/node_test.rb @@ -1,4 +1,10 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' +require 'tmpdir' +require 'tempfile' class NodeTest < ActiveSupport::TestCase def ping_node(node_name, ping_data) @@ -33,7 +39,7 @@ class NodeTest < ActiveSupport::TestCase conffile = Rails.root.join 'tmp', 'compute65535.conf' File.unlink conffile rescue nil assert Node.dns_server_update 'compute65535', '127.0.0.1' - assert_match /\"1\.0\.0\.127\.in-addr\.arpa\. IN PTR compute65535\.zzzzz\.arvadosapi\.com\"/, IO.read(conffile) + assert_match(/\"1\.0\.0\.127\.in-addr\.arpa\. IN PTR compute65535\.zzzzz\.arvadosapi\.com\"/, IO.read(conffile)) File.unlink conffile end @@ -76,6 +82,16 @@ class NodeTest < ActiveSupport::TestCase assert Node.dns_server_update 'compute65535', '127.0.0.127' end + test "don't leave temp files behind if there's an error writing them" do + Rails.configuration.dns_server_conf_template = Rails.root.join 'config', 'unbound.template' + Tempfile.any_instance.stubs(:puts).raises(IOError) + Dir.mktmpdir do |tmpdir| + Rails.configuration.dns_server_conf_dir = tmpdir + refute Node.dns_server_update 'compute65535', '127.0.0.127' + assert_empty Dir.entries(tmpdir).select{|f| File.file? f} + end + end + test "ping new node with no hostname and default config" do node = ping_node(:new_with_no_hostname, {}) slot_number = node.slot_number @@ -90,17 +106,12 @@ class NodeTest < ActiveSupport::TestCase assert_nil node.hostname end - [ - 'compute#{slot_number.to_s.rjust(4, "0")}', - 'compute%04d', - ].each do |config| - test "ping new node with zero padding config #{config}" do - Rails.configuration.assign_node_hostname = config - node = ping_node(:new_with_no_hostname, {}) - slot_number = node.slot_number - refute_nil slot_number - assert_equal("compute000#{slot_number}", node.hostname) - end + test "ping new node with zero padding config" do + Rails.configuration.assign_node_hostname = 'compute%04d' + node = ping_node(:new_with_no_hostname, {}) + slot_number = node.slot_number + refute_nil slot_number + assert_equal("compute000#{slot_number}", node.hostname) end test "ping node with hostname and config and expect hostname unchanged" do @@ -116,14 +127,13 @@ class NodeTest < ActiveSupport::TestCase assert_equal("custom1", node.hostname) end - # Ping two nodes: one with no hostname and the other with a hostname. + # Ping two nodes: one without a hostname and the other with a hostname. # Verify that the first one gets a hostname and second one is unchanged. test "ping two nodes one with no hostname and one with hostname and check hostnames" do # ping node with no hostname and expect it set with config format node = ping_node(:new_with_no_hostname, {}) - slot_number = node.slot_number refute_nil node.slot_number - assert_equal "compute#{slot_number}", node.hostname + assert_equal "compute#{node.slot_number}", node.hostname # ping node with a hostname and expect it to be unchanged node2 = ping_node(:new_with_custom_hostname, {}) @@ -131,10 +141,75 @@ class NodeTest < ActiveSupport::TestCase assert_equal "custom1", node2.hostname end - test "ping node with no hostname and malformed config and expect nil for hostname" do - Rails.configuration.assign_node_hostname = 'compute%04' # should end with "04d" - node = ping_node(:new_with_no_hostname, {}) - refute_nil node.slot_number - assert_equal(nil, node.hostname) + test "update dns when nodemanager clears hostname and ip_address" do + act_as_system_user do + node = ping_node(:new_with_custom_hostname, {}) + Node.expects(:dns_server_update).with(node.hostname, Node::UNUSED_NODE_IP) + node.update_attributes(hostname: nil, ip_address: nil) + end + end + + test "update dns when hostname changes" do + act_as_system_user do + node = ping_node(:new_with_custom_hostname, {}) + + Node.expects(:dns_server_update).with(node.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with('foo0', node.ip_address) + node.update_attributes!(hostname: 'foo0') + + Node.expects(:dns_server_update).with('foo0', Node::UNUSED_NODE_IP) + node.update_attributes!(hostname: nil, ip_address: nil) + + Node.expects(:dns_server_update).with('foo0', '10.11.12.13') + node.update_attributes!(hostname: 'foo0', ip_address: '10.11.12.13') + + Node.expects(:dns_server_update).with('foo0', '10.11.12.14') + node.update_attributes!(hostname: 'foo0', ip_address: '10.11.12.14') + end + end + + test 'newest ping wins IP address conflict' do + act_as_system_user do + n1, n2 = Node.create!, Node.create! + + n1.ping(ip: '10.5.5.5', ping_secret: n1.info['ping_secret']) + n1.reload + + Node.expects(:dns_server_update).with(n1.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with(Not(equals(n1.hostname)), '10.5.5.5') + n2.ping(ip: '10.5.5.5', ping_secret: n2.info['ping_secret']) + + n1.reload + n2.reload + assert_nil n1.ip_address + assert_equal '10.5.5.5', n2.ip_address + + Node.expects(:dns_server_update).with(n2.hostname, Node::UNUSED_NODE_IP) + Node.expects(:dns_server_update).with(n1.hostname, '10.5.5.5') + n1.ping(ip: '10.5.5.5', ping_secret: n1.info['ping_secret']) + + n1.reload + n2.reload + assert_nil n2.ip_address + assert_equal '10.5.5.5', n1.ip_address + end + end + + test 'run out of slots' do + Rails.configuration.max_compute_nodes = 3 + act_as_system_user do + Node.destroy_all + (1..4).each do |i| + n = Node.create! + args = { ip: "10.0.0.#{i}", ping_secret: n.info['ping_secret'] } + if i <= Rails.configuration.max_compute_nodes + n.ping(args) + else + assert_raises do + n.ping(args) + end + end + end + end end end