X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/43c411ec1441ee1710dc33389d7451f7414a170f..ea6fac863db754cfe1681c5c9067139d31c8136d:/services/api/app/models/node.rb

diff --git a/services/api/app/models/node.rb b/services/api/app/models/node.rb
index e79f976260..33527358db 100644
--- a/services/api/app/models/node.rb
+++ b/services/api/app/models/node.rb
@@ -18,14 +18,18 @@ class Node < ArvadosModel
   @@domain = Rails.configuration.compute_node_domain rescue `hostname --domain`.strip
   @@nameservers = Rails.configuration.compute_node_nameservers
 
-  api_accessible :superuser, :extend => :common do |t|
+  api_accessible :user, :extend => :common do |t|
     t.add :hostname
     t.add :domain
     t.add :ip_address
-    t.add :first_ping_at
     t.add :last_ping_at
-    t.add :info
+    t.add :slot_number
     t.add :status
+    t.add :crunch_worker_state
+  end
+  api_accessible :superuser, :extend => :user do |t|
+    t.add :first_ping_at
+    t.add :info
     t.add lambda { |x| @@nameservers }, :as => :nameservers
   end
 
@@ -38,6 +42,17 @@ class Node < ArvadosModel
     super || @@domain
   end
 
+  def crunch_worker_state
+    case self.info.andand[:slurm_state]
+    when 'alloc', 'comp'
+      'busy'
+    when 'idle'
+      'idle'
+    else
+      'down'
+    end
+  end
+
   def status
     if !self.last_ping_at
       if Time.now - self.created_at > 5.minutes
@@ -57,7 +72,7 @@ class Node < ArvadosModel
 
     if o[:ping_secret] != self.info[:ping_secret]
       logger.info "Ping: secret mismatch: received \"#{o[:ping_secret]}\" != \"#{self.info[:ping_secret]}\""
-      return nil
+      raise ArvadosModel::PermissionDeniedError.new("Incorrect ping_secret")
     end
     self.last_ping_at = Time.now
 
@@ -74,7 +89,9 @@ class Node < ArvadosModel
     if o[:ec2_instance_id]
       if !self.info[:ec2_instance_id] 
         self.info[:ec2_instance_id] = o[:ec2_instance_id]
-        `ec2-create-tags #{o[:ec2_instance_id]} --tag 'Name=#{self.uuid}'`
+        tag_cmd = ("ec2-create-tags #{o[:ec2_instance_id]} " +
+                   "--tag 'Name=#{self.uuid}'")
+        `#{tag_cmd}`
       elsif self.info[:ec2_instance_id] != o[:ec2_instance_id]
         logger.debug "Multiple nodes have credentials for #{self.uuid}"
         raise "#{self.uuid} is already running at #{self.info[:ec2_instance_id]} so rejecting ping from #{o[:ec2_instance_id]}"
@@ -108,7 +125,7 @@ class Node < ArvadosModel
     ping_url = ping_url_method.call({ uuid: self.uuid, ping_secret: self.info[:ping_secret] })
     ec2_args = ["--user-data '#{ping_url}'",
                 "-t c1.xlarge -n 1",
-                "-g", Rails.configuration.compute_node_security_group,
+                Rails.configuration.compute_node_ec2run_args,
                 Rails.configuration.compute_node_ami
                ]
     ec2run_cmd = ["ec2-run-instances",