X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/42bf31f017a009585eaac2fe44a83b2596b3e5c8..1d460a17caf94ddc33610b39a0a11aec1d3905a2:/lib/controller/rpc/conn.go diff --git a/lib/controller/rpc/conn.go b/lib/controller/rpc/conn.go index 3a19f4ab5a..940f2184b2 100644 --- a/lib/controller/rpc/conn.go +++ b/lib/controller/rpc/conn.go @@ -39,7 +39,9 @@ func PassthroughTokenProvider(ctx context.Context) ([]string, error) { } type Conn struct { - SendHeader http.Header + SendHeader http.Header + RedactHostInErrors bool + clusterID string httpClient http.Client baseURL url.URL @@ -148,7 +150,21 @@ func (conn *Conn) requestAndDecode(ctx context.Context, dst interface{}, ep arva path = strings.Replace(path, "/{uuid}", "/"+uuid, 1) delete(params, "uuid") } - return aClient.RequestAndDecodeContext(ctx, dst, ep.Method, path, body, params) + err = aClient.RequestAndDecodeContext(ctx, dst, ep.Method, path, body, params) + if err != nil && conn.RedactHostInErrors { + redacted := strings.Replace(err.Error(), strings.TrimSuffix(conn.baseURL.String(), "/"), "//railsapi.internal", -1) + if strings.HasPrefix(redacted, "request failed: ") { + redacted = strings.Replace(redacted, "request failed: ", "", -1) + } + if redacted != err.Error() { + if err, ok := err.(httpStatusError); ok { + return wrapHTTPStatusError(err, redacted) + } else { + return errors.New(redacted) + } + } + } + return err } func (conn *Conn) BaseURL() url.URL { @@ -416,6 +432,69 @@ func (conn *Conn) ContainerRequestDelete(ctx context.Context, options arvados.De return resp, err } +func (conn *Conn) GroupCreate(ctx context.Context, options arvados.CreateOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupCreate + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupUpdate(ctx context.Context, options arvados.UpdateOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupUpdate + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupGet(ctx context.Context, options arvados.GetOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupGet + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupList(ctx context.Context, options arvados.ListOptions) (arvados.GroupList, error) { + ep := arvados.EndpointGroupList + var resp arvados.GroupList + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupContents(ctx context.Context, options arvados.GroupContentsOptions) (arvados.ObjectList, error) { + ep := arvados.EndpointGroupContents + var resp arvados.ObjectList + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupShared(ctx context.Context, options arvados.ListOptions) (arvados.GroupList, error) { + ep := arvados.EndpointGroupShared + var resp arvados.GroupList + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupDelete(ctx context.Context, options arvados.DeleteOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupDelete + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupTrash(ctx context.Context, options arvados.DeleteOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupTrash + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + +func (conn *Conn) GroupUntrash(ctx context.Context, options arvados.UntrashOptions) (arvados.Group, error) { + ep := arvados.EndpointGroupUntrash + var resp arvados.Group + err := conn.requestAndDecode(ctx, &resp, ep, nil, options) + return resp, err +} + func (conn *Conn) SpecimenCreate(ctx context.Context, options arvados.CreateOptions) (arvados.Specimen, error) { ep := arvados.EndpointSpecimenCreate var resp arvados.Specimen @@ -566,3 +645,26 @@ func (conn *Conn) UserAuthenticate(ctx context.Context, options arvados.UserAuth err := conn.requestAndDecode(ctx, &resp, ep, nil, options) return resp, err } + +// httpStatusError is an error with an HTTP status code that can be +// propagated by lib/controller/router, etc. +type httpStatusError interface { + error + HTTPStatus() int +} + +// wrappedHTTPStatusError is used to augment/replace an error message +// while preserving the HTTP status code indicated by the original +// error. +type wrappedHTTPStatusError struct { + httpStatusError + message string +} + +func wrapHTTPStatusError(err httpStatusError, message string) httpStatusError { + return wrappedHTTPStatusError{err, message} +} + +func (err wrappedHTTPStatusError) Error() string { + return err.message +}