X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/420d88e40bc5c2d12fe53a5f9f25ec19d80de797..397981dadc145225c691c8643b10527c9710f1fb:/apps/workbench/test/integration/projects_test.rb diff --git a/apps/workbench/test/integration/projects_test.rb b/apps/workbench/test/integration/projects_test.rb index 97e1a542ba..7a5103007f 100644 --- a/apps/workbench/test/integration/projects_test.rb +++ b/apps/workbench/test/integration/projects_test.rb @@ -1,20 +1,22 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'integration_helper' -require 'selenium-webdriver' -require 'headless' +require 'helpers/share_object_helper' +require_relative 'integration_test_utils' class ProjectsTest < ActionDispatch::IntegrationTest - setup do - headless = Headless.new - headless.start - Capybara.current_driver = :selenium + include ShareObjectHelper - # project tests need bigger page size to be able to see all the buttons - Capybara.current_session.driver.browser.manage.window.resize_to(1152, 768) + setup do + need_javascript end test 'Check collection count for A Project in the tab pane titles' do project_uuid = api_fixture('groups')['aproject']['uuid'] visit page_with_token 'active', '/projects/' + project_uuid + click_link 'Data collections' wait_for_ajax collection_count = page.all("[data-pk*='collection']").count assert_selector '#Data_collections-tab span', text: "(#{collection_count})" @@ -38,113 +40,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest "Description update did not survive page refresh") end - test 'Find a project and edit description to textile description' do - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: "A Project").click - within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do - find('span', text: api_fixture('groups')['aproject']['name']).click - within('.arv-description-as-subtitle') do - find('.fa-pencil').click - find('.editable-input textarea').set('

*Textile description for A project* - "take me home":/

And a new paragraph in description.

') - find('.editable-submit').click - end - wait_for_ajax - end - - # visit project page - visit current_path - assert_no_text '*Textile description for A project*' - assert(find?('.container-fluid', text: 'Textile description for A project'), - "Description update did not survive page refresh") - assert(find?('.container-fluid', text: 'And a new paragraph in description'), - "Description did not contain the expected new paragraph") - assert(page.has_link?("take me home"), "link not found in description") - - click_link 'take me home' - - # now in dashboard - assert(page.has_text?('Active pipelines'), 'Active pipelines - not found on dashboard') - end - - test 'Find a project and edit description to html description' do - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: "A Project").click - within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do - find('span', text: api_fixture('groups')['aproject']['name']).click - within('.arv-description-as-subtitle') do - find('.fa-pencil').click - find('.editable-input textarea').set('
Textile description for A project
- take me home') - find('.editable-submit').click - end - wait_for_ajax - end - visit current_path - assert(find?('.container-fluid', text: 'Textile description for A project'), - "Description update did not survive page refresh") - assert(!find?('.container-fluid', text: '
Textile description for A project
'), - "Textile description is displayed with uninterpreted formatting characters") - assert(page.has_link?("take me home"),"link not found in description") - click_link 'take me home' - assert page.has_text?('Active pipelines') - end - - test 'Find a project and edit description to textile description with link to object' do - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: "A Project").click - within('.container-fluid', text: api_fixture('groups')['aproject']['name']) do - find('span', text: api_fixture('groups')['aproject']['name']).click - within('.arv-description-as-subtitle') do - find('.fa-pencil').click - find('.editable-input textarea').set('*Textile description for A project* - "go to sub-project":' + api_fixture('groups')['asubproject']['uuid'] + "'") - find('.editable-submit').click - end - wait_for_ajax - end - visit current_path - assert(find?('.container-fluid', text: 'Textile description for A project'), - "Description update did not survive page refresh") - assert(!find?('.container-fluid', text: '*Textile description for A project*'), - "Textile description is displayed with uninterpreted formatting characters") - assert(page.has_link?("go to sub-project"), "link not found in description") - click_link 'go to sub-project' - assert(page.has_text?(api_fixture('groups')['asubproject']['name']), 'sub-project name not found after clicking link') - end - - test 'Add a new name, then edit it, without creating a duplicate' do - project_uuid = api_fixture('groups')['aproject']['uuid'] - specimen_uuid = api_fixture('traits')['owned_by_aproject_with_no_name']['uuid'] - visit page_with_token 'active', '/projects/' + project_uuid - click_link 'Other objects' - within '.selection-action-container' do - # Wait for the tab to load: - assert_selector 'tr[data-kind="arvados#trait"]' - within first('tr', text: 'Trait') do - find(".fa-pencil").click - find('.editable-input input').set('Now I have a name.') - find('.glyphicon-ok').click - assert_selector '.editable', text: 'Now I have a name.' - find(".fa-pencil").click - find('.editable-input input').set('Now I have a new name.') - find('.glyphicon-ok').click - end - wait_for_ajax - assert_selector '.editable', text: 'Now I have a new name.' - end - visit current_path - click_link 'Other objects' - within '.selection-action-container' do - find '.editable', text: 'Now I have a new name.' - assert_no_selector '.editable', text: 'Now I have a name.' - end - end - test 'Create a project and move it into a different project' do visit page_with_token 'active', '/projects' find("#projects-menu").click - find(".dropdown-menu a", text: "Home").click + within('.dropdown-menu') do + first('li', text: 'Home').click + end + wait_for_ajax find('.btn', text: "Add a subproject").click within('h2') do @@ -156,7 +58,10 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit '/projects' find("#projects-menu").click - find(".dropdown-menu a", text: "Home").click + within('.dropdown-menu') do + first('li', text: 'Home').click + end + wait_for_ajax find('.btn', text: "Add a subproject").click within('h2') do find('.fa-pencil').click @@ -176,78 +81,39 @@ class ProjectsTest < ActionDispatch::IntegrationTest "Project 5678 should now be inside project 1234") end - def show_project_using(auth_key, proj_key='aproject') - project_uuid = api_fixture('groups')[proj_key]['uuid'] - visit(page_with_token(auth_key, "/projects/#{project_uuid}")) - assert(page.has_text?("A Project"), "not on expected project page") + def open_groups_sharing(project_name="aproject", token_name="active") + project = api_fixture("groups", project_name) + visit(page_with_token(token_name, "/projects/#{project['uuid']}")) + click_on "Sharing" + click_on "Share with groups" end - def share_rows - find('#project_sharing').all('tr') + def group_name(group_key) + api_fixture("groups", group_key, "name") end - def add_share_and_check(share_type, name, obj=nil) - assert(page.has_no_text?(name), "project is already shared with #{name}") - start_share_count = share_rows.size - click_on("Share with #{share_type}") - within(".modal-container") do - # Order is important here: we should find something that appears in the - # modal before we make any assertions about what's not in the modal. - # Otherwise, the not-included assertions might falsely pass because - # the modal hasn't loaded yet. - find(".selectable", text: name).click - assert(has_no_selector?(".modal-dialog-preview-pane"), - "preview pane available in sharing dialog") - if share_type == 'users' and obj and obj['email'] - assert(page.has_text?(obj['email']), "Did not find user's email") - end - assert_raises(Capybara::ElementNotFound, - "Projects pulldown available from sharing dialog") do - click_on "All projects" - end - click_on "Add" - end - using_wait_time(Capybara.default_wait_time * 3) do - assert(page.has_link?(name), - "new share was not added to sharing table") - assert_equal(start_share_count + 1, share_rows.size, - "new share did not add row to sharing table") - end + test "projects not publicly sharable when anonymous browsing disabled" do + Rails.configuration.Users.AnonymousUserToken = "" + open_groups_sharing + # Check for a group we do expect first, to make sure the modal's loaded. + assert_selector(".modal-container .selectable", + text: group_name("all_users")) + assert_no_selector(".modal-container .selectable", + text: group_name("anonymous_group")) end - def modify_share_and_check(name) - start_rows = share_rows - link_row = start_rows.select { |row| row.has_text?(name) } - assert_equal(1, link_row.size, "row with new permission not found") - within(link_row.first) do - click_on("Read") - select("Write", from: "share_change_level") - click_on("editable-submit") - assert(has_link?("Write"), - "failed to change access level on new share") - click_on "Revoke" - page.driver.browser.switch_to.alert.accept - end - wait_for_ajax - using_wait_time(Capybara.default_wait_time * 3) do - assert(page.has_no_text?(name), - "new share row still exists after being revoked") - assert_equal(start_rows.size - 1, share_rows.size, - "revoking share did not remove row from sharing table") - end - end - - test "project viewer can't see project sharing tab" do - show_project_using("project_viewer") - assert(page.has_no_link?("Sharing"), - "read-only project user sees sharing tab") + test "projects publicly sharable when anonymous browsing enabled" do + Rails.configuration.Users.AnonymousUserToken = "testonlytoken" + open_groups_sharing + assert_selector(".modal-container .selectable", + text: group_name("anonymous_group")) end test "project owner can manage sharing for another user" do add_user = api_fixture('users')['future_project_user'] new_name = ["first_name", "last_name"].map { |k| add_user[k] }.join(" ") - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" add_share_and_check("users", new_name, add_user) modify_share_and_check(new_name) @@ -256,17 +122,17 @@ class ProjectsTest < ActionDispatch::IntegrationTest test "project owner can manage sharing for another group" do new_name = api_fixture('groups')['future_project_viewing_group']['name'] - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" add_share_and_check("groups", new_name) modify_share_and_check(new_name) end test "'share with group' listing does not offer projects" do - show_project_using("active") + show_object_using('active', 'groups', 'aproject', 'A Project') click_on "Sharing" click_on "Share with groups" - good_uuid = api_fixture("groups")["private"]["uuid"] + good_uuid = api_fixture("groups")["future_project_viewing_group"]["uuid"] assert(page.has_selector?(".selectable[data-object-uuid=\"#{good_uuid}\"]"), "'share with groups' listing missing owned user group") bad_uuid = api_fixture("groups")["asubproject"]["uuid"] @@ -293,6 +159,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: dest['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in dest project after copy' when 'Move' @@ -300,18 +167,11 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: dest['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in dest project after move' when 'Remove' assert page.has_no_text?(my_collection['name']), 'Collection still found in src project after remove' - visit page_with_token 'active', '/' - find("#projects-menu").click - find(".dropdown-menu a", text: "Home").click - assert page.has_text?(my_collection['name']), 'Collection not found in home project after remove' - if expect_name_change - assert page.has_text?(my_collection['name']+' removed from ' + src['name']), - 'Collection with update name is not found in home project after remove' - end end end end @@ -320,6 +180,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: src['name']).click + click_link 'Data collections' assert page.has_text?(item['name']), 'Collection not found in src project' within('tr', text: item['name']) do @@ -358,6 +219,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest find("#projects-menu").click find(".dropdown-menu a", text: my_project['name']).click + click_link 'Data collections' click_button 'Selection' within('.selection-action-container') do assert_selector 'li.disabled', text: 'Create new collection with selected collections' @@ -371,6 +233,7 @@ class ProjectsTest < ActionDispatch::IntegrationTest visit page_with_token 'active', '/' find("#projects-menu").click find(".dropdown-menu a", text: my_project['name']).click + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in project' within('tr', text: my_collection['name']) do @@ -485,8 +348,11 @@ class ProjectsTest < ActionDispatch::IntegrationTest assert_selector 'li', text: 'Remove selected' end + # Close the dropdown by clicking outside it. + find('.dropdown-toggle', text: 'Selection').find(:xpath, '..').click + # Go back to Data collections tab - click_link 'Data collections' + find('.nav-tabs a', text: 'Data collections').click click_button 'Selection' within('.selection-action-container') do assert_no_selector 'li.disabled', text: 'Create new collection with selected collections' @@ -501,11 +367,13 @@ class ProjectsTest < ActionDispatch::IntegrationTest end end - # "Move selected" and "Remove selected" options should not be available when current user cannot write to the project + # "Move selected" and "Remove selected" options should not be + # available when current user cannot write to the project test "move selected and remove selected actions not available when current user cannot write to project" do my_project = api_fixture('groups')['anonymously_accessible_project'] visit page_with_token 'active', "/projects/#{my_project['uuid']}" + click_link 'Data collections' click_button 'Selection' within('.selection-action-container') do assert_selector 'li', text: 'Create new collection with selected collections' @@ -524,9 +392,8 @@ class ProjectsTest < ActionDispatch::IntegrationTest my_project = api_fixture('groups')['aproject'] my_collection = api_fixture('collections')['collection_to_move_around_in_aproject'] - visit page_with_token user, '/' - find("#projects-menu").click - find(".dropdown-menu a", text: my_project['name']).click + visit page_with_token user, "/projects/#{my_project['uuid']}" + click_link 'Data collections' assert page.has_text?(my_collection['name']), 'Collection not found in project' within('tr', text: my_collection['name']) do @@ -546,19 +413,6 @@ class ProjectsTest < ActionDispatch::IntegrationTest assert page.has_text?("Created new collection in your Home project"), 'Not found flash message that new collection is created in Home project' end - assert page.has_text?('Content hash'), 'Not found content hash in collection page' - end - end - - [ - ["jobs", "/jobs"], - ["pipelines", "/pipeline_instances"], - ["collections", "/collections"] - ].each do |target,path| - test "Test dashboard button all #{target}" do - visit page_with_token 'active', '/' - click_link "All #{target}" - assert_equal path, current_path end end @@ -664,60 +518,40 @@ class ProjectsTest < ActionDispatch::IntegrationTest [ ['project_with_10_pipelines', 10, 0], - ['project_with_2_pipelines_and_60_jobs', 2, 60], + ['project_with_2_pipelines_and_60_crs', 2, 60], ['project_with_25_pipelines', 25, 0], - ].each do |project_name, num_pipelines, num_jobs| - test "scroll pipeline instances tab for #{project_name} with #{num_pipelines} pipelines and #{num_jobs} jobs" do - item_list_parameter = "Jobs_and_pipelines" + ].each do |project_name, num_pipelines, num_crs| + test "scroll pipeline instances tab for #{project_name} with #{num_pipelines} pipelines and #{num_crs} container requests" do + item_list_parameter = "Pipelines_and_processes" scroll_setup project_name, - num_pipelines + num_jobs, + num_pipelines + num_crs, item_list_parameter # check the general scrolling and the pipelines scroll_items_check num_pipelines, "pipeline_", item_list_parameter, 'tr[data-kind="arvados#pipelineInstance"]' - # Check job count separately - jobs_found = page.all('tr[data-kind="arvados#job"]') - found_job_count = jobs_found.count - assert_equal num_jobs, found_job_count, 'Did not find expected number of jobs' - end - end - - # Move button accessibility - [ - ['admin', true], - ['active', true], # project owner - ['project_viewer', false], - ].each do |user, can_move| - test "#{user} can move subproject under another user's Home #{can_move}" do - project = api_fixture('groups')['aproject'] - collection = api_fixture('collections')['collection_to_move_around_in_aproject'] - - # verify the project move button - visit page_with_token user, "/projects/#{project['uuid']}" - if can_move - assert page.has_link? 'Move project...' - else - assert page.has_no_link? 'Move project...' - end + # Check container request count separately + crs_found = page.all('tr[data-kind="arvados#containerRequest"]') + found_cr_count = crs_found.count + assert_equal num_crs, found_cr_count, 'Did not find expected number of container requests' end end test "error while loading tab" do - original_arvados_v1_base = Rails.configuration.arvados_v1_base + original_arvados_v1_base = Rails.configuration.Services.Controller.ExternalURL visit page_with_token 'active', '/projects/' + api_fixture('groups')['aproject']['uuid'] # Point to a bad api server url to generate error - Rails.configuration.arvados_v1_base = "https://[100::f]:1/" + Rails.configuration.Services.Controller.ExternalURL = "https://[::1]:1/" click_link 'Other objects' within '#Other_objects' do # Error assert_selector('a', text: 'Reload tab') # Now point back to the orig api server and reload tab - Rails.configuration.arvados_v1_base = original_arvados_v1_base + Rails.configuration.Services.Controller.ExternalURL = original_arvados_v1_base click_link 'Reload tab' assert_no_selector('a', text: 'Reload tab') assert_selector('button', text: 'Selection') @@ -728,7 +562,6 @@ class ProjectsTest < ActionDispatch::IntegrationTest end test "add new project using projects dropdown" do - # verify that selection options are disabled on the project until an item is selected visit page_with_token 'active', '/' # Add a new project @@ -736,12 +569,190 @@ class ProjectsTest < ActionDispatch::IntegrationTest click_link 'Add a new project' assert_text 'New project' assert_text 'No description provided' + end + + test "first tab loads data when visiting other tab directly" do + # As of 2014-12-19, the first tab of project#show uses infinite scrolling. + # Make sure that it loads data even if we visit another tab directly. + need_selenium 'to land on specified tab using {url}#Advanced' + user = api_fixture("users", "active") + visit(page_with_token("active_trustedclient", + "/projects/#{user['uuid']}#Advanced")) + assert_text("API response") + find("#page-wrapper .nav-tabs :first-child a").click + assert_text("Collection modified at") + end + + # "Select all" and "Unselect all" options + test "select all and unselect all actions" do + need_selenium 'to check and uncheck checkboxes' + + visit page_with_token 'active', '/projects/' + api_fixture('groups')['aproject']['uuid'] + + # Go to "Data collections" tab and click on "Select all" + click_link 'Data collections' + wait_for_ajax + + # Initially, all selection options for this tab should be disabled + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Create new collection with selected collections' + assert_selector 'li.disabled', text: 'Copy selected' + end + + # Select all + click_button 'Select all' + + assert_checkboxes_state('input[type=checkbox]', true, '"select all" should check all checkboxes') + + # Now the selection options should be enabled + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + end + + # Go to Pipelines and processes tab and assert none selected + click_link 'Pipelines and processes' + wait_for_ajax + + # Since this is the first visit to this tab, all selection options should be disabled + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Create new collection with selected collections' + assert_selector 'li.disabled', text: 'Copy selected' + end + + assert_checkboxes_state('input[type=checkbox]', false, '"select all" should check all checkboxes') + + # Select all + click_button 'Select all' + assert_checkboxes_state('input[type=checkbox]', true, '"select all" should check all checkboxes') + + # Applicable selection options should be enabled + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Create new collection with selected collections' + assert_selector 'li', text: 'Copy selected' + assert_no_selector 'li.disabled', text: 'Copy selected' + end + + # Unselect all + click_button 'Unselect all' + assert_checkboxes_state('input[type=checkbox]', false, '"select all" should check all checkboxes') + + # All selection options should be disabled again + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Create new collection with selected collections' + assert_selector 'li.disabled', text: 'Copy selected' + end + + # Go back to Data collections tab and verify all are still selected + click_link 'Data collections' + wait_for_ajax + + # Selection options should be enabled based on the fact that all collections are still selected in this tab + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + end + + assert_checkboxes_state('input[type=checkbox]', true, '"select all" should check all checkboxes') + + # Unselect all + find('button#unselect-all').click + assert_checkboxes_state('input[type=checkbox]', false, '"unselect all" should clear all checkboxes') + + # Now all selection options should be disabled because none of the collections are checked + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li.disabled', text: 'Copy selected' + assert_selector 'li.disabled', text: 'Copy selected' + end + + # Verify checking just one checkbox still works as expected + within('tr', text: api_fixture('collections')['collection_to_move_around_in_aproject']['name']) do + find('input[type=checkbox]').click + end + + click_button 'Selection' + within('.selection-action-container') do + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + assert_selector 'li', text: 'Create new collection with selected collections' + assert_no_selector 'li.disabled', text: 'Copy selected' + end + end + + test "test search all projects menu item in projects menu" do + need_selenium + visit page_with_token('active') + find('#projects-menu').click + within('.dropdown-menu') do + assert_selector 'a', text: 'Search all projects' + find('a', text: 'Search all projects').click + end + within('.modal-content') do + assert page.has_text?('All projects'), 'No text - All projects' + assert page.has_text?('Search'), 'No text - Search' + assert page.has_text?('Cancel'), 'No text - Cancel' + fill_in "Search", with: 'Unrestricted public data' + wait_for_ajax + assert_selector 'div', text: 'Unrestricted public data' + find(:xpath, '//*[@id="choose-scroll"]/div[2]/div').click + click_button 'Show' + end + assert page.has_text?('Unrestricted public data'), 'No text - Unrestricted public data' + assert page.has_text?('An anonymously accessible project'), 'No text - An anonymously accessible project' + end + + test "test star and unstar project" do + visit page_with_token 'active', "/projects/#{api_fixture('groups')['anonymously_accessible_project']['uuid']}" + + # add to favorites + find('.fa-star-o').click + wait_for_ajax - # Add one more new project find("#projects-menu").click - click_link 'Add a new project' - match = /New project \(\d\)/.match page.text - assert match, 'Expected project name not found' - assert_text 'No description provided' + within('.dropdown-menu') do + assert_selector 'li', text: 'Unrestricted public data' + end + + # remove from favotires + find('.fa-star').click + wait_for_ajax + + find("#projects-menu").click + within('.dropdown-menu') do + assert_no_selector 'li', text: 'Unrestricted public data' + end + end + + [ + ['Workflow with input specifications', 'this workflow has inputs specified', 'Provide a value for the following'], + ].each do |template_name, preview_txt, process_txt| + test "run a process using template #{template_name} in a project" do + project = api_fixture('groups')['aproject'] + visit page_with_token 'active', '/projects/' + project['uuid'] + + find('.btn', text: 'Run a process').click + + # in the chooser, verify preview and click Next button + within('.modal-dialog') do + find('.selectable', text: template_name).click + assert_text preview_txt + find('.btn', text: 'Next: choose inputs').click + end + + # in the process page now + assert_text process_txt + assert_text project['name'] + end end end