X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/3ef505311c624abd61dd899283e061974abe8efb..486b1bf637827063cdedef283907da2dcc63ad22:/src/components/collection-panel-files/collection-panel-files.tsx

diff --git a/src/components/collection-panel-files/collection-panel-files.tsx b/src/components/collection-panel-files/collection-panel-files.tsx
index 70c72107e7..e33b7df0dc 100644
--- a/src/components/collection-panel-files/collection-panel-files.tsx
+++ b/src/components/collection-panel-files/collection-panel-files.tsx
@@ -7,6 +7,7 @@ import classNames from 'classnames';
 import { connect } from 'react-redux';
 import { FixedSizeList } from "react-window";
 import AutoSizer from "react-virtualized-auto-sizer";
+import servicesProvider from 'common/service-provider';
 import { CustomizeTableIcon, DownloadIcon } from 'components/icon/icon';
 import { SearchInput } from 'components/search-input/search-input';
 import { ListItemIcon, StyleRulesCallback, Theme, WithStyles, withStyles, Tooltip, IconButton, Checkbox, CircularProgress, Button } from '@material-ui/core';
@@ -16,10 +17,11 @@ import { RootState } from 'store/store';
 import { WebDAV, WebDAVRequestConfig } from 'common/webdav';
 import { AuthState } from 'store/auth/auth-reducer';
 import { extractFilesData } from 'services/collection-service/collection-service-files-response';
-import { DefaultIcon, DirectoryIcon, FileIcon } from 'components/icon/icon';
+import { DefaultIcon, DirectoryIcon, FileIcon, BackIcon, SidePanelRightArrowIcon } from 'components/icon/icon';
 import { setCollectionFiles } from 'store/collection-panel/collection-panel-files/collection-panel-files-actions';
 import { sortBy } from 'lodash';
 import { formatFileSize } from 'common/formatters';
+import { getInlineFileUrl, sanitizeToken } from 'views-components/context-menu/actions/helpers';
 
 export interface CollectionPanelFilesProps {
     items: any;
@@ -40,13 +42,12 @@ export interface CollectionPanelFilesProps {
     collectionPanel: any;
 }
 
-type CssRules = "pathPanelPathWrapper" | "uploadButton" | "uploadIcon" | "loader" | "wrapper" | "dataWrapper" | "row" | "rowEmpty" | "leftPanel" | "rightPanel" | "pathPanel" | "pathPanelItem" | "rowName" | "listItemIcon" | "rowActive" | "pathPanelMenu" | "rowSelection" | "leftPanelHidden" | "leftPanelVisible" | "searchWrapper" | "searchWrapperHidden";
+type CssRules = "backButton" | "backButtonHidden" | "pathPanelPathWrapper" | "uploadButton" | "uploadIcon" | "loader" | "wrapper" | "dataWrapper" | "row" | "rowEmpty" | "leftPanel" | "rightPanel" | "pathPanel" | "pathPanelItem" | "rowName" | "listItemIcon" | "rowActive" | "pathPanelMenu" | "rowSelection" | "leftPanelHidden" | "leftPanelVisible" | "searchWrapper" | "searchWrapperHidden";
 
 const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
     wrapper: {
         display: 'flex',
         minHeight: '600px',
-        marginBottom: '1rem',
         color: 'rgba(0, 0, 0, 0.87)',
         fontSize: '0.875rem',
         fontFamily: '"Roboto", "Helvetica", "Arial", sans-serif',
@@ -54,6 +55,14 @@ const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
         lineHeight: '1.5',
         letterSpacing: '0.01071em'
     },
+    backButton: {
+        color: '#00bfa5',
+        cursor: 'pointer',
+        float: 'left',
+    },
+    backButtonHidden: {
+        display: 'none',
+    },
     dataWrapper: {
         minHeight: '500px'
     },
@@ -86,7 +95,8 @@ const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
     },
     searchWrapper: {
         display: 'inline-block',
-        marginBottom: '1rem'
+        marginBottom: '1rem',
+        marginLeft: '1rem',
     },
     searchWrapperHidden: {
         width: '0px'
@@ -122,11 +132,11 @@ const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
         whiteSpace: 'nowrap',
         position: 'relative',
         backgroundColor: '#fff',
-        boxShadow: '0px 1px 3px 0px rgb(0 0 0 / 20%), 0px 1px 1px 0px rgb(0 0 0 / 14%), 0px 2px 1px -1px rgb(0 0 0 / 12%)',
+        boxShadow: '0px 3px 3px 0px rgb(0 0 0 / 20%), 0px 3px 1px 0px rgb(0 0 0 / 14%), 0px 3px 1px -1px rgb(0 0 0 / 12%)',
     },
     leftPanelVisible: {
         opacity: 1,
-        flex: '30%',
+        flex: '50%',
         animation: `animateVisible 1000ms ${theme.transitions.easing.easeOut}`
     },
     leftPanelHidden: {
@@ -142,15 +152,17 @@ const styles: StyleRulesCallback<CssRules> = (theme: Theme) => ({
         },
         "100%": {
             opacity: 1,
-            flex: '30%',
+            flex: '50%',
         }
     },
     rightPanel: {
-        flex: '70%',
+        flex: '50%',
         padding: '1rem',
+        paddingTop: '2rem',
+        marginTop: '-1rem',
         position: 'relative',
         backgroundColor: '#fff',
-        boxShadow: '0px 1px 3px 0px rgb(0 0 0 / 20%), 0px 1px 1px 0px rgb(0 0 0 / 14%), 0px 2px 1px -1px rgb(0 0 0 / 12%)',
+        boxShadow: '0px 3px 3px 0px rgb(0 0 0 / 20%), 0px 3px 1px 0px rgb(0 0 0 / 14%), 0px 3px 1px -1px rgb(0 0 0 / 12%)',
     },
     pathPanelItem: {
         cursor: 'pointer',
@@ -189,14 +201,14 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
     const [path, setPath]: any = React.useState([]);
     const [pathData, setPathData]: any = React.useState({});
     const [isLoading, setIsLoading] = React.useState(false);
-    const [rightClickUsed, setRightClickUsed] = React.useState(false);
+    const [collectionAutofetchEnabled, setCollectionAutofetchEnabled] = React.useState(false);
     const [leftSearch, setLeftSearch] = React.useState('');
     const [rightSearch, setRightSearch] = React.useState('');
 
     const leftKey = (path.length > 1 ? path.slice(0, path.length - 1) : path).join('/');
     const rightKey = path.join('/');
 
-    const leftData = (pathData[leftKey] || []).filter(({ type }) => type === 'directory');
+    const leftData = pathData[leftKey] || [];
     const rightData = pathData[rightKey];
 
     React.useEffect(() => {
@@ -269,7 +281,7 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
     React.useEffect(() => {
         const hash = (collectionPanel.item || {}).portableDataHash;
 
-        if (hash && rightClickUsed) {
+        if (hash && collectionAutofetchEnabled) {
             fetchData([leftKey, rightKey], true);
         }
     }, [(collectionPanel.item || {}).portableDataHash]); // eslint-disable-line react-hooks/exhaustive-deps
@@ -290,18 +302,22 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                 elem = elem.parentNode;
             }
 
-            if (!elem) {
+            if (!elem || !elem.dataset) {
                 return;
             }
 
             const { id } = elem.dataset;
-            const item: any = { id, data: rightData.find((elem) => elem.id === id) };
+
+            const item: any = {
+                id,
+                data: rightData.find((elem) => elem.id === id),
+            };
 
             if (id) {
                 onItemMenuOpen(event, item, isWritable);
 
-                if (!rightClickUsed) {
-                    setRightClickUsed(true);
+                if (!collectionAutofetchEnabled) {
+                    setCollectionAutofetchEnabled(true);
                 }
             }
         },
@@ -344,7 +360,7 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                     setPath([...path.slice(0, index + 1)]);
                 }
 
-                if (parentPath) {
+                if (parentPath && type === 'directory') {
                     if (path.length > 1) {
                         path.pop()
                     }
@@ -355,6 +371,13 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                 if (subfolderPath && type === 'directory') {
                     setPath([...path, subfolderPath]);
                 }
+
+                if (elem.dataset.id && type === 'file') {
+                    const item = rightData.find(({id}) => id === elem.dataset.id) || leftData.find(({ id }) => id === elem.dataset.id);
+                    const enhancedItem = servicesProvider.getServices().collectionService.extendFileURL(item);
+                    const fileUrl = sanitizeToken(getInlineFileUrl(enhancedItem.url, config.keepWebServiceUrl, config.keepWebInlineServiceUrl), true);
+                    window.open(fileUrl, '_blank');
+                }
             }
 
             if (isCheckbox) {
@@ -414,20 +437,30 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                                 className={classes.pathPanelItem}
                                 data-breadcrumb-path={p}
                             >
-                                {index === 0 ? 'Home' : p} /&nbsp;
+                                <span className={classes.rowActive}>{index === 0 ? 'Home' : p}</span> <b>/</b>&nbsp;
                             </span>)
                     }
                 </div>
                 <Tooltip className={classes.pathPanelMenu} title="More options" disableFocusListener>
                     <IconButton
                         data-cy='collection-files-panel-options-btn'
-                        onClick={(ev) => onOptionsMenuOpen(ev, isWritable)}>
+                        onClick={(ev) => {
+                            if (!collectionAutofetchEnabled) {
+                                setCollectionAutofetchEnabled(true);
+                            }
+                            onOptionsMenuOpen(ev, isWritable);
+                        }}>
                         <CustomizeTableIcon />
                     </IconButton>
                 </Tooltip>
             </div>
             <div className={classes.wrapper}>
                 <div className={classNames(classes.leftPanel, path.length > 1 ? classes.leftPanelVisible : classes.leftPanelHidden)}>
+                    <Tooltip title="Go back" className={path.length > 1 ? classes.backButton : classes.backButtonHidden}>
+                        <IconButton onClick={() => setPath([...path.slice(0, path.length -1)])}>
+                            <BackIcon />
+                        </IconButton>
+                    </Tooltip>
                     <div className={path.length > 1 ? classes.searchWrapper : classes.searchWrapperHidden}>
                         <SearchInput label="Search" value={leftSearch} onSearch={setLeftSearch} />
                     </div>
@@ -449,11 +482,21 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                                                     const { id, type, name } = filtered[index];
 
                                                     return <div
+                                                        data-id={id}
                                                         style={style}
                                                         data-item="true"
+                                                        data-type={type}
                                                         data-parent-path={name}
                                                         className={classNames(classes.row, getActiveClass(name))}
-                                                        key={id}>{getItemIcon(type, getActiveClass(name))} <div className={classes.rowName}>{name}</div>
+                                                        key={id}>
+                                                            {getItemIcon(type, getActiveClass(name))}
+                                                            <div className={classes.rowName}>
+                                                                {name}
+                                                            </div>
+                                                            {
+                                                                getActiveClass(name) ? <SidePanelRightArrowIcon
+                                                                    style={{ display: 'inline', marginTop: '5px', marginLeft: '5px' }} /> : null
+                                                            }
                                                     </div>;
                                                 }
                                             }
@@ -473,7 +516,12 @@ export const CollectionPanelFiles = withStyles(styles)(connect((state: RootState
                         <Button
                             className={classes.uploadButton}
                             data-cy='upload-button'
-                            onClick={onUploadDataClick}
+                            onClick={() => {
+                                if (!collectionAutofetchEnabled) {
+                                    setCollectionAutofetchEnabled(true);
+                                }
+                                onUploadDataClick();
+                            }}
                             variant='contained'
                             color='primary'
                             size='small'>