X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/3e1c43866e5b523c3f1d273c25942ad56dc66d3f..37d9f94b06ff367a3514b58ec6f0e4d4d0116030:/services/keep-web/main.go

diff --git a/services/keep-web/main.go b/services/keep-web/main.go
index d09fce706c..aa97a18ad8 100644
--- a/services/keep-web/main.go
+++ b/services/keep-web/main.go
@@ -7,53 +7,41 @@ package main
 import (
 	"flag"
 	"fmt"
+	"mime"
 	"os"
-	"time"
 
-	"git.curoverse.com/arvados.git/sdk/go/arvados"
-	"git.curoverse.com/arvados.git/sdk/go/config"
-	log "github.com/Sirupsen/logrus"
+	"git.arvados.org/arvados.git/lib/cmd"
+	"git.arvados.org/arvados.git/lib/config"
+	"git.arvados.org/arvados.git/sdk/go/arvados"
 	"github.com/coreos/go-systemd/daemon"
+	"github.com/ghodss/yaml"
+	"github.com/sirupsen/logrus"
+	log "github.com/sirupsen/logrus"
 )
 
 var (
-	defaultConfigPath = "/etc/arvados/keep-web/keep-web.yml"
-	version           = "dev"
+	version = "dev"
 )
 
 // Config specifies server configuration.
 type Config struct {
-	Client arvados.Client
-
-	Listen string
-
-	AnonymousTokens    []string
-	AttachmentOnlyHost string
-	TrustAllContent    bool
-
-	Cache cache
-
-	// Hack to support old command line flag, which is a bool
-	// meaning "get actual token from environment".
-	deprecatedAllowAnonymous bool
-
-	//Authorization token to be included in all health check requests.
-	ManagementToken string
+	Client  arvados.Client
+	Cache   cache
+	cluster *arvados.Cluster
 }
 
-// DefaultConfig returns the default configuration.
-func DefaultConfig() *Config {
-	return &Config{
-		Listen: ":80",
-		Cache: cache{
-			TTL:                  arvados.Duration(5 * time.Minute),
-			UUIDTTL:              arvados.Duration(5 * time.Second),
-			MaxCollectionEntries: 1000,
-			MaxCollectionBytes:   100000000,
-			MaxPermissionEntries: 1000,
-			MaxUUIDEntries:       1000,
-		},
+func newConfig(logger logrus.FieldLogger, arvCfg *arvados.Config) *Config {
+	cfg := Config{}
+	var cls *arvados.Cluster
+	var err error
+	if cls, err = arvCfg.GetCluster(""); err != nil {
+		log.Fatal(err)
 	}
+	cfg.cluster = cls
+	cfg.Cache.config = &cfg.cluster.Collections.WebDAVCache
+	cfg.Cache.cluster = cls
+	cfg.Cache.logger = logger
+	return &cfg
 }
 
 func init() {
@@ -71,59 +59,62 @@ func init() {
 	})
 }
 
-func main() {
-	cfg := DefaultConfig()
-
-	var configPath string
-	deprecated := " (DEPRECATED -- use config file instead)"
-	flag.StringVar(&configPath, "config", defaultConfigPath,
-		"`path` to JSON or YAML configuration file")
-	flag.StringVar(&cfg.Listen, "listen", "",
-		"address:port or :port to listen on"+deprecated)
-	flag.BoolVar(&cfg.deprecatedAllowAnonymous, "allow-anonymous", false,
-		"Load an anonymous token from the ARVADOS_API_TOKEN environment variable"+deprecated)
-	flag.StringVar(&cfg.AttachmentOnlyHost, "attachment-only-host", "",
-		"Only serve attachments at the given `host:port`"+deprecated)
-	flag.BoolVar(&cfg.TrustAllContent, "trust-all-content", false,
-		"Serve non-public content from a single origin. Dangerous: read docs before using!"+deprecated)
-	flag.StringVar(&cfg.ManagementToken, "management-token", "",
-		"Authorization token to be included in all health check requests.")
-
-	dumpConfig := flag.Bool("dump-config", false,
+func configure(logger log.FieldLogger, args []string) (*Config, error) {
+	flags := flag.NewFlagSet(args[0], flag.ContinueOnError)
+
+	loader := config.NewLoader(os.Stdin, logger)
+	loader.SetupFlags(flags)
+
+	dumpConfig := flags.Bool("dump-config", false,
 		"write current configuration to stdout and exit")
-	getVersion := flag.Bool("version", false,
+	getVersion := flags.Bool("version", false,
 		"print version information and exit.")
-	flag.Usage = usage
-	flag.Parse()
 
-	// Print version information if requested
-	if *getVersion {
-		fmt.Printf("keep-web %s\n", version)
-		return
+	prog := args[0]
+	args = loader.MungeLegacyConfigArgs(logger, args[1:], "-legacy-keepweb-config")
+	if ok, code := cmd.ParseFlags(flags, prog, args, "", os.Stderr); !ok {
+		os.Exit(code)
+	} else if *getVersion {
+		fmt.Printf("%s %s\n", args[0], version)
+		return nil, nil
 	}
 
-	if err := config.LoadFile(cfg, configPath); err != nil {
-		if h := os.Getenv("ARVADOS_API_HOST"); h != "" && configPath == defaultConfigPath {
-			log.Printf("DEPRECATED: Using ARVADOS_API_HOST environment variable. Use config file instead.")
-			cfg.Client.APIHost = h
-		} else {
-			log.Fatal(err)
-		}
-	}
-	if cfg.deprecatedAllowAnonymous {
-		log.Printf("DEPRECATED: Using -allow-anonymous command line flag with ARVADOS_API_TOKEN environment variable. Use config file instead.")
-		cfg.AnonymousTokens = []string{os.Getenv("ARVADOS_API_TOKEN")}
+	arvCfg, err := loader.Load()
+	if err != nil {
+		return nil, err
 	}
+	cfg := newConfig(logger, arvCfg)
 
 	if *dumpConfig {
-		log.Fatal(config.DumpAndExit(cfg))
+		out, err := yaml.Marshal(cfg)
+		if err != nil {
+			return nil, err
+		}
+		_, err = os.Stdout.Write(out)
+		return nil, err
+	}
+	return cfg, nil
+}
+
+func main() {
+	logger := log.New()
+
+	cfg, err := configure(logger, os.Args)
+	if err != nil {
+		logger.Fatal(err)
+	} else if cfg == nil {
+		return
 	}
 
 	log.Printf("keep-web %s started", version)
 
-	os.Setenv("ARVADOS_API_HOST", cfg.Client.APIHost)
+	if ext := ".txt"; mime.TypeByExtension(ext) == "" {
+		log.Warnf("cannot look up MIME type for %q -- this probably means /etc/mime.types is missing -- clients will see incorrect content types", ext)
+	}
+
+	os.Setenv("ARVADOS_API_HOST", cfg.cluster.Services.Controller.ExternalURL.Host)
 	srv := &server{Config: cfg}
-	if err := srv.Start(); err != nil {
+	if err := srv.Start(logrus.StandardLogger()); err != nil {
 		log.Fatal(err)
 	}
 	if _, err := daemon.SdNotify(false, "READY=1"); err != nil {