X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/3ce8039e7ca278e4816ca90cd973bdbe08404b87..a4211acb465bd42869bf2a2f9fad6ff2c5e518e0:/services/keepstore/logging_router.go diff --git a/services/keepstore/logging_router.go b/services/keepstore/logging_router.go index 251da3ad09..e30df87632 100644 --- a/services/keepstore/logging_router.go +++ b/services/keepstore/logging_router.go @@ -7,39 +7,45 @@ import ( "github.com/gorilla/mux" "log" "net/http" + "strings" ) type LoggingResponseWriter struct { - Status int - Length int - http.ResponseWriter + Status int + Length int + http.ResponseWriter + ResponseBody string } func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) { - loggingWriter.Status = code - loggingWriter.ResponseWriter.WriteHeader(code) + loggingWriter.Status = code + loggingWriter.ResponseWriter.WriteHeader(code) } -func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error){ - loggingWriter.Length = len(data) - return loggingWriter.ResponseWriter.Write(data) +func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) { + loggingWriter.Length += len(data) + if loggingWriter.Status >= 400 { + loggingWriter.ResponseBody += string(data) + } + return loggingWriter.ResponseWriter.Write(data) } type LoggingRESTRouter struct { - router *mux.Router + router *mux.Router } -func MakeLoggingRESTRouter() (*LoggingRESTRouter) { - router := MakeRESTRouter() - return (&LoggingRESTRouter{router}) +func MakeLoggingRESTRouter() *LoggingRESTRouter { + router := MakeRESTRouter() + return (&LoggingRESTRouter{router}) } func (loggingRouter *LoggingRESTRouter) ServeHTTP(resp http.ResponseWriter, req *http.Request) { - loggingWriter := LoggingResponseWriter{200, 0, resp} - loggingRouter.router.ServeHTTP(&loggingWriter, req) - if loggingWriter.Status == 200 { - log.Printf("[%s] %s %s %d %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length) - } else { - log.Printf("[%s] %s %s %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status) - } + loggingWriter := LoggingResponseWriter{200, 0, resp, ""} + loggingRouter.router.ServeHTTP(&loggingWriter, req) + statusText := "OK" + if loggingWriter.Status >= 400 { + statusText = strings.Replace(loggingWriter.ResponseBody, "\n", "", -1) + } + log.Printf("[%s] %s %s %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length, statusText) + }