X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/3c2372f03566fb3ce53625d3e4783eaac0fc480e..f8e6cb30ca6a3cdb20be47f7a81663d4affd0b7f:/apps/workbench/test/integration/anonymous_access_test.rb?ds=sidebyside diff --git a/apps/workbench/test/integration/anonymous_access_test.rb b/apps/workbench/test/integration/anonymous_access_test.rb index c6ba020495..1b187e7b05 100644 --- a/apps/workbench/test/integration/anonymous_access_test.rb +++ b/apps/workbench/test/integration/anonymous_access_test.rb @@ -186,7 +186,8 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest [ ['pipeline_in_publicly_accessible_project', true], ['pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', false], - ['pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', false, 'admin'], + ['pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', false, 'spectator'], + ['pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', true, 'admin'], ['completed_job_in_publicly_accessible_project', true], ['job_in_publicly_accessible_project_but_other_objects_elsewhere', false], @@ -211,10 +212,10 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest # click job link, if in pipeline page click_link 'foo' if pipeline_page - if objects_readable or user + if objects_readable if pipeline_page assert_text 'This pipeline was created from' - assert_selector 'a', object['components']['foo']['job']['uuid'] + assert_selector 'a', text: object['components']['foo']['job']['uuid'] end assert_no_text 'Output data not available' assert_selector 'a[href="#Log"]', text: 'Log' @@ -226,12 +227,11 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest end assert_text 'Output data not available' assert_text object['job'] - assert_selector 'a[href="#Log"]', text: 'Log' assert_selector 'a[data-toggle="disabled"]', text: 'Log' end click_link 'Log' - if objects_readable or user + if objects_readable assert_no_text 'foo' # should be in Log tab assert_text 'stderr crunchstat' if pipeline_page else @@ -239,6 +239,58 @@ class AnonymousAccessTest < ActionDispatch::IntegrationTest assert_no_text 'stderr crunchstat' # log line shouldn't be seen end end + end + + [ + ['new_pipeline_in_publicly_accessible_project', true], + ['new_pipeline_in_publicly_accessible_project', true, 'spectator'], + ['new_pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', false], + ['new_pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', false, 'spectator'], + ['new_pipeline_in_publicly_accessible_project_but_other_objects_elsewhere', true, 'admin'], + ['new_pipeline_in_publicly_accessible_project_with_dataclass_file_and_other_objects_elsewhere', false], + ['new_pipeline_in_publicly_accessible_project_with_dataclass_file_and_other_objects_elsewhere', false, 'spectator'], + ['new_pipeline_in_publicly_accessible_project_with_dataclass_file_and_other_objects_elsewhere', true, 'admin'], + ].each do |fixture, objects_readable, user=nil| + test "access #{fixture} in public project with objects readable=#{objects_readable} with user #{user}" do + object = api_fixture('pipeline_instances')[fixture] + page = "/pipeline_instances/#{object['uuid']}" + if user + visit page_with_token user, page + else + visit page + end + + # click Components tab + click_link 'Components' + + if objects_readable + assert_text 'This pipeline was created from' + if user == 'admin' + assert_text 'input' + assert_selector 'a', text: 'Choose' + assert_selector 'a', text: 'Run' + assert_no_selector 'a.disabled', text: 'Run' + else + assert_selector 'a', text: object['components']['foo']['script_parameters']['input']['value'] + user ? (assert_selector 'a', text: 'Run') : (assert_no_selector 'a', text: 'Run') + end + else + assert_no_text 'This pipeline was created from' # template is not readable + input = object['components']['foo']['script_parameters']['input']['value'] + assert_no_selector 'a', text: input + if user + input = input.gsub('/', '\\/') + assert_text "One or more inputs provided are not readable" + assert_selector "input[type=text][value=#{input}]" + assert_selector 'a.disabled', text: 'Run' + else + assert_no_text "One or more inputs provided are not readable" + assert_text input + assert_no_selector 'a', text: 'Run' + end + end + end + end test "anonymous user accesses collection in shared project" do visit "/collections/#{api_fixture('collections')['public_text_file']['uuid']}"