X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/3aa0915d0b9b0affd9a784df3d138f0d13df303b..fb4921f56d1c13a86add2e59205ec32fa1f6efe4:/services/api/test/unit/user_test.rb diff --git a/services/api/test/unit/user_test.rb b/services/api/test/unit/user_test.rb index 6eb048e871..9bcb0116fb 100644 --- a/services/api/test/unit/user_test.rb +++ b/services/api/test/unit/user_test.rb @@ -7,23 +7,86 @@ class UserTest < ActiveSupport::TestCase setup do # Make sure system_user exists before making "pre-test users" list system_user + end - @all_users = User.find(:all) + [[false, 'foo@example.com', true, nil], + [false, 'bar@example.com', nil, true], + [true, 'foo@example.com', true, nil], + [true, 'bar@example.com', true, true], + [false, false, nil, nil], + [true, false, true, nil] + ].each do |auto_admin_first_user_config, auto_admin_user_config, foo_should_be_admin, bar_should_be_admin| + # In each case, 'foo' is created first, then 'bar', then 'bar2', then 'baz'. + test "auto admin with auto_admin_first=#{auto_admin_first_user_config} auto_admin=#{auto_admin_user_config}" do + + if auto_admin_first_user_config + # This test requires no admin users exist (except for the system user) + users(:admin).delete + @all_users = User.where("uuid not like '%-000000000000000'").where(:is_admin => true).find(:all) + assert_equal 0, @all_users.size, "No admin users should exist (except for the system user)" + end + + Rails.configuration.auto_admin_first_user = auto_admin_first_user_config + Rails.configuration.auto_admin_user = auto_admin_user_config + + # See if the foo user has is_admin + foo = User.new + foo.first_name = 'foo' + foo.email = 'foo@example.com' + + act_as_system_user do + foo.save! + end + + foo = User.find(foo.id) # get the user back + assert_equal foo_should_be_admin, foo.is_admin, "is_admin is wrong for user foo" + assert_equal 'foo', foo.first_name + + # See if the bar user has is_admin + bar = User.new + bar.first_name = 'bar' + bar.email = 'bar@example.com' + + act_as_system_user do + bar.save! + end + + bar = User.find(bar.id) # get the user back + assert_equal bar_should_be_admin, bar.is_admin, "is_admin is wrong for user bar" + assert_equal 'bar', bar.first_name - @all_users.each do |user| - if user.uuid == system_user_uuid - @system_user = user - elsif user.is_admin && user.is_active - @admin_user = user - elsif user.is_active && !user.is_admin - @active_user = user - elsif !user.is_active && !user.is_invited - @uninvited_user = user + # A subsequent user with the bar@example.com address should never be + # elevated to admin + bar2 = User.new + bar2.first_name = 'bar2' + bar2.email = 'bar@example.com' + + act_as_system_user do + bar2.save! + end + + bar2 = User.find(bar2.id) # get the user back + assert !bar2.is_admin, "is_admin is wrong for user bar2" + assert_equal 'bar2', bar2.first_name + + # An ordinary new user should not be elevated to admin + baz = User.new + baz.first_name = 'baz' + baz.email = 'baz@example.com' + + act_as_system_user do + baz.save! end + + baz = User.find(baz.id) # get the user back + assert !baz.is_admin + assert_equal 'baz', baz.first_name + end end test "check non-admin active user properties" do + @active_user = users(:active) # get the active user assert !@active_user.is_admin, 'is_admin should not be set for a non-admin user' assert @active_user.is_active, 'user should be active' assert @active_user.is_invited, 'is_invited should be set' @@ -35,12 +98,14 @@ class UserTest < ActiveSupport::TestCase assert @active_user.groups_i_can(:read).size > 0, "active user should be able read at least one group" # non-admin user cannot manage or write other user objects + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert !(@active_user.can? :read=>"#{@uninvited_user.uuid}") assert !(@active_user.can? :write=>"#{@uninvited_user.uuid}") assert !(@active_user.can? :manage=>"#{@uninvited_user.uuid}") end test "check admin user properties" do + @admin_user = users(:admin) # get the admin user assert @admin_user.is_admin, 'is_admin should be set for admin user' assert @admin_user.is_active, 'admin user cannot be inactive' assert @admin_user.is_invited, 'is_invited should be set' @@ -56,12 +121,14 @@ class UserTest < ActiveSupport::TestCase assert @admin_user.groups_i_can(:manage).size > 0, "admin active user should be able manage at least one group" # admin user can also write or manage other users + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert @admin_user.can? :read=>"#{@uninvited_user.uuid}" assert @admin_user.can? :write=>"#{@uninvited_user.uuid}" assert @admin_user.can? :manage=>"#{@uninvited_user.uuid}" end test "check inactive and uninvited user properties" do + @uninvited_user = users(:inactive_uninvited) # get the uninvited user assert !@uninvited_user.is_admin, 'is_admin should not be set for a non-admin user' assert !@uninvited_user.is_active, 'user should be inactive' assert !@uninvited_user.is_invited, 'is_invited should not be set' @@ -69,7 +136,8 @@ class UserTest < ActiveSupport::TestCase assert @uninvited_user.can? :write=>"#{@uninvited_user.uuid}" assert @uninvited_user.can? :manage=>"#{@uninvited_user.uuid}" - assert @uninvited_user.groups_i_can(:read).size == 0, "inactive and uninvited user should not be able read any groups" + assert @uninvited_user.groups_i_can(:read).size == 1, "inactive and uninvited user can only read anonymous user group" + assert @uninvited_user.groups_i_can(:read).first.ends_with? 'anonymouspublic' , "inactive and uninvited user can only read anonymous user group" assert @uninvited_user.groups_i_can(:write).size == 0, "inactive and uninvited user should not be able write to any groups" assert @uninvited_user.groups_i_can(:manage).size == 0, "inactive and uninvited user should not be able manage any groups" end @@ -87,8 +155,23 @@ class UserTest < ActiveSupport::TestCase assert_equal found_user.identity_url, user.identity_url end + test "full name should not contain spurious whitespace" do + set_user_from_auth :admin + + user = User.create ({uuid: 'zzzzz-tpzed-abcdefghijklmno', email: 'foo@example.com' }) + + assert_equal '', user.full_name + + user.first_name = 'John' + user.last_name = 'Smith' + + assert_equal user.first_name + ' ' + user.last_name, user.full_name + end + test "create new user" do - Thread.current[:user] = @admin_user # set admin user as the current user + set_user_from_auth :admin + + @all_users = User.find(:all) user = User.new user.first_name = "first_name_for_newly_created_user" @@ -109,8 +192,117 @@ class UserTest < ActiveSupport::TestCase assert_equal(user.first_name, 'first_name_for_newly_created_user_updated') end + test "create new user with notifications" do + set_user_from_auth :admin + + create_user_and_verify_setup_and_notifications true, 'active-notify-address@example.com', 'inactive-notify-address@example.com', nil, false + create_user_and_verify_setup_and_notifications true, 'active-notify-address@example.com', [], nil, false + create_user_and_verify_setup_and_notifications true, [], [], nil, false + create_user_and_verify_setup_and_notifications false, 'active-notify-address@example.com', 'inactive-notify-address@example.com', nil, false + create_user_and_verify_setup_and_notifications false, [], 'inactive-notify-address@example.com', nil, false + create_user_and_verify_setup_and_notifications false, [], [], nil, false + end + + [ + [false, [], [], 'inactive-none@example.com', false, false, true], + [false, [], [], 'inactive-vm@example.com', true, false, true], + [false, [], [], 'inactive-repo@example.com', false, true, true], + [false, [], [], 'inactive-both@example.com', true, true, true], + + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'active-none@example.com', false, false, true], + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'active-vm@example.com', true, false, true], + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'active-repo@example.com', false, true, true], + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'active-both@example.com', true, true, true], + + [false, [], [], nil, true, true, false], + + [false, [], [], 'arvados', true, true, false], + [false, [], [], 'arvados', true, false, false], # blacklisted username + [false, [], [], 'arvados', false, false, true], # since we are not creating repo and vm login, this blacklisted name is not a problem + + [false, [], [], 'arvados@example.com', false, false, true], # since we are not creating repo and vm login, this blacklisted name is not a problem + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'arvados@example.com', false, false, true], # since we are not creating repo and vm login, this blacklisted name is not a problem + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'root@example.com', true, false, false], # blacklisted name + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'root@example.com', true, false, false], # blacklisted name + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'roo_t@example.com', false, true, true], # not blacklisted name + + [false, [], [], '@example.com', true, false, false], # incorrect format + [false, [], [], '@example.com', false, true, false], + [false, [], [], '@example.com', false, false, true], # no repo and vm login, so no issue with email format + + [false, [], [], '^^incorrect_format@example.com', true, true, false], + + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_repo@example.com', true, true, true], # existing repository name 'auto_setup_repo' + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_repo@example.com', true, false, true], # existing repository name 'auto_setup_repo' + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_repo@example.com', false, true, true], # existing repository name 'auto_setup_repo' + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_repo@example.com', false, false, true], # existing repository name 'auto_setup_repo', but we are not creating repo or login link + + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_vm_login@example.com', true, true, true], # existing vm login name + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_vm_login@example.com', true, false, true], # existing vm login name + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_vm_login@example.com', false, true, true], # existing vm login name + [false, 'active-notify@example.com', 'inactive-notify@example.com', 'auto_setup_vm_login@example.com', false, false, true], # existing vm login name, but we are not creating repo or login link + + [true, 'active-notify@example.com', 'inactive-notify@example.com', '*!*@example.com', true, false, false], # username is invalid format + [false, 'active-notify@example.com', 'inactive-notify@example.com', '*!*@example.com', false, false, true], # since no repo and vm login, username is ok (not validated) + [true, 'active-notify@example.com', 'inactive-notify@example.com', '*!*@example.com', false, false, true], # since no repo and vm login, username is ok (not validated) + + [true, 'active-notify@example.com', 'inactive-notify@example.com', '&4ad@example.com', true, true, false], # username is invalid format + [true, 'active-notify@example.com', 'inactive-notify@example.com', '&4ad@example.com', false, false, true], # no repo or vm login, so format not checked + [false, 'active-notify@example.com', 'inactive-notify@example.com', '&4ad@example.com', true, true, false], # username is invalid format + [false, 'active-notify@example.com', 'inactive-notify@example.com', '&4ad@example.com', false, false, true], # no repo or vm login, so format not checked + + [true, 'active-notify@example.com', 'inactive-notify@example.com', '4ad@example.com', true, true, false], # username is invalid format + [true, 'active-notify@example.com', 'inactive-notify@example.com', '4ad@example.com', false, false, true], # no repo or vm login, so format not checked + [false, 'active-notify@example.com', 'inactive-notify@example.com', '4ad@example.com', false, false, true], # no repo or vm login, so format not checked + + [true, 'active-notify@example.com', 'inactive-notify@example.com', '.foo@example.com', false, false, true], # no repo or vm login, so format not checked + [true, 'active-notify@example.com', 'inactive-notify@example.com', '.foo@example.com', true, false, false], # invalid format + + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'bar.@example.com', false, false, true], # no repo or vm login, so format not checked + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'bar.@example.com', true, false, false], # valid format + + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'ice9@example.com', false, false, true], # no repo or vm login, so format not checked + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'ice9@example.com', true, false, true], # valid format + + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'o_o@example.com', false, false, true], # no repo or vm login, so format not checked + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'o_o@example.com', true, false, true], # valid format + + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'r00t@example.com', false, false, true], # no repo or vm login, so format not checked + [true, 'active-notify@example.com', 'inactive-notify@example.com', 'r00t@example.com', true, false, true], # valid format + + ].each do |active, new_user_recipients, inactive_recipients, email, auto_setup_vm, auto_setup_repo, ok_to_auto_setup| + test "create new user with auto setup #{active} #{email} #{auto_setup_vm} #{auto_setup_repo}" do + auto_setup_new_users = Rails.configuration.auto_setup_new_users + auto_setup_new_users_with_vm_uuid = Rails.configuration.auto_setup_new_users_with_vm_uuid + auto_setup_new_users_with_repository = Rails.configuration.auto_setup_new_users_with_repository + + begin + set_user_from_auth :admin + + Rails.configuration.auto_setup_new_users = true + + if auto_setup_vm + Rails.configuration.auto_setup_new_users_with_vm_uuid = virtual_machines(:testvm)['uuid'] + else + Rails.configuration.auto_setup_new_users_with_vm_uuid = false + end + + Rails.configuration.auto_setup_new_users_with_repository = auto_setup_repo + + create_user_and_verify_setup_and_notifications active, new_user_recipients, inactive_recipients, email, ok_to_auto_setup + ensure + Rails.configuration.auto_setup_new_users = auto_setup_new_users + Rails.configuration.auto_setup_new_users_with_vm_uuid = auto_setup_new_users_with_vm_uuid + Rails.configuration.auto_setup_new_users_with_repository = auto_setup_new_users_with_repository + end + end + end + test "update existing user" do - Thread.current[:user] = @active_user # set active user as current user + set_user_from_auth :active # set active user as current user + + @active_user = users(:active) # get the active user + @active_user.first_name = "first_name_changed" @active_user.save @@ -118,7 +310,7 @@ class UserTest < ActiveSupport::TestCase assert_equal(@active_user.first_name, 'first_name_changed') # admin user also should be able to update the "active" user info - Thread.current[:user] = @admin_user # set admin user as current user + set_user_from_auth :admin # set admin user as current user @active_user.first_name = "first_name_changed_by_admin_for_active_user" @active_user.save @@ -127,9 +319,10 @@ class UserTest < ActiveSupport::TestCase end test "delete a user and verify" do + @active_user = users(:active) # get the active user active_user_uuid = @active_user.uuid - Thread.current[:user] = @admin_user + set_user_from_auth :admin @active_user.delete found_deleted_user = false @@ -144,7 +337,7 @@ class UserTest < ActiveSupport::TestCase end test "create new user as non-admin user" do - Thread.current[:user] = @active_user + set_user_from_auth :active begin user = User.new @@ -156,7 +349,7 @@ class UserTest < ActiveSupport::TestCase end test "setup new user" do - Thread.current[:user] = @admin_user + set_user_from_auth :admin email = 'foo@example.com' openid_prefix = 'http://openid/prefix' @@ -175,21 +368,21 @@ class UserTest < ActiveSupport::TestCase verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], resp_user[:uuid] - assert_equal openid_prefix, oid_login_perm[:properties][:identity_url_prefix], + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], 'expected identity_url_prefix not found for oid_login_perm' group_perm = find_obj_in_resp response, 'Link', 'arvados#group' verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid end test "setup new user with junk in database" do - Thread.current[:user] = @admin_user + set_user_from_auth :admin email = 'foo@example.com' openid_prefix = 'http://openid/prefix' @@ -217,23 +410,21 @@ class UserTest < ActiveSupport::TestCase verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], resp_user[:uuid] - assert_equal openid_prefix, oid_login_perm[:properties][:identity_url_prefix], + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], 'expected identity_url_prefix not found for oid_login_perm' group_perm = find_obj_in_resp response, 'Link', 'arvados#group' verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid end - - test "setup new user in multiple steps" do - Thread.current[:user] = @admin_user + set_user_from_auth :admin email = 'foo@example.com' openid_prefix = 'http://openid/prefix' @@ -248,7 +439,7 @@ class UserTest < ActiveSupport::TestCase oid_login_perm = find_obj_in_resp response, 'Link', 'arvados#user' verify_link oid_login_perm, 'permission', 'can_login', resp_user[:email], resp_user[:uuid] - assert_equal openid_prefix, oid_login_perm[:properties][:identity_url_prefix], + assert_equal openid_prefix, oid_login_perm[:properties]['identity_url_prefix'], 'expected identity_url_prefix not found for oid_login_perm' group_perm = find_obj_in_resp response, 'Link', 'arvados#group' @@ -264,7 +455,7 @@ class UserTest < ActiveSupport::TestCase verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil # invoke setup again with a vm_uuid vm = VirtualMachine.create @@ -279,7 +470,7 @@ class UserTest < ActiveSupport::TestCase verify_link group_perm, 'permission', 'can_read', resp_user[:uuid], nil repo_perm = find_obj_in_resp response, 'Link', 'arvados#repository' - verify_link repo_perm, 'permission', 'can_write', resp_user[:uuid], nil + verify_link repo_perm, 'permission', 'can_manage', resp_user[:uuid], nil vm_perm = find_obj_in_resp response, 'Link', 'arvados#virtualMachine' verify_link vm_perm, 'permission', 'can_login', resp_user[:uuid], vm.uuid @@ -330,4 +521,137 @@ class UserTest < ActiveSupport::TestCase end end + def create_user_and_verify_setup_and_notifications (active, new_user_recipients, inactive_recipients, email, ok_to_auto_setup) + Rails.configuration.new_user_notification_recipients = new_user_recipients + Rails.configuration.new_inactive_user_notification_recipients = inactive_recipients + + assert_equal new_user_recipients, Rails.configuration.new_user_notification_recipients + assert_equal inactive_recipients, Rails.configuration.new_inactive_user_notification_recipients + + ActionMailer::Base.deliveries = [] + + user = User.new + user.first_name = "first_name_for_newly_created_user" + user.email = email + user.is_active = active + user.save! + + # check user setup + group = Group.where(name: 'All users').select do |g| + g[:uuid].match /-f+$/ + end.first + + if !Rails.configuration.auto_setup_new_users || !ok_to_auto_setup + # verify that the user is not added to "All groups" by auto_setup + verify_link_exists false, group[:uuid], user.uuid, 'permission', 'can_read', nil, nil + + # check oid login link not created by auto_setup + verify_link_exists false, user.uuid, user.email, 'permission', 'can_login', nil, nil + else + # verify that auto_setup took place + # verify that the user is added to "All groups" + verify_link_exists true, group[:uuid], user.uuid, 'permission', 'can_read', nil, nil + + # check oid login link + verify_link_exists true, user.uuid, user.email, 'permission', 'can_login', nil, nil + + username = user.email.partition('@')[0] if email + + # check repo + repo_names = [] + if Rails.configuration.auto_setup_new_users_with_repository + repos = Repository.where('name like ?', "%#{username}%") + assert_not_nil repos, 'repository not found' + assert_equal true, repos.any?, 'repository not found' + repo_uuids = [] + repos.each do |repo| + repo_uuids << repo[:uuid] + repo_names << repo[:name] + end + if username == 'auto_setup_repo' + begin + repo_names.delete('auto_setup_repo') + ensure + assert_equal true, repo_names.any?, 'Repository name for username foo is not unique' + end + end + verify_link_exists true, repo_uuids, user.uuid, 'permission', 'can_manage', nil, nil + end + + # if username is existing vm login name, make sure the username used to generate any repo is unique + if username == 'auto_setup_vm_login' || username == 'auto_setup_repo' + if repo_names.any? + assert repo_names.first.start_with? username + assert_not_nil /\d$/.match(repo_names.first) + end + end + + # check vm uuid + vm_uuid = Rails.configuration.auto_setup_new_users_with_vm_uuid + if vm_uuid + verify_link_exists true, vm_uuid, user.uuid, 'permission', 'can_login', 'username', (username == 'auto_setup_repo' ? repo_names.first : username) + else + verify_link_exists false, vm_uuid, user.uuid, 'permission', 'can_login', 'username', (username == 'auto_setup_repo' ? repo_names.first : username) + end + end + + # check email notifications + new_user_email = nil + new_inactive_user_email = nil + + new_user_email_subject = "#{Rails.configuration.email_subject_prefix}New user created notification" + if Rails.configuration.auto_setup_new_users + new_user_email_subject = (ok_to_auto_setup || active) ? + "#{Rails.configuration.email_subject_prefix}New user created and setup notification" : + "#{Rails.configuration.email_subject_prefix}New user created, but not setup notification" + end + + ActionMailer::Base.deliveries.each do |d| + if d.subject == new_user_email_subject then + new_user_email = d + elsif d.subject == "#{Rails.configuration.email_subject_prefix}New inactive user notification" then + new_inactive_user_email = d + end + end + + # both active and inactive user creations should result in new user creation notification mails, + # if the new user email recipients config parameter is set + if not new_user_recipients.empty? then + assert_not_nil new_user_email, 'Expected new user email after setup' + assert_equal Rails.configuration.user_notifier_email_from, new_user_email.from[0] + assert_equal new_user_recipients, new_user_email.to[0] + assert_equal new_user_email_subject, new_user_email.subject + else + assert_nil new_user_email, 'Did not expect new user email after setup' + end + + if not active + if not inactive_recipients.empty? then + assert_not_nil new_inactive_user_email, 'Expected new inactive user email after setup' + assert_equal Rails.configuration.user_notifier_email_from, new_inactive_user_email.from[0] + assert_equal inactive_recipients, new_inactive_user_email.to[0] + assert_equal "#{Rails.configuration.email_subject_prefix}New inactive user notification", new_inactive_user_email.subject + else + assert_nil new_inactive_user_email, 'Did not expect new inactive user email after setup' + end + else + assert_nil new_inactive_user_email, 'Expected no inactive user email after setting up active user' + end + ActionMailer::Base.deliveries = [] + + end + + def verify_link_exists link_exists, head_uuid, tail_uuid, link_class, link_name, property_name, property_value + all_links = Link.where(head_uuid: head_uuid, + tail_uuid: tail_uuid, + link_class: link_class, + name: link_name) + assert_equal link_exists, all_links.any?, "Link #{'not' if link_exists} found for #{link_name} #{link_class} #{property_value}" + if link_exists && property_name && property_value + all_links.each do |link| + assert_equal true, all_links.first.properties[property_name].start_with?(property_value), 'Property not found in link' + end + end + end + end