X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/310f6c81aad96a063f798d5940853dfad3409bba..d047c1cb9ceecb6e324adf102e5e38e11fe698e1:/apps/workbench/app/controllers/application_controller.rb diff --git a/apps/workbench/app/controllers/application_controller.rb b/apps/workbench/app/controllers/application_controller.rb index 696e821607..5acf9a7351 100644 --- a/apps/workbench/app/controllers/application_controller.rb +++ b/apps/workbench/app/controllers/application_controller.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + class ApplicationController < ActionController::Base include ArvadosApiClientHelper include ApplicationHelper @@ -7,11 +11,13 @@ class ApplicationController < ActionController::Base ERROR_ACTIONS = [:render_error, :render_not_found] + prepend_before_filter :set_current_request_id, except: ERROR_ACTIONS around_filter :thread_clear around_filter :set_thread_api_token # Methods that don't require login should # skip_around_filter :require_thread_api_token around_filter :require_thread_api_token, except: ERROR_ACTIONS + before_filter :ensure_arvados_api_exists, only: [:index, :show] before_filter :set_cache_buster before_filter :accept_uuid_as_id_param, except: ERROR_ACTIONS before_filter :check_user_agreements, except: ERROR_ACTIONS @@ -89,11 +95,13 @@ class ApplicationController < ActionController::Base # exception here than in a template.) unless current_user.nil? begin + my_starred_projects current_user build_my_wanted_projects_tree current_user rescue ArvadosApiClient::ApiError # Fall back to the default-setting code later. end end + @starred_projects ||= [] @my_wanted_projects_tree ||= [] render_error(err_opts) end @@ -113,7 +121,7 @@ class ApplicationController < ActionController::Base # Column names should always be qualified by a table name and a direction is optional, defaulting to asc # (e.g. "collections.name" or "collections.name desc"). # If a column name is specified, that table will be sorted by that column. - # If there are objects from different models that will be shown (such as in Jobs and Pipelines tab), + # If there are objects from different models that will be shown (such as in Pipelines and processes tab), # then a sort column name can optionally be specified for each model, passed as an comma-separated list (e.g. "jobs.script, pipeline_instances.name") # Currently only one sort column name and direction can be specified for each model. def load_filters_and_paging_params @@ -210,6 +218,13 @@ class ApplicationController < ActionController::Base end end + def ensure_arvados_api_exists + if model_class.is_a?(Class) && model_class < ArvadosBase && !model_class.api_exists?(params['action'].to_sym) + @errors = ["#{params['action']} method is not supported for #{params['controller']}"] + return render_error(status: 404) + end + end + def index find_objects_for_index if !@objects render_index @@ -221,11 +236,18 @@ class ApplicationController < ActionController::Base objects = @objects end if objects.respond_to?(:result_offset) and - objects.respond_to?(:result_limit) and - objects.respond_to?(:items_available) + objects.respond_to?(:result_limit) next_offset = objects.result_offset + objects.result_limit - if next_offset < objects.items_available + if objects.respond_to?(:items_available) and (next_offset < objects.items_available) next_offset + elsif @objects.results.size > 0 and (params[:count] == 'none' or + (params[:controller] == 'search' and params[:action] == 'choose')) + last_object_class = @objects.last.class + if params['last_object_class'].nil? or params['last_object_class'] == last_object_class.to_s + next_offset + else + @objects.select{|obj| obj.class == last_object_class}.size + end else nil end @@ -239,6 +261,28 @@ class ApplicationController < ActionController::Base end end + helper_method :next_page_filters + def next_page_filters nextpage_operator + next_page_filters = @filters.reject do |attr, op, val| + (attr == 'created_at' and op == nextpage_operator) or + (attr == 'uuid' and op == 'not in') + end + + if @objects.any? + last_created_at = @objects.last.created_at + + last_uuids = [] + @objects.each do |obj| + last_uuids << obj.uuid if obj.created_at.eql?(last_created_at) + end + + next_page_filters += [['created_at', nextpage_operator, last_created_at]] + next_page_filters += [['uuid', 'not in', last_uuids]] + end + + next_page_filters + end + def show if !@object return render_not_found("object not found") @@ -443,6 +487,15 @@ class ApplicationController < ActionController::Base end end + helper_method :is_starred + def is_starred + links = Link.where(tail_uuid: current_user.uuid, + head_uuid: @object.uuid, + link_class: 'star') + + return links.andand.any? + end + protected helper_method :strip_token_from_path @@ -492,16 +545,17 @@ class ApplicationController < ActionController::Base begin if not model_class @object = nil + elsif params[:uuid].nil? or params[:uuid].empty? + @object = nil elsif not params[:uuid].is_a?(String) @object = model_class.where(uuid: params[:uuid]).first - elsif params[:uuid].empty? - @object = nil elsif (model_class != Link and resource_class_for_uuid(params[:uuid]) == Link) @name_link = Link.find(params[:uuid]) @object = model_class.find(@name_link.head_uuid) else @object = model_class.find(params[:uuid]) + load_preloaded_objects [@object] end rescue ArvadosApiClient::NotFoundException, ArvadosApiClient::NotLoggedInException, RuntimeError => error if error.is_a?(RuntimeError) and (error.message !~ /^argument to find\(/) @@ -725,7 +779,11 @@ class ApplicationController < ActionController::Base } @@notification_tests.push lambda { |controller, current_user| - PipelineInstance.limit(1).where(created_by: current_user.uuid).each do + if PipelineInstance.api_exists?(:index) + PipelineInstance.limit(1).where(created_by: current_user.uuid).each do + return nil + end + else return nil end return lambda { |view| @@ -735,7 +793,7 @@ class ApplicationController < ActionController::Base helper_method :user_notifications def user_notifications - return [] if @errors or not current_user.andand.is_active + return [] if @errors or not current_user.andand.is_active or not Rails.configuration.show_user_notifications @notifications ||= @@notification_tests.map do |t| t.call(self, current_user) end.compact @@ -817,14 +875,26 @@ class ApplicationController < ActionController::Base pi end - helper_method :finished_pipelines - def finished_pipelines lim - PipelineInstance.limit(lim).order(["finished_at desc"]).filter([["state", "in", ["Complete", "Failed", "Paused"]], ["finished_at", "!=", nil]]) + helper_method :recent_processes + def recent_processes lim + lim = 12 if lim.nil? + + procs = {} + if PipelineInstance.api_exists?(:index) + cols = %w(uuid owner_uuid created_at modified_at pipeline_template_uuid name state started_at finished_at) + pipelines = PipelineInstance.select(cols).limit(lim).order(["created_at desc"]) + pipelines.results.each { |pi| procs[pi] = pi.created_at } + end + + crs = ContainerRequest.limit(lim).order(["created_at desc"]).filter([["requesting_container_uuid", "=", nil]]) + crs.results.each { |c| procs[c] = c.created_at } + + Hash[procs.sort_by {|key, value| value}].keys.reverse.first(lim) end helper_method :recent_collections def recent_collections lim - c = Collection.limit(lim).order(["modified_at desc"]).filter([["owner_uuid", "is_a", "arvados#group"]]) + c = Collection.limit(lim).order(["modified_at desc"]).results own = {} Group.filter([["uuid", "in", c.map(&:owner_uuid)]]).each do |g| own[g[:uuid]] = g @@ -832,51 +902,62 @@ class ApplicationController < ActionController::Base {collections: c, owners: own} end + helper_method :my_starred_projects + def my_starred_projects user + return if @starred_projects + links = Link.filter([['tail_uuid', '=', user.uuid], + ['link_class', '=', 'star'], + ['head_uuid', 'is_a', 'arvados#group']]).select(%w(head_uuid)) + uuids = links.collect { |x| x.head_uuid } + starred_projects = Group.filter([['uuid', 'in', uuids]]).order('name') + @starred_projects = starred_projects.results + end + # If there are more than 200 projects that are readable by the user, - # build the tree using only the top 200+ projects owned by the user. + # build the tree using only the top 200+ projects owned by the user, + # from the top three levels. # That is: get toplevel projects under home, get subprojects of - # these projects, and so on until we hit the limit - def my_wanted_projects page_size=100 + # these projects, and so on until we hit the limit. + def my_wanted_projects(user, page_size=100) return @my_wanted_projects if @my_wanted_projects - all = Group.filter([['group_class','=','project']]).order('name').limit(page_size) - if all.items_available > page_size*3 - @total_projects = all.items_available - from_top = [] - uuids = [current_user.uuid] - while from_top.size <= page_size*2 - current_level = Group.filter([['group_class','=','project'], - ['owner_uuid', 'in', uuids]]) - .order('name').limit(page_size*2) - break if current_level.results.size == 0 - from_top.concat current_level.results - uuids = current_level.results.collect { |x| x.uuid } - end - @my_wanted_projects = from_top - else - if all.results.size == all.items_available - @my_wanted_projects = all - else - @my_wanted_projects = Group.filter([['group_class','=','project']]).order('name') + from_top = [] + uuids = [user.uuid] + depth = 0 + @too_many_projects = false + @reached_level_limit = false + while from_top.size <= page_size*2 + current_level = Group.filter([['group_class','=','project'], + ['owner_uuid', 'in', uuids]]) + .order('name').limit(page_size*2) + break if current_level.results.size == 0 + @too_many_projects = true if current_level.items_available > current_level.results.size + from_top.concat current_level.results + uuids = current_level.results.collect(&:uuid) + depth += 1 + if depth >= 3 + @reached_level_limit = true + break end end + @my_wanted_projects = from_top end helper_method :my_wanted_projects_tree - def my_wanted_projects_tree user, page_size=100 - build_my_wanted_projects_tree user, page_size - [@my_wanted_projects_tree, @total_projects] + def my_wanted_projects_tree(user, page_size=100) + build_my_wanted_projects_tree(user, page_size) + [@my_wanted_projects_tree, @too_many_projects, @reached_level_limit] end - def build_my_wanted_projects_tree user, page_size=100 + def build_my_wanted_projects_tree(user, page_size=100) return @my_wanted_projects_tree if @my_wanted_projects_tree parent_of = {user.uuid => 'me'} - my_wanted_projects(page_size).each do |ob| + my_wanted_projects(user, page_size).each do |ob| parent_of[ob.uuid] = ob.owner_uuid end children_of = {false => [], 'me' => [user]} - my_wanted_projects(page_size).each do |ob| + my_wanted_projects(user, page_size).each do |ob| if ob.owner_uuid != user.uuid and not parent_of.has_key? ob.owner_uuid parent_of[ob.uuid] = false @@ -905,57 +986,6 @@ class ApplicationController < ActionController::Base sorted_paths.call buildtree.call(children_of, 'me') end - helper_method :my_project_tree - def my_project_tree - build_project_trees - @my_project_tree - end - - helper_method :shared_project_tree - def shared_project_tree - build_project_trees - @shared_project_tree - end - - def build_project_trees - return if @my_project_tree and @shared_project_tree - parent_of = {current_user.uuid => 'me'} - all_projects.each do |ob| - parent_of[ob.uuid] = ob.owner_uuid - end - children_of = {false => [], 'me' => [current_user]} - all_projects.each do |ob| - if ob.owner_uuid != current_user.uuid and - not parent_of.has_key? ob.owner_uuid - parent_of[ob.uuid] = false - end - children_of[parent_of[ob.uuid]] ||= [] - children_of[parent_of[ob.uuid]] << ob - end - buildtree = lambda do |children_of, root_uuid=false| - tree = {} - children_of[root_uuid].andand.each do |ob| - tree[ob] = buildtree.call(children_of, ob.uuid) - end - tree - end - sorted_paths = lambda do |tree, depth=0| - paths = [] - tree.keys.sort_by { |ob| - ob.is_a?(String) ? ob : ob.friendly_link_name - }.each do |ob| - paths << {object: ob, depth: depth} - paths += sorted_paths.call tree[ob], depth+1 - end - paths - end - @my_project_tree = - sorted_paths.call buildtree.call(children_of, 'me') - @shared_project_tree = - sorted_paths.call({'Projects shared with me' => - buildtree.call(children_of, false)}) - end - helper_method :get_object def get_object uuid if @get_object.nil? and @objects @@ -1176,15 +1206,15 @@ class ApplicationController < ActionController::Base # helper method to get object of a given dataclass and uuid helper_method :object_for_dataclass - def object_for_dataclass dataclass, uuid + def object_for_dataclass dataclass, uuid, by_attr=nil raise ArgumentError, 'No input argument dataclass' unless (dataclass && uuid) - preload_objects_for_dataclass(dataclass, [uuid]) + preload_objects_for_dataclass(dataclass, [uuid], by_attr) @objects_for[uuid] end # helper method to preload objects for given dataclass and uuids helper_method :preload_objects_for_dataclass - def preload_objects_for_dataclass dataclass, uuids + def preload_objects_for_dataclass dataclass, uuids, by_attr=nil @objects_for ||= {} raise ArgumentError, 'Argument is not a data class' unless dataclass.is_a? Class @@ -1201,13 +1231,86 @@ class ApplicationController < ActionController::Base uuids.each do |x| @objects_for[x] = nil end - dataclass.where(uuid: uuids).each do |obj| - @objects_for[obj.uuid] = obj + if by_attr and ![:uuid, :name].include?(by_attr) + raise ArgumentError, "Preloading only using lookups by uuid or name are supported: #{by_attr}" + elsif by_attr and by_attr == :name + dataclass.where(name: uuids).each do |obj| + @objects_for[obj.name] = obj + end + else + key_prefix = "request_#{Thread.current.object_id}_#{dataclass.to_s}_" + dataclass.where(uuid: uuids).each do |obj| + @objects_for[obj.uuid] = obj + if dataclass == Collection + # The collecions#index defaults to "all attributes except manifest_text" + # Hence, this object is not suitable for preloading the find() cache. + else + Rails.cache.write(key_prefix + obj.uuid, obj.as_json) + end + end end @objects_for end + # helper method to load objects that are already preloaded + helper_method :load_preloaded_objects + def load_preloaded_objects objs + @objects_for ||= {} + objs.each do |obj| + @objects_for[obj.uuid] = obj + end + end + + # helper method to get the names of collection files selected + helper_method :selected_collection_files + def selected_collection_files params + link_uuids, coll_ids = params["selection"].partition do |sel_s| + ArvadosBase::resource_class_for_uuid(sel_s) == Link + end + + unless link_uuids.empty? + Link.select([:head_uuid]).where(uuid: link_uuids).each do |link| + if ArvadosBase::resource_class_for_uuid(link.head_uuid) == Collection + coll_ids << link.head_uuid + end + end + end + + uuids = [] + pdhs = [] + source_paths = Hash.new { |hash, key| hash[key] = [] } + coll_ids.each do |coll_id| + if m = CollectionsHelper.match(coll_id) + key = m[1] + m[2] + pdhs << key + source_paths[key] << m[4] + elsif m = CollectionsHelper.match_uuid_with_optional_filepath(coll_id) + key = m[1] + uuids << key + source_paths[key] << m[4] + end + end + + unless pdhs.empty? + Collection.where(portable_data_hash: pdhs.uniq). + select([:uuid, :portable_data_hash]).each do |coll| + unless source_paths[coll.portable_data_hash].empty? + uuids << coll.uuid + source_paths[coll.uuid] = source_paths.delete(coll.portable_data_hash) + end + end + end + + [uuids, source_paths] + end + def wiselinks_layout 'body' end + + def set_current_request_id + # Request ID format: '-<9_digits_random_number>' + current_request_id = "#{Time.new.to_i}-#{sprintf('%09d', rand(0..10**9-1))}" + Thread.current[:current_request_id] = current_request_id + end end