X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/30a74a09202eedbea5e5c7bd59768e616cd38c79..3bfb9c5cbf5dd56b84fd17f9e1dcdd6a219fe5fe:/apps/workbench/test/integration/application_layout_test.rb

diff --git a/apps/workbench/test/integration/application_layout_test.rb b/apps/workbench/test/integration/application_layout_test.rb
index f231e4d3d4..ba36220717 100644
--- a/apps/workbench/test/integration/application_layout_test.rb
+++ b/apps/workbench/test/integration/application_layout_test.rb
@@ -1,63 +1,74 @@
 require 'integration_helper'
-require 'selenium-webdriver'
-require 'headless'
 
 class ApplicationLayoutTest < ActionDispatch::IntegrationTest
-  setup do
-    headless = Headless.new
-    headless.start
-    Capybara.current_driver = :selenium
-
-    @user_profile_form_fields = Rails.configuration.user_profile_form_fields
-  end
+  # These tests don't do state-changing API calls. Save some time by
+  # skipping the database reset.
+  reset_api_fixtures :after_each_test, false
+  reset_api_fixtures :after_suite, true
 
-  teardown do
-    Rails.configuration.user_profile_form_fields = @user_profile_form_fields
+  setup do
+    need_javascript
   end
 
-  def verify_homepage_with_profile user, invited, has_profile
+  def verify_homepage user, invited, has_profile
     profile_config = Rails.configuration.user_profile_form_fields
 
     if !user
-      assert page.has_text? 'Please log in'
-      assert page.has_text? 'The "Log in" button below will show you a Google sign-in page'
-      assert page.has_no_text? 'My projects'
-      assert page.has_link? "Log in to #{Rails.configuration.site_name}"
-    elsif profile_config && !has_profile && user['is_active']
-      add_profile user
+      assert page.has_text?('Please log in'), 'Not found text - Please log in'
+      assert page.has_text?('The "Log in" button below will show you a Google sign-in page'), 'Not found text - google sign in page'
+      assert page.has_no_text?('My projects'), 'Found text - My projects'
+      assert page.has_link?("Log in to #{Rails.configuration.site_name}"), 'Not found text - log in to'
     elsif user['is_active']
-      assert page.has_text? 'My projects'
-      assert page.has_text? 'Projects shared with me'
-      assert page.has_no_text? 'Save profile'
+      if profile_config && !has_profile
+        assert page.has_text?('Save profile'), 'No text - Save profile'
+      else
+        assert page.has_link?("Projects"), 'Not found link - Projects'
+        page.find("#projects-menu").click
+        assert_selector 'a', text: 'Add a new project'
+        assert_no_selector 'a', text: 'Browse public projects'
+        assert page.has_text?('Projects shared with me'), 'Not found text - Project shared with me'
+      end
     elsif invited
-      assert page.has_text? 'Please check the box below to indicate that you have read and accepted the user agreement'
-      assert page.has_no_text? 'Save profile'
+      assert page.has_text?('Please check the box below to indicate that you have read and accepted the user agreement'), 'Not found text - Please check the box below . . .'
     else
-      assert page.has_text? 'Your account is inactive'
-      assert page.has_no_text? 'Save profile'
+      assert page.has_text?('Your account is inactive'), 'Not found text - Your account is inactive'
     end
 
     within('.navbar-fixed-top') do
       if !user
-        assert page.has_link? 'Log in'
+        assert_text Rails.configuration.site_name.downcase
+        assert_no_selector 'a', text: Rails.configuration.site_name.downcase
+        assert page.has_link?('Log in'), 'Not found link - Log in'
       else
         # my account menu
-        assert page.has_link? "#{user['email']}"
-        find('a', text: "#{user['email']}").click
+        assert_selector 'a', text: Rails.configuration.site_name.downcase
+        assert(page.has_link?("notifications-menu"), 'no user menu')
+        page.find("#notifications-menu").click
         within('.dropdown-menu') do
-          if !invited
-            page.has_no_link? ('Not active')
-          else
-            page.has_no_link? ('Sign agreements')
-            page.has_link? ('Manage account')
+          if user['is_active']
+            assert page.has_no_link?('Not active'), 'Found link - Not active'
+            assert page.has_no_link?('Sign agreements'), 'Found link - Sign agreements'
+
+            assert_selector "a[href=\"/projects/#{user['uuid']}\"]", text: 'Home project'
+            assert_selector "a[href=\"/users/#{user['uuid']}/virtual_machines\"]", text: 'Virtual machines'
+            assert_selector "a[href=\"/users/#{user['uuid']}/repositories\"]", text: 'Repositories'
+            assert_selector "a[href=\"/current_token\"]", text: 'Current token'
+            assert_selector "a[href=\"/users/#{user['uuid']}/ssh_keys\"]", text: 'SSH keys'
 
             if profile_config
-              page.has_link? ('Manage profile')
+              assert_selector "a[href=\"/users/#{user['uuid']}/profile\"]", text: 'Manage profile'
             else
-              page.has_no_link? ('Manage profile')
+              assert_no_selector "a[href=\"/users/#{user['uuid']}/profile\"]", text: 'Manage profile'
             end
+          else
+            assert_no_selector 'a', text: 'Home project'
+            assert page.has_no_link?('Virtual machines'), 'Found link - Virtual machines'
+            assert page.has_no_link?('Repositories'), 'Found link - Repositories'
+            assert page.has_no_link?('Current token'), 'Found link - Current token'
+            assert page.has_no_link?('SSH keys'), 'Found link - SSH keys'
+            assert page.has_no_link?('Manage profile'), 'Found link - Manage profile'
           end
-          page.has_link? ('Log out')
+          assert page.has_link?('Log out'), 'No link - Log out'
         end
       end
     end
@@ -68,187 +79,35 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest
     within('.navbar-fixed-top') do
       page.find("#arv-help").click
       within('.dropdown-menu') do
-        assert page.has_link? 'Tutorials and User guide'
-        assert page.has_link? 'API Reference'
-        assert page.has_link? 'SDK Reference'
+        assert_selector 'a', text:'Getting Started ...'
+        assert_selector 'a', text:'Public Pipelines and Data sets'
+        assert page.has_link?('Tutorials and User guide'), 'No link - Tutorials and User guide'
+        assert page.has_link?('API Reference'), 'No link - API Reference'
+        assert page.has_link?('SDK Reference'), 'No link - SDK Reference'
+        assert page.has_link?('Show version / debugging info ...'), 'No link - Show version / debugging info'
+        assert page.has_link?('Report a problem ...'), 'No link - Report a problem'
+        # Version info and Report a problem are tested in "report_issue_test.rb"
       end
     end
   end
 
   def verify_system_menu user
-    if user && user['is_active']
-      look_for_add_new = nil
+    if user && user['is_admin']
+      assert page.has_link?('system-menu'), 'No link - system menu'
       within('.navbar-fixed-top') do
         page.find("#system-menu").click
-        if user['is_admin']
-          within('.dropdown-menu') do
-            assert page.has_text? 'Groups'
-            assert page.has_link? 'Repositories'
-            assert page.has_link? 'Virtual machines'
-            assert page.has_link? 'SSH keys'
-            assert page.has_link? 'API tokens'
-            find('a', text: 'Users').click
-            look_for_add_new = 'Add a new user'
-          end
-        else
-          within('.dropdown-menu') do
-            assert page.has_no_text? 'Users'
-            assert page.has_no_link? 'Repositories'
-            assert page.has_no_link? 'Virtual machines'
-            assert page.has_no_link? 'SSH keys'
-            assert page.has_no_link? 'API tokens'
-
-            find('a', text: 'Groups').click
-            look_for_add_new = 'Add a new group'
-          end
-        end
-      end
-      if look_for_add_new
-        assert page.has_text? look_for_add_new
-      end
-    else
-      assert page.has_no_link? '#system-menu'
-    end
-  end
-
-  # test manage_account page
-  def verify_manage_account user
-    if user && user['is_active']
-      within('.navbar-fixed-top') do
-        find('a', text: "#{user['email']}").click
         within('.dropdown-menu') do
-          find('a', text: 'Manage account').click
+          assert page.has_text?('Groups'), 'No text - Groups'
+          assert page.has_link?('Repositories'), 'No link - Repositories'
+          assert page.has_link?('Virtual machines'), 'No link - Virtual machines'
+          assert page.has_link?('SSH keys'), 'No link - SSH keys'
+          assert page.has_link?('API tokens'), 'No link - API tokens'
+          find('a', text: 'Users').click
         end
       end
-
-      # now in manage account page
-      assert page.has_text? 'Virtual Machines'
-      assert page.has_text? 'Repositories'
-      assert page.has_text? 'SSH Keys'
-      assert page.has_text? 'Current Token'
-
-      assert page.has_text? 'The Arvados API token is a secret key that enables the Arvados SDKs to access Arvados'
-
-      click_link 'Add new SSH key'
-
-      within '.modal-content' do
-        assert page.has_text? 'Public Key'
-        assert page.has_button? 'Cancel'
-        assert page.has_button? 'Submit'
-
-        page.find_field('public_key').set 'first test with an incorrect ssh key value'
-        click_button 'Submit'
-        assert page.has_text? 'Public key does not appear to be a valid ssh-rsa or dsa public key'
-
-        public_key_str = api_fixture('authorized_keys')['active']['public_key']
-        page.find_field('public_key').set public_key_str
-        page.find_field('name').set 'added_in_test'
-        click_button 'Submit'
-        assert page.has_text? 'Public key already exists in the database, use a different key.'
-
-        new_key = SSHKey.generate
-        page.find_field('public_key').set new_key.ssh_public_key
-        page.find_field('name').set 'added_in_test'
-        click_button 'Submit'
-      end
-    end
-
-    # key must be added. look for it in the refreshed page
-    assert page.has_text? 'added_in_test'
-  end
-
-  # Check manage profile page and add missing profile to the user
-  def add_profile user
-    assert page.has_no_text? 'My projects'
-    assert page.has_no_text? 'Projects shared with me'
-
-    assert page.has_text? 'Profile'
-    assert page.has_text? 'First name'
-    assert page.has_text? 'Last name'
-    assert page.has_text? 'Identity URL'
-    assert page.has_text? 'Email'
-    assert page.has_text? user['email']
-
-    # Using the default profile which has message and one required field
-
-    # Save profile without filling in the required field. Expect to be back in this profile page again
-    click_button "Save profile"
-    assert page.has_text? 'Profile'
-    assert page.has_text? 'First name'
-    assert page.has_text? 'Last name'
-    assert page.has_text? 'Save profile'
-
-    # This time fill in required field and then save. Expect to go to requested page after that.
-    profile_message = Rails.configuration.user_profile_form_message
-    required_field_title = ''
-    required_field_key = ''
-    profile_config = Rails.configuration.user_profile_form_fields
-    profile_config.andand.each do |entry|
-      if entry['required']
-        required_field_key = entry['key']
-        required_field_title = entry['form_field_title']
-      end
-    end
-
-    assert page.has_text? profile_message[0,25]
-    assert page.has_text? required_field_title
-    page.find_field('user[prefs][:profile][:'+required_field_key+']').set 'value to fill required field'
-
-    click_button "Save profile"
-    # profile saved and in profile page now with success
-    assert page.has_text? 'Thank you for filling in your profile'
-    click_button 'Access Arvados Workbench'
-
-    # profile saved and in home page now
-    assert page.has_text? 'My projects'
-    assert page.has_text? 'Projects shared with me'
-  end
-
-  # test the search box
-  def verify_search_box user
-    if user && user['is_active']
-      # let's search for a valid uuid
-      within('.navbar-fixed-top') do
-        page.find_field('search').set user['uuid']
-        page.find('.glyphicon-search').click
-      end
-
-      # we should now be in the user's page as a result of search
-      assert page.has_text? user['first_name']
-
-      # let's search again for an invalid valid uuid
-      within('.navbar-fixed-top') do
-        search_for = String.new user['uuid']
-        search_for[0]='1'
-        page.find_field('search').set search_for
-        page.find('.glyphicon-search').click
-      end
-
-      # we should see 'not found' error page
-      assert page.has_text? 'Not Found'
-
-      # let's search for the anonymously accessible project
-      publicly_accessible_project = api_fixture('groups')['anonymously_accessible_project']
-
-      within('.navbar-fixed-top') do
-        # search again for the anonymously accessible project
-        page.find_field('search').set publicly_accessible_project['name'][0,10]
-        page.find('.glyphicon-search').click
-      end
-
-      within '.modal-content' do
-        assert page.has_text? 'All projects'
-        assert page.has_text? 'Search'
-        assert page.has_text? 'Cancel'
-        assert_selector('div', text: publicly_accessible_project['name'])
-        find(:xpath, '//div[./span[contains(.,publicly_accessible_project["uuid"])]]').click
-
-        click_button 'Show'
-      end
-
-      # seeing "Unrestricted public data" now
-      assert page.has_text? publicly_accessible_project['name']
-      assert page.has_text? publicly_accessible_project['description']
+      assert page.has_text? 'Add a new user'
+    else
+      assert page.has_no_link?('system-menu'), 'Found link - system menu'
     end
   end
 
@@ -259,92 +118,134 @@ class ApplicationLayoutTest < ActionDispatch::IntegrationTest
     ['active', api_fixture('users')['active'], true, true],
     ['admin', api_fixture('users')['admin'], true, true],
     ['active_no_prefs', api_fixture('users')['active_no_prefs'], true, false],
-    ['active_no_prefs_profile', api_fixture('users')['active_no_prefs_profile'], true, false],
+    ['active_no_prefs_profile_no_getting_started_shown',
+        api_fixture('users')['active_no_prefs_profile_no_getting_started_shown'], true, false],
   ].each do |token, user, invited, has_profile|
-      test "visit home page when profile is configured for user #{token}" do
-      # Our test config enabled profile by default. So, no need to update config
+
+    test "visit home page for user #{token}" do
       if !token
         visit ('/')
       else
         visit page_with_token(token)
       end
 
-      verify_homepage_with_profile user, invited, has_profile
+      verify_homepage user, invited, has_profile
     end
-  end
-
-  [
-    [nil, nil, false, false],
-    ['inactive', api_fixture('users')['inactive'], true, false],
-    ['inactive_uninvited', api_fixture('users')['inactive_uninvited'], false, false],
-    ['active', api_fixture('users')['active'], true, true],
-    ['admin', api_fixture('users')['admin'], true, true],
-    ['active_no_prefs', api_fixture('users')['active_no_prefs'], true, false],
-    ['active_no_prefs_profile', api_fixture('users')['active_no_prefs_profile'], true, false],
-  ].each do |token, user, invited, has_profile|
-    test "visit home page when profile not configured for user #{token}" do
-      Rails.configuration.user_profile_form_fields = false
 
+    test "check help for user #{token}" do
       if !token
         visit ('/')
       else
         visit page_with_token(token)
       end
 
-      verify_homepage_with_profile user, invited, has_profile
+      check_help_menu
     end
-  end
-
-  [
-    [nil, nil, false, false],
-    ['inactive', api_fixture('users')['inactive'], true, false],
-    ['inactive_uninvited', api_fixture('users')['inactive_uninvited'], false, false],
-    ['active', api_fixture('users')['active'], true, true],
-    ['admin', api_fixture('users')['admin'], true, true],
-    ['active_no_prefs', api_fixture('users')['active_no_prefs'], true, false],
-    ['active_no_prefs_profile', api_fixture('users')['active_no_prefs_profile'], true, false],
-  ].each do |token, user, invited, has_profile|
-    test "check help for user #{token}" do
-      Rails.configuration.user_profile_form_fields = false
 
+    test "test system menu for user #{token}" do
       if !token
         visit ('/')
       else
         visit page_with_token(token)
       end
 
-      check_help_menu
+      verify_system_menu user
     end
   end
 
-  [
-    ['active', api_fixture('users')['active'], true, true],
-    ['admin', api_fixture('users')['admin'], true, true],
-  ].each do |token, user|
-    test "test system menu for user #{token}" do
-      visit page_with_token(token)
-      verify_system_menu user
+  test "test getting started help menu item" do
+    visit page_with_token('active')
+    within '.navbar-fixed-top' do
+      find('.help-menu > a').click
+      find('.help-menu .dropdown-menu a', text: 'Getting Started ...').click
     end
-  end
 
-  [
-    ['active', api_fixture('users')['active'], true, true],
-    ['admin', api_fixture('users')['admin'], true, true],
-  ].each do |token, user|
-    test "test manage account for user #{token}" do
-      visit page_with_token(token)
-      verify_manage_account user
+    within '.modal-content' do
+      assert_text 'Getting Started'
+      assert_selector 'button:not([disabled])', text: 'Next'
+      assert_no_selector 'button:not([disabled])', text: 'Prev'
+
+      # Use Next button to enable Prev button
+      click_button 'Next'
+      assert_selector 'button:not([disabled])', text: 'Prev'  # Prev button is now enabled
+      click_button 'Prev'
+      assert_no_selector 'button:not([disabled])', text: 'Prev'  # Prev button is again disabled
+
+      # Click Next until last page is reached and verify that it is disabled
+      (0..20).each do |i|   # currently we only have 4 pages, and don't expect to have more than 20 in future
+        click_button 'Next'
+        begin
+          find('button:not([disabled])', text: 'Next')
+        rescue => e
+          break
+        end
+      end
+      assert_no_selector 'button:not([disabled])', text: 'Next'  # Next button is disabled
+      assert_selector 'button:not([disabled])', text: 'Prev'     # Prev button is enabled
+      click_button 'Prev'
+      assert_selector 'button:not([disabled])', text: 'Next'     # Next button is now enabled
+
+      first('button', text: 'x').click
     end
+    assert_text 'Active pipelines' # seeing dashboard now
   end
 
-  [
-    ['active', api_fixture('users')['active'], true, true],
-    ['admin', api_fixture('users')['admin'], true, true],
-  ].each do |token, user|
-    test "test search for user #{token}" do
-      visit page_with_token(token)
-      verify_search_box user
+  test "test arvados_public_data_doc_url config unset" do
+    Rails.configuration.arvados_public_data_doc_url = false
+
+    visit page_with_token('active')
+    within '.navbar-fixed-top' do
+      find('.help-menu > a').click
+
+      assert_no_selector 'a', text:'Public Pipelines and Data sets'
+
+      assert_selector 'a', text:'Getting Started ...'
+      assert page.has_link?('Tutorials and User guide'), 'No link - Tutorials and User guide'
+      assert page.has_link?('API Reference'), 'No link - API Reference'
+      assert page.has_link?('SDK Reference'), 'No link - SDK Reference'
+      assert page.has_link?('Show version / debugging info ...'), 'No link - Show version / debugging info'
+      assert page.has_link?('Report a problem ...'), 'No link - Report a problem'
     end
   end
 
+  test "no SSH public key notification when shell_in_a_box_url is configured" do
+    Rails.configuration.shell_in_a_box_url = 'example.com'
+    visit page_with_token('job_reader')
+    click_link 'notifications-menu'
+    assert_no_selector 'a', text:'Click here to set up an SSH public key for use with Arvados.'
+    assert_selector 'a', text:'Click here to learn how to run an Arvados Crunch pipeline'
+  end
+
+   [
+    ['Repositories',nil,'s0uqq'],
+    ['Virtual machines','virtual machine','current_user_logins'],
+    ['SSH keys',nil,'public_key'],
+    ['Links','link','link_class'],
+    ['Groups','group','group_class'],
+    ['Compute nodes','node','info[ping_secret'],
+    ['Keep services','keep service','service_ssl_flag'],
+    ['Keep disks', 'keep disk','bytes_free'],
+  ].each do |page_name, add_button_text, look_for|
+    test "test system menu #{page_name} link" do
+      visit page_with_token('admin')
+      within('.navbar-fixed-top') do
+        page.find("#system-menu").click
+        within('.dropdown-menu') do
+          assert_selector 'a', text: page_name
+          find('a', text: page_name).click
+        end
+      end
+
+      # click the add button if it exists
+      if add_button_text
+        assert_selector 'button', text: "Add a new #{add_button_text}"
+        find('button', text: "Add a new #{add_button_text}").click
+      else
+        assert_no_selector 'button', text:"Add a new"
+      end
+
+      # look for unique property in the current page
+      assert_text look_for
+    end
+  end
 end