X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/2f46fb5769f41ac9cddf8c46bd0d2ab094375e82..0e94528878341faa941247eb3d990230c941868c:/services/api/test/unit/node_test.rb

diff --git a/services/api/test/unit/node_test.rb b/services/api/test/unit/node_test.rb
index 3895f04552..4cb7a0a1b1 100644
--- a/services/api/test/unit/node_test.rb
+++ b/services/api/test/unit/node_test.rb
@@ -1,3 +1,7 @@
+# Copyright (C) The Arvados Authors. All rights reserved.
+#
+# SPDX-License-Identifier: AGPL-3.0
+
 require 'test_helper'
 require 'tmpdir'
 require 'tempfile'
@@ -79,18 +83,12 @@ class NodeTest < ActiveSupport::TestCase
   end
 
   test "don't leave temp files behind if there's an error writing them" do
+    Rails.configuration.dns_server_conf_template = Rails.root.join 'config', 'unbound.template'
     Tempfile.any_instance.stubs(:puts).raises(IOError)
     Dir.mktmpdir do |tmpdir|
       Rails.configuration.dns_server_conf_dir = tmpdir
-      # This works
-      assert_raises IOError do
-        Tempfile.open(['testfile.txt']) do |f|
-          f.puts "This won't get written."
-        end
-      end
-      # This fails
       refute Node.dns_server_update 'compute65535', '127.0.0.127'
-      assert Dir.entries(tmpdir).select{|f| File.file? f}.empty?
+      assert_empty Dir.entries(tmpdir).select{|f| File.file? f}
     end
   end
 
@@ -134,9 +132,8 @@ class NodeTest < ActiveSupport::TestCase
   test "ping two nodes one with no hostname and one with hostname and check hostnames" do
     # ping node with no hostname and expect it set with config format
     node = ping_node(:new_with_no_hostname, {})
-    slot_number = node.slot_number
     refute_nil node.slot_number
-    assert_equal "compute#{slot_number}", node.hostname
+    assert_equal "compute#{node.slot_number}", node.hostname
 
     # ping node with a hostname and expect it to be unchanged
     node2 = ping_node(:new_with_custom_hostname, {})
@@ -197,4 +194,22 @@ class NodeTest < ActiveSupport::TestCase
       assert_equal '10.5.5.5', n1.ip_address
     end
   end
+
+  test 'run out of slots' do
+    Rails.configuration.max_compute_nodes = 3
+    act_as_system_user do
+      Node.destroy_all
+      (1..4).each do |i|
+        n = Node.create!
+        args = { ip: "10.0.0.#{i}", ping_secret: n.info['ping_secret'] }
+        if i <= Rails.configuration.max_compute_nodes
+          n.ping(args)
+        else
+          assert_raises do
+            n.ping(args)
+          end
+        end
+      end
+    end
+  end
 end