X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/2ca82cf645eb7d9dad60f98e1feca67042c38c47..86660414472d4ff0d8267f9845a753497bd41692:/lib/config/load.go

diff --git a/lib/config/load.go b/lib/config/load.go
index abb3a804ba..fbd01488a0 100644
--- a/lib/config/load.go
+++ b/lib/config/load.go
@@ -345,6 +345,7 @@ func (ldr *Loader) Load() (*arvados.Config, error) {
 			ldr.checkEnum("Containers.LocalKeepLogsToContainerLog", cc.Containers.LocalKeepLogsToContainerLog, "none", "all", "errors"),
 			ldr.checkEmptyKeepstores(cc),
 			ldr.checkUnlistedKeepstores(cc),
+			ldr.checkLocalKeepBlobBuffers(cc),
 			ldr.checkStorageClasses(cc),
 			ldr.checkCUDAVersions(cc),
 			// TODO: check non-empty Rendezvous on
@@ -366,7 +367,7 @@ func (ldr *Loader) checkClusterID(label, clusterID string, emptyStringOk bool) e
 	if emptyStringOk && clusterID == "" {
 		return nil
 	} else if !acceptableClusterIDRe.MatchString(clusterID) {
-		return fmt.Errorf("%s: cluster ID should be 5 alphanumeric characters", label)
+		return fmt.Errorf("%s: cluster ID should be 5 lowercase alphanumeric characters", label)
 	}
 	return nil
 }
@@ -503,6 +504,24 @@ cluster:
 	return nil
 }
 
+func (ldr *Loader) checkLocalKeepBlobBuffers(cc arvados.Cluster) error {
+	kbb := cc.Containers.LocalKeepBlobBuffersPerVCPU
+	if kbb == 0 {
+		return nil
+	}
+	for uuid, vol := range cc.Volumes {
+		if len(vol.AccessViaHosts) > 0 {
+			ldr.Logger.Warnf("LocalKeepBlobBuffersPerVCPU is %d but will not be used because at least one volume (%s) uses AccessViaHosts -- suggest changing to 0", kbb, uuid)
+			return nil
+		}
+		if !vol.ReadOnly && vol.Replication < cc.Collections.DefaultReplication {
+			ldr.Logger.Warnf("LocalKeepBlobBuffersPerVCPU is %d but will not be used because at least one volume (%s) has lower replication than DefaultReplication (%d < %d) -- suggest changing to 0", kbb, uuid, vol.Replication, cc.Collections.DefaultReplication)
+			return nil
+		}
+	}
+	return nil
+}
+
 func (ldr *Loader) checkStorageClasses(cc arvados.Cluster) error {
 	classOnVolume := map[string]bool{}
 	for volid, vol := range cc.Volumes {