X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/2c5417221843491727e4e5505012fc115e3bc7b0..9df2ccdfc085a8b33aed9568c433b7f6e2c24353:/lib/controller/handler.go diff --git a/lib/controller/handler.go b/lib/controller/handler.go index cc06246420..2dd1d816e0 100644 --- a/lib/controller/handler.go +++ b/lib/controller/handler.go @@ -6,7 +6,6 @@ package controller import ( "context" - "database/sql" "errors" "fmt" "net/http" @@ -16,13 +15,14 @@ import ( "time" "git.arvados.org/arvados.git/lib/controller/federation" - "git.arvados.org/arvados.git/lib/controller/localdb" "git.arvados.org/arvados.git/lib/controller/railsproxy" "git.arvados.org/arvados.git/lib/controller/router" + "git.arvados.org/arvados.git/lib/ctrlctx" "git.arvados.org/arvados.git/sdk/go/arvados" "git.arvados.org/arvados.git/sdk/go/ctxlog" "git.arvados.org/arvados.git/sdk/go/health" "git.arvados.org/arvados.git/sdk/go/httpserver" + "github.com/jmoiron/sqlx" _ "github.com/lib/pq" ) @@ -34,7 +34,7 @@ type Handler struct { proxy *proxy secureClient *http.Client insecureClient *http.Client - pgdb *sql.DB + pgdb *sqlx.DB pgdbMtx sync.Mutex } @@ -87,7 +87,7 @@ func (h *Handler) setup() { Routes: health.Routes{"ping": func() error { _, err := h.db(context.TODO()); return err }}, }) - rtr := router.New(federation.New(h.Cluster), localdb.WrapCallsInTransactions(h.db)) + rtr := router.New(federation.New(h.Cluster), ctrlctx.WrapCallsInTransactions(h.db)) mux.Handle("/arvados/v1/config", rtr) mux.Handle("/"+arvados.EndpointUserAuthenticate.Path, rtr) @@ -121,14 +121,14 @@ func (h *Handler) setup() { var errDBConnection = errors.New("database connection error") -func (h *Handler) db(ctx context.Context) (*sql.DB, error) { +func (h *Handler) db(ctx context.Context) (*sqlx.DB, error) { h.pgdbMtx.Lock() defer h.pgdbMtx.Unlock() if h.pgdb != nil { return h.pgdb, nil } - db, err := sql.Open("postgres", h.Cluster.PostgreSQL.Connection.String()) + db, err := sqlx.Open("postgres", h.Cluster.PostgreSQL.Connection.String()) if err != nil { ctxlog.FromContext(ctx).WithError(err).Error("postgresql connect failed") return nil, errDBConnection @@ -137,7 +137,7 @@ func (h *Handler) db(ctx context.Context) (*sql.DB, error) { db.SetMaxOpenConns(p) } if err := db.Ping(); err != nil { - ctxlog.FromContext(ctx).WithError(err).Error("postgresql connect scuceeded but ping failed") + ctxlog.FromContext(ctx).WithError(err).Error("postgresql connect succeeded but ping failed") return nil, errDBConnection } h.pgdb = db