X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/2c3c9f64426e825295aeb1f4265d67429ee14cf6..060d38d627bd1e51dd2b3c6e7de9af6aa7d7b6f3:/apps/workbench/test/controllers/projects_controller_test.rb diff --git a/apps/workbench/test/controllers/projects_controller_test.rb b/apps/workbench/test/controllers/projects_controller_test.rb index a036a8f4f6..f45f178395 100644 --- a/apps/workbench/test/controllers/projects_controller_test.rb +++ b/apps/workbench/test/controllers/projects_controller_test.rb @@ -1,3 +1,7 @@ +# Copyright (C) The Arvados Authors. All rights reserved. +# +# SPDX-License-Identifier: AGPL-3.0 + require 'test_helper' require 'helpers/share_object_helper' @@ -101,8 +105,9 @@ class ProjectsControllerTest < ActionController::TestCase end test "project admin can remove collections from the project" do - # Deleting an object that supports 'expires_at' should make it - # completely inaccessible to API queries, not simply moved out of the project. + # Deleting an object that supports 'trash_at' should make it + # completely inaccessible to API queries, not simply moved out of + # the project. coll_key = "collection_to_remove_from_subproject" coll_uuid = api_fixture("collections")[coll_key]["uuid"] delete(:remove_item, @@ -116,12 +121,12 @@ class ProjectsControllerTest < ActionController::TestCase use_token :subproject_admin assert_raise ArvadosApiClient::NotFoundException do - Collection.find(coll_uuid) + Collection.find(coll_uuid, cache: false) end end test "project admin can remove items from project other than collections" do - # An object which does not have an expired_at field (e.g. Specimen) + # An object which does not have an trash_at field (e.g. Specimen) # should be implicitly moved to the user's Home project when removed. specimen_uuid = api_fixture('specimens', 'in_asubproject')['uuid'] delete(:remove_item, @@ -239,7 +244,7 @@ class ProjectsControllerTest < ActionController::TestCase Rails.configuration.anonymous_user_token = api_fixture('api_client_authorizations')['anonymous']['api_token'] get(:show, {id: api_fixture('groups')['aproject']['uuid']}) assert_response 404 - assert_includes @response.inspect, 'you are not logged in' + assert_match(/log ?in/i, @response.body) end test "visit home page as anonymous when anonymous browsing is enabled and expect login" do @@ -334,19 +339,21 @@ class ProjectsControllerTest < ActionController::TestCase found.description = 'Textile description with link to home page take me home.' found.save! get(:show, {id: project['uuid']}, session_for(:active)) - assert_not_includes 'Textile description with link to home page take me home.', @response.body - assert_match /Textile description with link to home page .*a href=.*take me home.*\/a.*./, @response.body + assert_includes @response.body, 'Textile description with link to home page take me home.' end test "find a project and edit description to textile description with link to object" do project = api_fixture('groups')['aproject'] use_token :active found = Group.find(project['uuid']) + + # uses 'Link to object' as a hyperlink for the object found.description = '"Link to object":' + api_fixture('groups')['asubproject']['uuid'] found.save! get(:show, {id: project['uuid']}, session_for(:active)) - assert_not_includes '"Link to object"', @response.body - assert_match /href=.*Link to object.*\/a./, @response.body + + # check that input was converted to textile, not staying as inputted + refute_includes @response.body,'"Link to object"' refute_empty css_select('[href="/groups/zzzzz-j7d0g-axqo7eu9pwvna1x"]') end @@ -368,4 +375,198 @@ class ProjectsControllerTest < ActionController::TestCase assert_includes @response.body, '
Public Projects" + end + + test 'all_projects unaffected by params after use by ProjectsController (#6640)' do + @controller = ProjectsController.new + project_uuid = api_fixture('groups')['aproject']['uuid'] + get :index, { + filters: [['uuid', '<', project_uuid]].to_json, + limit: 0, + offset: 1000, + }, session_for(:active) + assert_select "#projects-menu + ul li.divider ~ li a[href=/projects/#{project_uuid}]" + end + + [ + ["active", 5, ["aproject", "asubproject"], "anonymously_accessible_project"], + ["user1_with_load", 2, ["project_with_10_collections"], "project_with_2_pipelines_and_60_crs"], + ["admin", 5, ["anonymously_accessible_project", "subproject_in_anonymous_accessible_project"], "aproject"], + ].each do |user, page_size, tree_segment, unexpected| + # Note: this test is sensitive to database collation. It passes + # with en_US.UTF-8. + test "build my projects tree for #{user} user and verify #{unexpected} is omitted" do + use_token user + + tree, _, _ = @controller.send(:my_wanted_projects_tree, + User.current, + page_size) + + tree_segment_at_depth_1 = api_fixture('groups')[tree_segment[0]] + tree_segment_at_depth_2 = api_fixture('groups')[tree_segment[1]] if tree_segment[1] + + node_depth = {} + tree.each do |x| + node_depth[x[:object]['uuid']] = x[:depth] + end + + assert_equal(1, node_depth[tree_segment_at_depth_1['uuid']]) + assert_equal(2, node_depth[tree_segment_at_depth_2['uuid']]) if tree_segment[1] + + unexpected_project = api_fixture('groups')[unexpected] + assert_nil(node_depth[unexpected_project['uuid']], node_depth.inspect) + end + end + + [ + ["active", 1], + ["project_viewer", 1], + ["admin", 0], + ].each do |user, size| + test "starred projects for #{user}" do + use_token user + ctrl = ProjectsController.new + current_user = User.find(api_fixture('users')[user]['uuid']) + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(size, my_starred_project.andand.size) + + ctrl2 = ProjectsController.new + current_user = User.find(api_fixture('users')[user]['uuid']) + my_starred_project = ctrl2.send :my_starred_projects, current_user + assert_equal(size, my_starred_project.andand.size) + end + end + + test "unshare project and verify that it is no longer included in shared user's starred projects" do + # remove sharing link + use_token :system_user + Link.find(api_fixture('links')['share_starred_project_with_project_viewer']['uuid']).destroy + + # verify that project is no longer included in starred projects + use_token :project_viewer + current_user = User.find(api_fixture('users')['project_viewer']['uuid']) + ctrl = ProjectsController.new + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(0, my_starred_project.andand.size) + + # share it again + @controller = LinksController.new + post :create, { + link: { + link_class: 'permission', + name: 'can_read', + head_uuid: api_fixture('groups')['starred_and_shared_active_user_project']['uuid'], + tail_uuid: api_fixture('users')['project_viewer']['uuid'], + }, + format: :json + }, session_for(:system_user) + + # verify that the project is again included in starred projects + use_token :project_viewer + ctrl = ProjectsController.new + my_starred_project = ctrl.send :my_starred_projects, current_user + assert_equal(1, my_starred_project.andand.size) + end end