X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/243f15e69ed3a5514be89115d3ec231551d31cb8..573362771278b2ea5c532857d050151d3ce9c060:/lib/cmd/cmd_test.go

diff --git a/lib/cmd/cmd_test.go b/lib/cmd/cmd_test.go
index fc20befdf7..2d03722adc 100644
--- a/lib/cmd/cmd_test.go
+++ b/lib/cmd/cmd_test.go
@@ -6,11 +6,13 @@ package cmd
 
 import (
 	"bytes"
+	"flag"
 	"fmt"
 	"io"
 	"strings"
 	"testing"
 
+	"git.arvados.org/arvados.git/lib/cmdtest"
 	check "gopkg.in/check.v1"
 )
 
@@ -23,28 +25,48 @@ var _ = check.Suite(&CmdSuite{})
 
 type CmdSuite struct{}
 
-var testCmd = Multi(map[string]RunFunc{
-	"echo": func(prog string, args []string, stdin io.Reader, stdout io.Writer, stderr io.Writer) int {
+var testCmd = Multi(map[string]Handler{
+	"echo": HandlerFunc(func(prog string, args []string, stdin io.Reader, stdout io.Writer, stderr io.Writer) int {
 		fmt.Fprintln(stdout, strings.Join(args, " "))
 		return 0
-	},
+	}),
 })
 
 func (s *CmdSuite) TestHello(c *check.C) {
+	defer cmdtest.LeakCheck(c)()
 	stdout := bytes.NewBuffer(nil)
 	stderr := bytes.NewBuffer(nil)
-	exited := testCmd("prog", []string{"echo", "hello", "world"}, bytes.NewReader(nil), stdout, stderr)
+	exited := testCmd.RunCommand("prog", []string{"echo", "hello", "world"}, bytes.NewReader(nil), stdout, stderr)
 	c.Check(exited, check.Equals, 0)
 	c.Check(stdout.String(), check.Equals, "hello world\n")
 	c.Check(stderr.String(), check.Equals, "")
 }
 
-func (s *CmdSuite) TestWithLateSubcommand(c *check.C) {
+func (s *CmdSuite) TestHelloViaProg(c *check.C) {
+	defer cmdtest.LeakCheck(c)()
 	stdout := bytes.NewBuffer(nil)
 	stderr := bytes.NewBuffer(nil)
-	run := WithLateSubcommand(testCmd, []string{"format", "f"}, []string{"n"})
-	exited := run("prog", []string{"--format=yaml", "-n", "-format", "beep", "echo", "hi"}, bytes.NewReader(nil), stdout, stderr)
+	exited := testCmd.RunCommand("/usr/local/bin/echo", []string{"hello", "world"}, bytes.NewReader(nil), stdout, stderr)
 	c.Check(exited, check.Equals, 0)
-	c.Check(stdout.String(), check.Equals, "--format=yaml -n -format beep hi\n")
+	c.Check(stdout.String(), check.Equals, "hello world\n")
 	c.Check(stderr.String(), check.Equals, "")
 }
+
+func (s *CmdSuite) TestUsage(c *check.C) {
+	defer cmdtest.LeakCheck(c)()
+	stdout := bytes.NewBuffer(nil)
+	stderr := bytes.NewBuffer(nil)
+	exited := testCmd.RunCommand("prog", []string{"nosuchcommand", "hi"}, bytes.NewReader(nil), stdout, stderr)
+	c.Check(exited, check.Equals, 2)
+	c.Check(stdout.String(), check.Equals, "")
+	c.Check(stderr.String(), check.Matches, `(?ms)^prog: unrecognized command "nosuchcommand"\n.*echo.*\n`)
+}
+
+func (s *CmdSuite) TestSubcommandToFront(c *check.C) {
+	defer cmdtest.LeakCheck(c)()
+	flags := flag.NewFlagSet("", flag.ContinueOnError)
+	flags.String("format", "json", "")
+	flags.Bool("n", false, "")
+	args := SubcommandToFront([]string{"--format=yaml", "-n", "-format", "beep", "echo", "hi"}, flags)
+	c.Check(args, check.DeepEquals, []string{"echo", "--format=yaml", "-n", "-format", "beep", "hi"})
+}