X-Git-Url: https://git.arvados.org/arvados.git/blobdiff_plain/1a2a05a4714a4bc538800d08d353b0306d5e49ad..8b097ea832516b3f5104c62a40a6d9cf4826232a:/services/keepstore/logging_router.go?ds=sidebyside diff --git a/services/keepstore/logging_router.go b/services/keepstore/logging_router.go index fd4e23467d..a93b72cf61 100644 --- a/services/keepstore/logging_router.go +++ b/services/keepstore/logging_router.go @@ -4,38 +4,60 @@ package main // LoggingResponseWriter import ( - "github.com/gorilla/mux" "log" "net/http" + "strings" + "time" ) +// LoggingResponseWriter has anonymous fields ResponseWriter and ResponseBody type LoggingResponseWriter struct { Status int Length int http.ResponseWriter + ResponseBody string + sentHdr time.Time } +// WriteHeader writes header to ResponseWriter func (loggingWriter *LoggingResponseWriter) WriteHeader(code int) { + if loggingWriter.sentHdr == zeroTime { + loggingWriter.sentHdr = time.Now() + } loggingWriter.Status = code loggingWriter.ResponseWriter.WriteHeader(code) } +var zeroTime time.Time + func (loggingWriter *LoggingResponseWriter) Write(data []byte) (int, error) { + if loggingWriter.Length == 0 && len(data) > 0 && loggingWriter.sentHdr == zeroTime { + loggingWriter.sentHdr = time.Now() + } loggingWriter.Length += len(data) + if loggingWriter.Status >= 400 { + loggingWriter.ResponseBody += string(data) + } return loggingWriter.ResponseWriter.Write(data) } +// LoggingRESTRouter is used to add logging capabilities to mux.Router type LoggingRESTRouter struct { - router *mux.Router -} - -func MakeLoggingRESTRouter() *LoggingRESTRouter { - router := MakeRESTRouter() - return (&LoggingRESTRouter{router}) + router http.Handler } func (loggingRouter *LoggingRESTRouter) ServeHTTP(resp http.ResponseWriter, req *http.Request) { - loggingWriter := LoggingResponseWriter{200, 0, resp} + t0 := time.Now() + loggingWriter := LoggingResponseWriter{http.StatusOK, 0, resp, "", zeroTime} loggingRouter.router.ServeHTTP(&loggingWriter, req) - log.Printf("[%s] %s %s %d %d", req.RemoteAddr, req.Method, req.URL.Path[1:], loggingWriter.Status, loggingWriter.Length) + statusText := http.StatusText(loggingWriter.Status) + if loggingWriter.Status >= 400 { + statusText = strings.Replace(loggingWriter.ResponseBody, "\n", "", -1) + } + now := time.Now() + tTotal := now.Sub(t0) + tLatency := loggingWriter.sentHdr.Sub(t0) + tResponse := now.Sub(loggingWriter.sentHdr) + log.Printf("[%s] %s %s %d %.6fs %.6fs %.6fs %d %d \"%s\"", req.RemoteAddr, req.Method, req.URL.Path[1:], req.ContentLength, tTotal.Seconds(), tLatency.Seconds(), tResponse.Seconds(), loggingWriter.Status, loggingWriter.Length, statusText) + }